Skip to content

Commit 827be8f

Browse files
author
Tang Chen
committed
Move keys() methods in each resource class to FakeResource
FakeXXX classes in network don't need to fake any method, except keys(). But keys() can be put in FakeResource since it just returns all attributes in _info. This patch moves removes all unnecessary fake methods code, moves keys() method to FakeResource. This patch also finds out some missing attributes in network and router tests. Change-Id: I799822c8715b9ac4f95b98f8350f196757d79d3e
1 parent cb8f757 commit 827be8f

4 files changed

Lines changed: 63 additions & 166 deletions

File tree

openstackclient/tests/fakes.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,9 @@ def __repr__(self):
183183
info = ", ".join("%s=%s" % (k, getattr(self, k)) for k in reprkeys)
184184
return "<%s %s>" % (self.__class__.__name__, info)
185185

186+
def keys(self):
187+
return self._info.keys()
188+
186189

187190
class FakeResponse(requests.Response):
188191

0 commit comments

Comments
 (0)