[Identity] Check return value is None in identity v3 unit tests

take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I02af06b3d476aac2d93a23ef2111cdc7fa0892ec
Partial-Bug: #1550636

Author: Tang Chen

openstackclient/tests/identity/v3/test_credential.py

@@ -96,9 +96,11 @@ def test_credential_set_valid(self):
             '--data', self.json_data,
             identity_fakes.credential_id,
         ]
-
         parsed_args = self.check_parser(self.cmd, arglist, [])
-        self.cmd.take_action(parsed_args)
+
+        result = self.cmd.take_action(parsed_args)
+
+        self.assertIsNone(result)
 
     def test_credential_set_valid_with_project(self):
         arglist = [
@@ -108,6 +110,8 @@ def test_credential_set_valid_with_project(self):
             '--project', identity_fakes.project_name,
             identity_fakes.credential_id,
         ]
-
         parsed_args = self.check_parser(self.cmd, arglist, [])
-        self.cmd.take_action(parsed_args)
+
+        result = self.cmd.take_action(parsed_args)
+
+        self.assertIsNone(result)

openstackclient/tests/identity/v3/test_identity_provider.py

@@ -258,10 +258,13 @@ def test_delete_identity_provider(self):
             ('identity_provider', identity_fakes.idp_id),
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
-        self.cmd.take_action(parsed_args)
+
+        result = self.cmd.take_action(parsed_args)
+
         self.identity_providers_mock.delete.assert_called_with(
             identity_fakes.idp_id,
         )
+        self.assertIsNone(result)
 
 
 class TestIdentityProviderList(TestIdentityProvider):

openstackclient/tests/identity/v3/test_mappings.py

@@ -92,11 +92,13 @@ def test_delete_mapping(self):
         verifylist = [
             ('mapping', identity_fakes.mapping_id)
         ]
-
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
-        self.cmd.take_action(parsed_args)
+
+        result = self.cmd.take_action(parsed_args)
+
         self.mapping_mock.delete.assert_called_with(
             identity_fakes.mapping_id)
+        self.assertIsNone(result)
 
 
 class TestMappingList(TestMapping):
@@ -234,7 +236,6 @@ def test_set_rules_wrong_file_path(self):
             ('mapping', identity_fakes.mapping_id),
             ('rules', identity_fakes.mapping_rules_file_path)
         ]
-
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         self.assertRaises(

openstackclient/tests/identity/v3/test_protocol.py

@@ -92,9 +92,12 @@ def test_delete_identity_provider(self):
             ('identity_provider', identity_fakes.idp_id),
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
-        self.cmd.take_action(parsed_args)
+
+        result = self.cmd.take_action(parsed_args)
+
         self.protocols_mock.delete.assert_called_with(
             identity_fakes.idp_id, identity_fakes.protocol_id)
+        self.assertIsNone(result)
 
 
 class TestProtocolList(TestProtocol):

openstackclient/tests/identity/v3/test_role.py

@@ -306,11 +306,12 @@ def test_role_delete_no_options(self):
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
-        self.cmd.take_action(parsed_args)
+        result = self.cmd.take_action(parsed_args)
 
         self.roles_mock.delete.assert_called_with(
             identity_fakes.role_id,
         )
+        self.assertIsNone(result)
 
 
 class TestRoleList(TestRole):
@@ -640,7 +641,7 @@ def test_role_remove_user_domain(self):
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
-        self.cmd.take_action(parsed_args)
+        result = self.cmd.take_action(parsed_args)
 
         # Set expected values
         kwargs = {
@@ -653,6 +654,7 @@ def test_role_remove_user_domain(self):
             identity_fakes.role_id,
             **kwargs
         )
+        self.assertIsNone(result)
 
     def test_role_remove_user_project(self):
         arglist = [
@@ -672,7 +674,7 @@ def test_role_remove_user_project(self):
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
-        self.cmd.take_action(parsed_args)
+        result = self.cmd.take_action(parsed_args)
 
         # Set expected values
         kwargs = {
@@ -685,6 +687,7 @@ def test_role_remove_user_project(self):
             identity_fakes.role_id,
             **kwargs
         )
+        self.assertIsNone(result)
 
     def test_role_remove_group_domain(self):
         arglist = [
@@ -705,7 +708,7 @@ def test_role_remove_group_domain(self):
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
-        self.cmd.take_action(parsed_args)
+        result = self.cmd.take_action(parsed_args)
 
         # Set expected values
         kwargs = {
@@ -718,6 +721,7 @@ def test_role_remove_group_domain(self):
             identity_fakes.role_id,
             **kwargs
         )
+        self.assertIsNone(result)
 
     def test_role_remove_group_project(self):
         arglist = [
@@ -737,7 +741,7 @@ def test_role_remove_group_project(self):
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
-        self.cmd.take_action(parsed_args)
+        result = self.cmd.take_action(parsed_args)
 
         # Set expected values
         kwargs = {
@@ -750,6 +754,7 @@ def test_role_remove_group_project(self):
             identity_fakes.role_id,
             **kwargs
         )
+        self.assertIsNone(result)
 
 
 class TestRoleSet(TestRole):
@@ -778,7 +783,7 @@ def test_role_set_no_options(self):
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
-        self.cmd.take_action(parsed_args)
+        result = self.cmd.take_action(parsed_args)
 
         # Set expected values
         kwargs = {
@@ -789,6 +794,7 @@ def test_role_set_no_options(self):
             identity_fakes.role_id,
             **kwargs
         )
+        self.assertIsNone(result)
 
 
 class TestRoleShow(TestRole):

openstackclient/tests/identity/v3/test_service_provider.py

@@ -188,10 +188,13 @@ def test_delete_service_provider(self):
             ('service_provider', service_fakes.sp_id),
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
-        self.cmd.take_action(parsed_args)
+
+        result = self.cmd.take_action(parsed_args)
+
         self.service_providers_mock.delete.assert_called_with(
             service_fakes.sp_id,
         )
+        self.assertIsNone(result)
 
 
 class TestServiceProviderList(TestServiceProvider):

openstackclient/tests/identity/v3/test_token.py

@@ -123,6 +123,7 @@ def test_token_revoke(self):
         verifylist = [('token', self.TOKEN)]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
-        self.cmd.take_action(parsed_args)
+        result = self.cmd.take_action(parsed_args)
 
         self.tokens_mock.revoke_token.assert_called_with(self.TOKEN)
+        self.assertIsNone(result)

openstackclient/tests/identity/v3/test_trust.py

@@ -141,11 +141,12 @@ def test_trust_delete(self):
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
-        self.cmd.take_action(parsed_args)
+        result = self.cmd.take_action(parsed_args)
 
         self.trusts_mock.delete.assert_called_with(
             identity_fakes.trust_id,
         )
+        self.assertIsNone(result)
 
 
 class TestTrustList(TestTrust):