Skip to content

Commit 7027d91

Browse files
author
reedip
committed
Add default value to pool-prefix in Subnet-pool
If user tries to create a subnet pool without --pool-prefix, it fails at the NeutronServer [1]. This patch tries to add a default value to the --pool-prefix to try and resolve it. Closes-Bug: #1564271 [1] : http://paste.openstack.org/show/492537/ Change-Id: I6cf324a5a8037048602e59c0bbfc93b40e73a74e
1 parent a1a4706 commit 7027d91

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

openstackclient/network/v2/subnet_pool.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,9 @@ def get_parser(self, prog_name):
111111
def take_action(self, parsed_args):
112112
client = self.app.client_manager.network
113113
attrs = _get_attrs(self.app.client_manager, parsed_args)
114+
# NeutronServer expects prefixes to be a List
115+
if "prefixes" not in attrs:
116+
attrs['prefixes'] = []
114117
obj = client.create_subnet_pool(**attrs)
115118
columns = _get_columns(obj)
116119
data = utils.get_item_properties(obj, columns, formatters=_formatters)

openstackclient/tests/network/v2/test_subnet_pool.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ def test_create_prefixlen_options(self):
149149
'default_prefixlen': self._subnet_pool.default_prefixlen,
150150
'max_prefixlen': self._subnet_pool.max_prefixlen,
151151
'min_prefixlen': self._subnet_pool.min_prefixlen,
152+
'prefixes': [],
152153
'name': self._subnet_pool.name,
153154
})
154155
self.assertEqual(self.columns, columns)

0 commit comments

Comments
 (0)