Skip to content

Commit 691ca98

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Use FakeFlavor in TestServerCreate."
2 parents 883278f + b7f6205 commit 691ca98

1 file changed

Lines changed: 7 additions & 11 deletions

File tree

openstackclient/tests/compute/v2/test_server.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,7 @@ def setUp(self):
110110
)
111111
self.cimages_mock.get.return_value = self.image
112112

113-
self.flavor = fakes.FakeResource(
114-
None,
115-
copy.deepcopy(compute_fakes.FLAVOR),
116-
loaded=True,
117-
)
113+
self.flavor = compute_fakes.FakeFlavor.create_one_flavor()
118114
self.flavors_mock.get.return_value = self.flavor
119115

120116
self.volume = fakes.FakeResource(
@@ -192,7 +188,7 @@ def test_server_create_minimal(self):
192188
self.assertEqual(collist, columns)
193189
datalist = (
194190
'',
195-
'Large ()',
191+
self.flavor.name + ' ()',
196192
self.new_server.id,
197193
self.new_server.name,
198194
self.new_server.networks,
@@ -276,7 +272,7 @@ def test_server_create_with_network(self):
276272
self.assertEqual(collist, columns)
277273
datalist = (
278274
'',
279-
'Large ()',
275+
self.flavor.name + ' ()',
280276
self.new_server.id,
281277
self.new_server.name,
282278
self.new_server.networks,
@@ -349,7 +345,7 @@ def test_server_create_userdata(self, mock_open):
349345
self.assertEqual(collist, columns)
350346
datalist = (
351347
'',
352-
'Large ()',
348+
self.flavor.name + ' ()',
353349
self.new_server.id,
354350
self.new_server.name,
355351
self.new_server.networks,
@@ -360,13 +356,13 @@ def test_server_create_userdata(self, mock_open):
360356
def test_server_create_with_block_device_mapping(self):
361357
arglist = [
362358
'--image', 'image1',
363-
'--flavor', compute_fakes.flavor_id,
359+
'--flavor', self.flavor.id,
364360
'--block-device-mapping', compute_fakes.block_device_mapping,
365361
self.new_server.name,
366362
]
367363
verifylist = [
368364
('image', 'image1'),
369-
('flavor', compute_fakes.flavor_id),
365+
('flavor', self.flavor.id),
370366
('block_device_mapping', [compute_fakes.block_device_mapping]),
371367
('config_drive', False),
372368
('server_name', self.new_server.name),
@@ -418,7 +414,7 @@ def test_server_create_with_block_device_mapping(self):
418414
self.assertEqual(collist, columns)
419415
datalist = (
420416
'',
421-
'Large ()',
417+
self.flavor.name + ' ()',
422418
self.new_server.id,
423419
self.new_server.name,
424420
self.new_server.networks,

0 commit comments

Comments
 (0)