Skip to content

Commit 624c39a

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Compute: Fix DisplayCommandBase comments for cliff ShowOne subclass tests"
2 parents f781349 + 23faa33 commit 624c39a

3 files changed

Lines changed: 36 additions & 12 deletions

File tree

openstackclient/tests/compute/v2/test_security_group.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ def test_security_group_create_no_options(self):
8787
]
8888
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
8989

90-
# DisplayCommandBase.take_action() returns two tuples
90+
# In base command class ShowOne in cliff, abstractmethod take_action()
91+
# returns a two-part tuple with a tuple of column names and a tuple of
92+
# data to be shown.
9193
columns, data = self.cmd.take_action(parsed_args)
9294

9395
# SecurityGroupManager.create(name, description)
@@ -110,7 +112,9 @@ def test_security_group_create_description(self):
110112
]
111113
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
112114

113-
# DisplayCommandBase.take_action() returns two tuples
115+
# In base command class ShowOne in cliff, abstractmethod take_action()
116+
# returns a two-part tuple with a tuple of column names and a tuple of
117+
# data to be shown.
114118
columns, data = self.cmd.take_action(parsed_args)
115119

116120
# SecurityGroupManager.create(name, description)

openstackclient/tests/compute/v2/test_security_group_rule.py

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,9 @@ def test_security_group_rule_create_no_options(self):
149149
]
150150
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
151151

152-
# DisplayCommandBase.take_action() returns two tuples
152+
# In base command class ShowOne in cliff, abstractmethod take_action()
153+
# returns a two-part tuple with a tuple of column names and a tuple of
154+
# data to be shown.
153155
columns, data = self.cmd.take_action(parsed_args)
154156

155157
# SecurityGroupManager.create(name, description)
@@ -193,7 +195,9 @@ def test_security_group_rule_create_ftp(self):
193195
]
194196
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
195197

196-
# DisplayCommandBase.take_action() returns two tuples
198+
# In base command class ShowOne in cliff, abstractmethod take_action()
199+
# returns a two-part tuple with a tuple of column names and a tuple of
200+
# data to be shown.
197201
columns, data = self.cmd.take_action(parsed_args)
198202

199203
# SecurityGroupManager.create(name, description)
@@ -241,7 +245,9 @@ def test_security_group_rule_create_ssh(self):
241245
]
242246
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
243247

244-
# DisplayCommandBase.take_action() returns two tuples
248+
# In base command class ShowOne in cliff, abstractmethod take_action()
249+
# returns a two-part tuple with a tuple of column names and a tuple of
250+
# data to be shown.
245251
columns, data = self.cmd.take_action(parsed_args)
246252

247253
# SecurityGroupManager.create(name, description)
@@ -284,7 +290,9 @@ def test_security_group_rule_create_udp(self):
284290
]
285291
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
286292

287-
# DisplayCommandBase.take_action() returns two tuples
293+
# In base command class ShowOne in cliff, abstractmethod take_action()
294+
# returns a two-part tuple with a tuple of column names and a tuple of
295+
# data to be shown.
288296
columns, data = self.cmd.take_action(parsed_args)
289297

290298
# SecurityGroupManager.create(name, description)
@@ -330,7 +338,9 @@ def test_security_group_rule_create_icmp(self):
330338
]
331339
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
332340

333-
# DisplayCommandBase.take_action() returns two tuples
341+
# In base command class ShowOne in cliff, abstractmethod take_action()
342+
# returns a two-part tuple with a tuple of column names and a tuple of
343+
# data to be shown.
334344
columns, data = self.cmd.take_action(parsed_args)
335345

336346
# SecurityGroupManager.create(name, description)

openstackclient/tests/compute/v2/test_server.py

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,9 @@ def test_server_create_minimal(self):
163163
]
164164
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
165165

166-
# DisplayCommandBase.take_action() returns two tuples
166+
# In base command class ShowOne in cliff, abstractmethod take_action()
167+
# returns a two-part tuple with a tuple of column names and a tuple of
168+
# data to be shown.
167169
columns, data = self.cmd.take_action(parsed_args)
168170

169171
# Set expected values
@@ -241,7 +243,9 @@ def test_server_create_with_network(self):
241243
self.app.client_manager.network.find_network = find_network
242244
self.app.client_manager.network.find_port = find_port
243245

244-
# DisplayCommandBase.take_action() returns two tuples
246+
# In base command class ShowOne in cliff, abstractmethod take_action()
247+
# returns a two-part tuple with a tuple of column names and a tuple of
248+
# data to be shown.
245249
columns, data = self.cmd.take_action(parsed_args)
246250

247251
# Set expected values
@@ -299,7 +303,9 @@ def test_server_create_userdata(self, mock_open):
299303
]
300304
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
301305

302-
# DisplayCommandBase.take_action() returns two tuples
306+
# In base command class ShowOne in cliff, abstractmethod take_action()
307+
# returns a two-part tuple with a tuple of column names and a tuple of
308+
# data to be shown.
303309
columns, data = self.cmd.take_action(parsed_args)
304310

305311
# Ensure the userdata file is opened
@@ -551,7 +557,9 @@ def test_server_image_create_no_options(self):
551557
]
552558
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
553559

554-
# DisplayCommandBase.take_action() returns two tuples
560+
# In base command class ShowOne in cliff, abstractmethod take_action()
561+
# returns a two-part tuple with a tuple of column names and a tuple of
562+
# data to be shown.
555563
columns, data = self.cmd.take_action(parsed_args)
556564

557565
# ServerManager.create_image(server, image_name, metadata=)
@@ -574,7 +582,9 @@ def test_server_image_create_name(self):
574582
]
575583
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
576584

577-
# DisplayCommandBase.take_action() returns two tuples
585+
# In base command class ShowOne in cliff, abstractmethod take_action()
586+
# returns a two-part tuple with a tuple of column names and a tuple of
587+
# data to be shown.
578588
columns, data = self.cmd.take_action(parsed_args)
579589

580590
# ServerManager.create_image(server, image_name, metadata=)

0 commit comments

Comments
 (0)