Fix showing network quotas for a project

The OpenStack SDK is now used for the network client. However,
the 'openstack quota show' command wasn't updated for the
client change. As a result, the command will fail to show
network quotas when a project name is specified. For example:

  $ openstack quota show admin
  'Proxy' object has no attribute 'show_quota'

This patch set fixes the command by using the OpenStack SDK
to get network quotas for a project.

Change-Id: I59a7b6780a7b80cd09e79d40d214751b25d3016e
Related-To: blueprint neutron-client
Closes-Bug: #1528249

Author: rtheis

openstackclient/common/quota.py

@@ -196,10 +196,13 @@ def get_compute_volume_quota(self, client, parsed_args):
     def get_network_quota(self, parsed_args):
         if parsed_args.quota_class or parsed_args.default:
             return {}
-        service_catalog = self.app.client_manager.auth_ref.service_catalog
-        if 'network' in service_catalog.get_endpoints():
-            network_client = self.app.client_manager.network
-            return network_client.show_quota(parsed_args.project)['quota']
+        if self.app.client_manager.is_network_endpoint_enabled():
+            identity_client = self.app.client_manager.identity
+            project = utils.find_resource(
+                identity_client.projects,
+                parsed_args.project,
+                ).id
+            return self.app.client_manager.network.get_quota(project)
         else:
             return {}
 

openstackclient/tests/common/test_quota.py

@@ -214,13 +214,15 @@ def setUp(self):
             loaded=True,
         )
 
-        self.service_catalog_mock.get_endpoints.return_value = [
-            fakes.FakeResource(
-                None,
-                copy.deepcopy(identity_fakes.ENDPOINT),
-                loaded=True,
-            )
-        ]
+        fake_network_endpoint = fakes.FakeResource(
+            None,
+            copy.deepcopy(identity_fakes.ENDPOINT),
+            loaded=True,
+        )
+
+        self.service_catalog_mock.get_endpoints.return_value = {
+            'network': fake_network_endpoint
+        }
 
         self.quotas_class_mock.get.return_value = FakeQuotaResource(
             None,
@@ -244,6 +246,8 @@ def setUp(self):
             endpoint=fakes.AUTH_URL,
             token=fakes.AUTH_TOKEN,
         )
+        self.network = self.app.client_manager.network
+        self.network.get_quota = mock.Mock(return_value=network_fakes.QUOTA)
 
         self.cmd = quota.ShowQuota(self.app, None)
 
@@ -260,6 +264,9 @@ def test_quota_show(self):
         self.cmd.take_action(parsed_args)
 
         self.quotas_mock.get.assert_called_with(identity_fakes.project_id)
+        self.volume_quotas_mock.get.assert_called_with(
+            identity_fakes.project_id)
+        self.network.get_quota.assert_called_with(identity_fakes.project_id)
 
     def test_quota_show_with_default(self):
         arglist = [
@@ -276,6 +283,8 @@ def test_quota_show_with_default(self):
         self.cmd.take_action(parsed_args)
 
         self.quotas_mock.defaults.assert_called_with(identity_fakes.project_id)
+        self.volume_quotas_mock.defaults.assert_called_with(
+            identity_fakes.project_id)
 
     def test_quota_show_with_class(self):
         arglist = [
@@ -293,3 +302,5 @@ def test_quota_show_with_class(self):
 
         self.quotas_class_mock.get.assert_called_with(
             identity_fakes.project_id)
+        self.volume_quotas_class_mock.get.assert_called_with(
+            identity_fakes.project_id)

openstackclient/tests/network/v2/fakes.py

@@ -26,6 +26,18 @@
 extension_alias = 'Dystopian'
 extension_links = '[{"href":''"https://github.com/os/network", "type"}]'
 
+QUOTA = {
+    "subnet": 10,
+    "network": 10,
+    "floatingip": 50,
+    "subnetpool": -1,
+    "security_group_rule": 100,
+    "security_group": 10,
+    "router": 10,
+    "rbac_policy": -1,
+    "port": 50,
+}
+
 
 def create_extension():
     extension = mock.Mock()