Search by user defined ID for service providers

IDs for service providers can be user defined (like, Bob). This
causes issues with the usual get by ID method.

Keystone server side has implemented changes to search by ID when
listing, which should resolve the issue with minimal changes to
the client side.

Change-Id: Ic705806e4bc7bb24f946a1fce803a0a0a4d788c1
Closes-Bug: 1555830

Author: Steve Martinelli

openstackclient/identity/v3/service_provider.py

@@ -192,7 +192,8 @@ def take_action(self, parsed_args):
         service_client = self.app.client_manager.identity
         service_provider = utils.find_resource(
             service_client.federation.service_providers,
-            parsed_args.service_provider)
+            parsed_args.service_provider,
+            id=parsed_args.service_provider)
 
         service_provider._info.pop('links', None)
         return zip(*sorted(six.iteritems(service_provider._info)))

openstackclient/tests/identity/v3/test_service_provider.py

@@ -408,6 +408,7 @@ def test_service_provider_show(self):
 
         self.service_providers_mock.get.assert_called_with(
             service_fakes.sp_id,
+            id='BETA'
         )
 
         collist = ('auth_url', 'description', 'enabled', 'id', 'sp_url')