Merge "Add "server group show" command"

Author: Jenkins

doc/source/command-objects/server-group.rst

@@ -63,3 +63,18 @@ List all server groups
 .. option:: --long
 
     List additional fields in output
+
+server group show
+-----------------
+
+Display server group details
+
+.. program:: server group show
+.. code-block:: bash
+
+    os server group show
+        <server-group>
+
+.. describe:: <server-group>
+
+        Server group to display (name or ID)

openstackclient/compute/v2/server_group.py

@@ -156,3 +156,27 @@ def take_action(self, parsed_args):
                         'Members': utils.format_list,
                     }
                 ) for s in data))
+
+
+class ShowServerGroup(command.ShowOne):
+    """Display server group details."""
+
+    def get_parser(self, prog_name):
+        parser = super(ShowServerGroup, self).get_parser(prog_name)
+        parser.add_argument(
+            'server_group',
+            metavar='<server-group>',
+            help='server group to display (name or ID)',
+        )
+        return parser
+
+    def take_action(self, parsed_args):
+        compute_client = self.app.client_manager.compute
+        group = utils.find_resource(compute_client.server_groups,
+                                    parsed_args.server_group)
+        info = {}
+        info.update(group._info)
+        columns = _get_columns(info)
+        data = utils.get_dict_properties(info, columns,
+                                         formatters=_formatters)
+        return columns, data

openstackclient/tests/compute/v2/test_server_group.py

@@ -258,3 +258,26 @@ def test_server_group_list_with_all_projects_and_long(self):
 
         self.assertEqual(self.list_columns_long, columns)
         self.assertEqual(self.list_data_long, tuple(data))
+
+
+class TestServerGroupShow(TestServerGroup):
+
+    def setUp(self):
+        super(TestServerGroupShow, self).setUp()
+
+        self.server_groups_mock.get.return_value = self.fake_server_group
+        self.cmd = server_group.ShowServerGroup(self.app, None)
+
+    def test_server_group_show(self):
+        arglist = [
+            'affinity_group',
+        ]
+        verifylist = [
+            ('server_group', 'affinity_group'),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        columns, data = self.cmd.take_action(parsed_args)
+
+        self.assertEqual(self.columns, columns)
+        self.assertEqual(self.data, data)

releasenotes/notes/add-server-group-command-fde165df53216726.yaml

@@ -0,0 +1,7 @@
+---
+features:
+  - |
+    Add support for compute v2 ``server group`` related commands, include:
+    create, delete, list and show.
+    [Bug `1542171 <https://bugs.launchpad.net/python-openstackclient/+bug/1542171>`_]
+    [Blueprint `nova-server-group-support <https://blueprints.launchpad.net/python-openstackclient/+spec/nova-server-group-support>`_]

setup.cfg

@@ -134,6 +134,7 @@ openstack.compute.v2 =
     server_group_create = openstackclient.compute.v2.server_group:CreateServerGroup
     server_group_delete = openstackclient.compute.v2.server_group:DeleteServerGroup
     server_group_list = openstackclient.compute.v2.server_group:ListServerGroup
+    server_group_show = openstackclient.compute.v2.server_group:ShowServerGroup
 
     usage_list = openstackclient.compute.v2.usage:ListUsage
     usage_show = openstackclient.compute.v2.usage:ShowUsage