Skip to content

Commit 37c83e6

Browse files
author
Steve Martinelli
committed
Fix the way we call find_resource when only using ID
Change-Id: I6fb08edd5499767863e0e67f363bcd9fff3aea60 Closes-Bug: 1475127
1 parent 1af89f7 commit 37c83e6

1 file changed

Lines changed: 18 additions & 6 deletions

File tree

openstackclient/identity/common.py

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,20 +57,32 @@ def find_domain(identity_client, name_or_id):
5757

5858
def find_group(identity_client, name_or_id, domain_name_or_id=None):
5959
domain_id = _get_domain_id_if_requested(identity_client, domain_name_or_id)
60-
return _find_identity_resource(identity_client.groups, name_or_id,
61-
groups.Group, domain_id=domain_id)
60+
if not domain_id:
61+
return _find_identity_resource(identity_client.groups, name_or_id,
62+
groups.Group)
63+
else:
64+
return _find_identity_resource(identity_client.groups, name_or_id,
65+
groups.Group, domain_id=domain_id)
6266

6367

6468
def find_project(identity_client, name_or_id, domain_name_or_id=None):
6569
domain_id = _get_domain_id_if_requested(identity_client, domain_name_or_id)
66-
return _find_identity_resource(identity_client.projects, name_or_id,
67-
projects.Project, domain_id=domain_id)
70+
if not domain_id:
71+
return _find_identity_resource(identity_client.projects, name_or_id,
72+
projects.Project)
73+
else:
74+
return _find_identity_resource(identity_client.projects, name_or_id,
75+
projects.Project, domain_id=domain_id)
6876

6977

7078
def find_user(identity_client, name_or_id, domain_name_or_id=None):
7179
domain_id = _get_domain_id_if_requested(identity_client, domain_name_or_id)
72-
return _find_identity_resource(identity_client.users, name_or_id,
73-
users.User, domain_id=domain_id)
80+
if not domain_id:
81+
return _find_identity_resource(identity_client.users, name_or_id,
82+
users.User)
83+
else:
84+
return _find_identity_resource(identity_client.users, name_or_id,
85+
users.User, domain_id=domain_id)
7486

7587

7688
def _find_identity_resource(identity_client_manager, name_or_id,

0 commit comments

Comments
 (0)