Skip to content

Commit 35dc2be

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "openstack catalog list always returns publicURL for internalURL and adminURL"
2 parents a3f50ea + 7af00f8 commit 35dc2be

2 files changed

Lines changed: 11 additions & 9 deletions

File tree

‎openstackclient/identity/v2_0/catalog.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def _format_endpoints(eps=None):
3131
region = eps[index].get('region', '<none>')
3232
ret += region + '\n'
3333
for url in ['publicURL', 'internalURL', 'adminURL']:
34-
ret += " %s: %s\n" % (url, eps[index]['publicURL'])
34+
ret += " %s: %s\n" % (url, eps[index][url])
3535
return ret
3636

3737

‎openstackclient/tests/identity/v2_0/test_catalog.py‎

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,13 @@ class TestCatalog(utils.TestCommand):
2727
{
2828
'region': 'one',
2929
'publicURL': 'https://public.one.example.com',
30+
'internalURL': 'https://internal.one.example.com',
3031
'adminURL': 'https://admin.one.example.com',
3132
},
3233
{
3334
'region': 'two',
3435
'publicURL': 'https://public.two.example.com',
36+
'internalURL': 'https://internal.two.example.com',
3537
'adminURL': 'https://admin.two.example.com',
3638
},
3739
],
@@ -74,11 +76,11 @@ def test_catalog_list(self):
7476
'supernova',
7577
'compute',
7678
'one\n publicURL: https://public.one.example.com\n '
77-
'internalURL: https://public.one.example.com\n '
78-
'adminURL: https://public.one.example.com\n'
79+
'internalURL: https://internal.one.example.com\n '
80+
'adminURL: https://admin.one.example.com\n'
7981
'two\n publicURL: https://public.two.example.com\n '
80-
'internalURL: https://public.two.example.com\n '
81-
'adminURL: https://public.two.example.com\n',
82+
'internalURL: https://internal.two.example.com\n '
83+
'adminURL: https://admin.two.example.com\n',
8284
), )
8385
self.assertEqual(datalist, tuple(data))
8486

@@ -108,11 +110,11 @@ def test_catalog_show(self):
108110
self.assertEqual(collist, columns)
109111
datalist = (
110112
'one\n publicURL: https://public.one.example.com\n '
111-
'internalURL: https://public.one.example.com\n '
112-
'adminURL: https://public.one.example.com\n'
113+
'internalURL: https://internal.one.example.com\n '
114+
'adminURL: https://admin.one.example.com\n'
113115
'two\n publicURL: https://public.two.example.com\n '
114-
'internalURL: https://public.two.example.com\n '
115-
'adminURL: https://public.two.example.com\n',
116+
'internalURL: https://internal.two.example.com\n '
117+
'adminURL: https://admin.two.example.com\n',
116118
'qwertyuiop',
117119
'supernova',
118120
'compute',

0 commit comments

Comments
 (0)