Skip to content

Commit 2caf7b1

Browse files
committed
Trivial: Do not use plural format in command parameter in "network delete"
Since "network delete" could delete more than one network, add a (s) to the doc. And also, rename the parameter "networks" to "network". The naming style is not using plural format in parameter. Change-Id: Id434ea905af34457f84ea6bcb18addef5800429a
1 parent f65f82e commit 2caf7b1

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

doc/source/command-objects/network.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Delete network(s)
6262
.. _network_delete-project:
6363
.. describe:: <network>
6464
65-
Network to delete (name or ID)
65+
Network(s) to delete (name or ID)
6666
6767
network list
6868
------------

openstackclient/network/v2/network.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,17 +119,17 @@ class DeleteNetwork(command.Command):
119119
def get_parser(self, prog_name):
120120
parser = super(DeleteNetwork, self).get_parser(prog_name)
121121
parser.add_argument(
122-
'networks',
122+
'network',
123123
metavar="<network>",
124124
nargs="+",
125-
help=("Network to delete (name or ID)")
125+
help=("Network(s) to delete (name or ID)")
126126
)
127127
return parser
128128

129129
def take_action(self, parsed_args):
130130
self.log.debug('take_action(%s)' % parsed_args)
131131
client = self.app.client_manager.network
132-
for network in parsed_args.networks:
132+
for network in parsed_args.network:
133133
obj = client.find_network(network)
134134
client.delete_network(obj)
135135
return

openstackclient/tests/network/v2/test_network.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ def test_delete(self):
284284
self._network.name,
285285
]
286286
verifylist = [
287-
('networks', [self._network.name]),
287+
('network', [self._network.name]),
288288
]
289289

290290
parsed_args = self.check_parser(self.cmd, arglist, verifylist)

0 commit comments

Comments
 (0)