Skip to content

Commit 27037a4

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Refactor TestCreateNetwork: Setup identity client in setUp() in TestCreateNetworkIdentityV2"
2 parents 08ba88d + ee68558 commit 27037a4

1 file changed

Lines changed: 18 additions & 22 deletions

File tree

openstackclient/tests/network/v2/test_network.py

Lines changed: 18 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,24 @@ def setUp(self):
194194
# Get the command object to test
195195
self.cmd = network.CreateNetwork(self.app, self.namespace)
196196

197+
# Set identity client v2. And get a shortcut to Identity client.
198+
identity_client = identity_fakes_v2.FakeIdentityv2Client(
199+
endpoint=fakes.AUTH_URL,
200+
token=fakes.AUTH_TOKEN,
201+
)
202+
self.app.client_manager.identity = identity_client
203+
self.identity = self.app.client_manager.identity
204+
205+
# Get a shortcut to the ProjectManager Mock
206+
self.projects_mock = self.identity.tenants
207+
self.projects_mock.get.return_value = fakes.FakeResource(
208+
None,
209+
copy.deepcopy(identity_fakes_v2.PROJECT),
210+
loaded=True,
211+
)
212+
213+
# There is no DomainManager Mock in fake identity v2.
214+
197215
def test_create_with_project_identityv2(self):
198216
arglist = [
199217
"--project", identity_fakes_v2.project_name,
@@ -205,17 +223,6 @@ def test_create_with_project_identityv2(self):
205223
('name', FAKE_NAME),
206224
('project', identity_fakes_v2.project_name),
207225
]
208-
identity_client = identity_fakes_v2.FakeIdentityv2Client(
209-
endpoint=fakes.AUTH_URL,
210-
token=fakes.AUTH_TOKEN,
211-
)
212-
self.app.client_manager.identity = identity_client
213-
self.projects_mock = self.app.client_manager.identity.tenants
214-
self.projects_mock.get.return_value = fakes.FakeResource(
215-
None,
216-
copy.deepcopy(identity_fakes_v2.PROJECT),
217-
loaded=True,
218-
)
219226

220227
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
221228
result = list(self.cmd.take_action(parsed_args))
@@ -242,17 +249,6 @@ def test_create_with_domain_identityv2(self):
242249
('project_domain', identity_fakes_v3.domain_name),
243250
('name', FAKE_NAME),
244251
]
245-
identity_client = identity_fakes_v2.FakeIdentityv2Client(
246-
endpoint=fakes.AUTH_URL,
247-
token=fakes.AUTH_TOKEN,
248-
)
249-
self.app.client_manager.identity = identity_client
250-
self.projects_mock = self.app.client_manager.identity.tenants
251-
self.projects_mock.get.return_value = fakes.FakeResource(
252-
None,
253-
copy.deepcopy(identity_fakes_v2.PROJECT),
254-
loaded=True,
255-
)
256252

257253
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
258254

0 commit comments

Comments
 (0)