Skip to content

Commit 21924f5

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Fix output and error log in server.py"
2 parents 6a204b0 + 97162ec commit 21924f5

1 file changed

Lines changed: 17 additions & 9 deletions

File tree

openstackclient/compute/v2/server.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ def take_action(self, parsed_args):
562562
else:
563563
self.log.error(_('Error creating server: %s'),
564564
parsed_args.server_name)
565-
sys.stdout.write(_('\nError creating server'))
565+
sys.stdout.write(_('Error creating server\n'))
566566
raise SystemExit
567567

568568
details = _prep_server_detail(compute_client, server)
@@ -646,7 +646,7 @@ def take_action(self, parsed_args):
646646
else:
647647
self.log.error(_('Error creating snapshot of server: %s'),
648648
parsed_args.server)
649-
sys.stdout.write(_('\nError creating server snapshot'))
649+
sys.stdout.write(_('Error creating server snapshot\n'))
650650
raise SystemExit
651651

652652
image = _prep_image_detail(image_client, image_id)
@@ -688,7 +688,7 @@ def take_action(self, parsed_args):
688688
else:
689689
self.log.error(_('Error deleting server: %s'),
690690
server_obj.id)
691-
sys.stdout.write(_('\nError deleting server'))
691+
sys.stdout.write(_('Error deleting server\n'))
692692
raise SystemExit
693693

694694

@@ -1013,7 +1013,9 @@ def take_action(self, parsed_args):
10131013
):
10141014
sys.stdout.write(_('Complete\n'))
10151015
else:
1016-
sys.stdout.write(_('\nError migrating server'))
1016+
self.log.error(_('Error migrating server: %s'),
1017+
server.id)
1018+
sys.stdout.write(_('Error migrating server\n'))
10171019
raise SystemExit
10181020

10191021

@@ -1085,9 +1087,11 @@ def take_action(self, parsed_args):
10851087
server.id,
10861088
callback=_show_progress,
10871089
):
1088-
sys.stdout.write(_('\nReboot complete\n'))
1090+
sys.stdout.write(_('Complete\n'))
10891091
else:
1090-
sys.stdout.write(_('\nError rebooting server\n'))
1092+
self.log.error(_('Error rebooting server: %s'),
1093+
server.id)
1094+
sys.stdout.write(_('Error rebooting server\n'))
10911095
raise SystemExit
10921096

10931097

@@ -1136,9 +1140,11 @@ def take_action(self, parsed_args):
11361140
server.id,
11371141
callback=_show_progress,
11381142
):
1139-
sys.stdout.write(_('\nComplete\n'))
1143+
sys.stdout.write(_('Complete\n'))
11401144
else:
1141-
sys.stdout.write(_('\nError rebuilding server'))
1145+
self.log.error(_('Error rebuilding server: %s'),
1146+
server.id)
1147+
sys.stdout.write(_('Error rebuilding server\n'))
11421148
raise SystemExit
11431149

11441150
details = _prep_server_detail(compute_client, server)
@@ -1290,7 +1296,9 @@ def take_action(self, parsed_args):
12901296
):
12911297
sys.stdout.write(_('Complete\n'))
12921298
else:
1293-
sys.stdout.write(_('\nError resizing server'))
1299+
self.log.error(_('Error resizing server: %s'),
1300+
server.id)
1301+
sys.stdout.write(_('Error resizing server\n'))
12941302
raise SystemExit
12951303
elif parsed_args.confirm:
12961304
compute_client.servers.confirm_resize(server)

0 commit comments

Comments
 (0)