Skip to content

Commit 211c14c

Browse files
committed
Fix shell tests
Personally, I think these tests should be removed, they are testing OCC. An internal OCC change on a private method broke this test. Change-Id: I760bf90ef8bd97e30be7838874337be695d45285
1 parent e8655f4 commit 211c14c

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

‎openstackclient/tests/test_shell.py‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ def test_empty_env(self):
559559

560560
@mock.patch("os_client_config.config.OpenStackConfig._load_config_file")
561561
def test_shell_args_cloud_no_vendor(self, config_mock):
562-
config_mock.return_value = copy.deepcopy(CLOUD_1)
562+
config_mock.return_value = ('file.yaml', copy.deepcopy(CLOUD_1))
563563
_shell = make_shell()
564564

565565
fake_execute(
@@ -596,8 +596,8 @@ def test_shell_args_cloud_no_vendor(self, config_mock):
596596
@mock.patch("os_client_config.config.OpenStackConfig._load_vendor_file")
597597
@mock.patch("os_client_config.config.OpenStackConfig._load_config_file")
598598
def test_shell_args_cloud_public(self, config_mock, public_mock):
599-
config_mock.return_value = copy.deepcopy(CLOUD_2)
600-
public_mock.return_value = copy.deepcopy(PUBLIC_1)
599+
config_mock.return_value = ('file.yaml', copy.deepcopy(CLOUD_2))
600+
public_mock.return_value = ('file.yaml', copy.deepcopy(PUBLIC_1))
601601
_shell = make_shell()
602602

603603
fake_execute(
@@ -636,8 +636,8 @@ def test_shell_args_cloud_public(self, config_mock, public_mock):
636636
@mock.patch("os_client_config.config.OpenStackConfig._load_vendor_file")
637637
@mock.patch("os_client_config.config.OpenStackConfig._load_config_file")
638638
def test_shell_args_precedence(self, config_mock, vendor_mock):
639-
config_mock.return_value = copy.deepcopy(CLOUD_2)
640-
vendor_mock.return_value = copy.deepcopy(PUBLIC_1)
639+
config_mock.return_value = ('file.yaml', copy.deepcopy(CLOUD_2))
640+
vendor_mock.return_value = ('file.yaml', copy.deepcopy(PUBLIC_1))
641641
_shell = make_shell()
642642

643643
# Test command option overriding config file value
@@ -690,8 +690,8 @@ def tearDown(self):
690690
@mock.patch("os_client_config.config.OpenStackConfig._load_vendor_file")
691691
@mock.patch("os_client_config.config.OpenStackConfig._load_config_file")
692692
def test_shell_args_precedence_1(self, config_mock, vendor_mock):
693-
config_mock.return_value = copy.deepcopy(CLOUD_2)
694-
vendor_mock.return_value = copy.deepcopy(PUBLIC_1)
693+
config_mock.return_value = ('file.yaml', copy.deepcopy(CLOUD_2))
694+
vendor_mock.return_value = ('file.yaml', copy.deepcopy(PUBLIC_1))
695695
_shell = make_shell()
696696

697697
# Test env var
@@ -731,8 +731,8 @@ def test_shell_args_precedence_1(self, config_mock, vendor_mock):
731731
@mock.patch("os_client_config.config.OpenStackConfig._load_vendor_file")
732732
@mock.patch("os_client_config.config.OpenStackConfig._load_config_file")
733733
def test_shell_args_precedence_2(self, config_mock, vendor_mock):
734-
config_mock.return_value = copy.deepcopy(CLOUD_2)
735-
vendor_mock.return_value = copy.deepcopy(PUBLIC_1)
734+
config_mock.return_value = ('file.yaml', copy.deepcopy(CLOUD_2))
735+
vendor_mock.return_value = ('file.yaml', copy.deepcopy(PUBLIC_1))
736736
_shell = make_shell()
737737

738738
# Test command option overriding config file value

0 commit comments

Comments
 (0)