Skip to content

Commit 114eeeb

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Fix volume functional tests"
2 parents e272473 + 09b783a commit 114eeeb

8 files changed

Lines changed: 40 additions & 13 deletions

File tree

functional/tests/volume/v1/test_qos.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from functional.tests.volume.v1 import common
1616

1717

18-
class VolumeTests(common.BaseVolumeTests):
18+
class QosTests(common.BaseVolumeTests):
1919
"""Functional tests for volume qos. """
2020

2121
NAME = uuid.uuid4().hex
@@ -25,6 +25,7 @@ class VolumeTests(common.BaseVolumeTests):
2525

2626
@classmethod
2727
def setUpClass(cls):
28+
super(QosTests, cls).setUpClass()
2829
opts = cls.get_show_opts(cls.FIELDS)
2930
raw_output = cls.openstack('volume qos create ' + cls.NAME + opts)
3031
cls.ID, name, rol = raw_output.split('\n')

functional/tests/volume/v1/test_volume.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
# License for the specific language governing permissions and limitations
1111
# under the License.
1212

13-
import os
1413
import uuid
1514

1615
from functional.tests.volume.v1 import common
@@ -26,7 +25,7 @@ class VolumeTests(common.BaseVolumeTests):
2625

2726
@classmethod
2827
def setUpClass(cls):
29-
os.environ['OS_VOLUME_API_VERSION'] = '1'
28+
super(VolumeTests, cls).setUpClass()
3029
opts = cls.get_show_opts(cls.FIELDS)
3130
raw_output = cls.openstack('volume create --size 1 ' + cls.NAME + opts)
3231
expected = cls.NAME + '\n'

functional/tests/volume/v1/test_volume_type.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ class VolumeTypeTests(common.BaseVolumeTests):
2424

2525
@classmethod
2626
def setUpClass(cls):
27+
super(VolumeTypeTests, cls).setUpClass()
2728
opts = cls.get_show_opts(cls.FIELDS)
2829
raw_output = cls.openstack('volume type create ' + cls.NAME + opts)
2930
expected = cls.NAME + '\n'
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# Licensed under the Apache License, Version 2.0 (the "License"); you may
2+
# not use this file except in compliance with the License. You may obtain
3+
# a copy of the License at
4+
#
5+
# http://www.apache.org/licenses/LICENSE-2.0
6+
#
7+
# Unless required by applicable law or agreed to in writing, software
8+
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
9+
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
10+
# License for the specific language governing permissions and limitations
11+
# under the License.
12+
13+
import os
14+
15+
from functional.common import test
16+
17+
18+
class BaseVolumeTests(test.TestCase):
19+
"""Base class for Volume functional tests. """
20+
21+
@classmethod
22+
def setUpClass(cls):
23+
os.environ['OS_VOLUME_API_VERSION'] = '2'

functional/tests/volume/v2/test_qos.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212

1313
import uuid
1414

15-
from functional.common import test
15+
from functional.tests.volume.v2 import common
1616

1717

18-
class VolumeTests(test.TestCase):
18+
class QosTests(common.BaseVolumeTests):
1919
"""Functional tests for volume qos. """
2020

2121
NAME = uuid.uuid4().hex
@@ -25,6 +25,7 @@ class VolumeTests(test.TestCase):
2525

2626
@classmethod
2727
def setUpClass(cls):
28+
super(QosTests, cls).setUpClass()
2829
opts = cls.get_show_opts(cls.FIELDS)
2930
raw_output = cls.openstack('volume qos create ' + cls.NAME + opts)
3031
cls.ID, name, rol = raw_output.split('\n')

functional/tests/volume/v1/test_snapshot.py renamed to functional/tests/volume/v2/test_snapshot.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313
import time
1414
import uuid
1515

16-
from functional.common import test
16+
from functional.tests.volume.v2 import common
1717

1818

19-
class SnapshotTests(test.TestCase):
19+
class SnapshotTests(common.BaseVolumeTests):
2020
"""Functional tests for snapshot. """
2121

2222
VOLLY = uuid.uuid4().hex
@@ -36,6 +36,7 @@ def wait_for_status(cls, command, status, tries):
3636

3737
@classmethod
3838
def setUpClass(cls):
39+
super(SnapshotTests, cls).setUpClass()
3940
cls.openstack('volume create --size 1 ' + cls.VOLLY)
4041
cls.wait_for_status('volume show ' + cls.VOLLY, 'available\n', 3)
4142
opts = cls.get_show_opts(['status'])

functional/tests/volume/v2/test_volume.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,13 @@
1010
# License for the specific language governing permissions and limitations
1111
# under the License.
1212

13-
import os
1413
import time
1514
import uuid
1615

17-
from functional.common import test
16+
from functional.tests.volume.v2 import common
1817

1918

20-
class VolumeTests(test.TestCase):
19+
class VolumeTests(common.BaseVolumeTests):
2120
"""Functional tests for volume. """
2221

2322
NAME = uuid.uuid4().hex
@@ -29,7 +28,7 @@ class VolumeTests(test.TestCase):
2928

3029
@classmethod
3130
def setUpClass(cls):
32-
os.environ['OS_VOLUME_API_VERSION'] = '2'
31+
super(VolumeTests, cls).setUpClass()
3332
opts = cls.get_show_opts(cls.FIELDS)
3433

3534
# Create test volume
@@ -111,6 +110,7 @@ def test_volume_snapshot(self):
111110
# Delete test snapshot
112111
raw_output = self.openstack('snapshot delete ' + self.SNAPSHOT_NAME)
113112
self.assertOutput('', raw_output)
113+
self.wait_for("volume", self.NAME, "available")
114114

115115
def wait_for(self, check_type, check_name, desired_status, wait=120,
116116
interval=5, failures=['ERROR']):

functional/tests/volume/v2/test_volume_type.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212

1313
import uuid
1414

15-
from functional.common import test
15+
from functional.tests.volume.v2 import common
1616

1717

18-
class VolumeTypeTests(test.TestCase):
18+
class VolumeTypeTests(common.BaseVolumeTests):
1919
"""Functional tests for volume type. """
2020

2121
NAME = uuid.uuid4().hex
@@ -24,6 +24,7 @@ class VolumeTypeTests(test.TestCase):
2424

2525
@classmethod
2626
def setUpClass(cls):
27+
super(VolumeTypeTests, cls).setUpClass()
2728
opts = cls.get_show_opts(cls.FIELDS)
2829
raw_output = cls.openstack(
2930
'volume type create --private ' + cls.NAME + opts)

0 commit comments

Comments
 (0)