From 4a0eb94aae25acc249a2dc37071e84d92890a2ef Mon Sep 17 00:00:00 2001 From: Sushant2504m Date: Mon, 21 Sep 2026 12:18:26 +0530 Subject: [PATCH] feat: Remove monitoring command and fix command casing in README MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit addresses code review feedback by completely removing the monitoring command instead of just deprecating it, as it no longer supports active OpenShift ROSA versions. Changes: - Remove cmd/ocm-backplane/monitoring/ directory and command - Remove pkg/monitoring/ package entirely - Remove monitoring command registration from root.go - Remove monitoring command from README usage table - Remove "Monitoring" documentation section from README - Fix command casing in README: managedJob → managedjob, testJob → testjob - Remove non-existent managedjob list command from README Rationale: Following OpenShift 4.11+, monitoring stack UIs (Prometheus, AlertManager, Grafana) are deprecated in favor of the console's Observe tab. Since the monitoring command doesn't support active ROSA versions, complete removal is cleaner than deprecation warnings. Users should use: ocm backplane console → Observe tab Addresses feedback from: @samanthajayasinghe, @coderabbitai Co-Authored-By: Claude Sonnet 4.5 --- README.md | 28 +- cmd/ocm-backplane/monitoring/monitoring.go | 75 ---- cmd/ocm-backplane/root.go | 2 - pkg/monitoring/monitoring.go | 384 --------------------- pkg/monitoring/monitoring_suite_test.go | 20 -- pkg/monitoring/monitoring_test.go | 230 ------------ 6 files changed, 8 insertions(+), 731 deletions(-) delete mode 100644 cmd/ocm-backplane/monitoring/monitoring.go delete mode 100644 pkg/monitoring/monitoring.go delete mode 100644 pkg/monitoring/monitoring_suite_test.go delete mode 100644 pkg/monitoring/monitoring_test.go diff --git a/README.md b/README.md index dd08933e..2572b145 100644 --- a/README.md +++ b/README.md @@ -80,20 +80,18 @@ To setup the PS1(prompt) for bash/zsh, please follow [these instructions](https: | `ocm backplane cloud credentials [flags]` | Retrieve a set of temporary cloud credentials for the cluster's cloud provider | | `ocm backplane cloud ssm --node ` | Start an aws ssm session for an HCP cluster | | `ocm backplane elevate -- ` | Elevate privileges to backplane-cluster-admin and add a reason to the api request, this reason will be stored for 20min for future usage | -| `ocm backplane monitoring [flags]` | Launch the specified monitoring UI (Deprecated following v4.11 for cluster monitoring stack)| | `ocm backplane script describe