Skip to content

Commit 2ade9da

Browse files
committed
Turn off three of Picnic's suggestions
- LexicographicalAnnotationAttributeListing would sort the values in an annotation's arrays: {false, true} for {true, false} in a dozen @valuesource tests, and a @CsvSource's rows out of the order they are grouped in. - StringJoining would turn String.format("%s:%s", lower, higher) into String.join(":", String.valueOf(lower), String.valueOf(higher)). - IsInstanceLambdaUsage would turn doc -> doc instanceof Level into Level.class::isInstance.
1 parent 149bab2 commit 2ade9da

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

‎buildSrc/src/main/groovy/open-java-format.error-prone-conventions.gradle‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@ tasks.withType(JavaCompile).configureEach {
3131
error('RefactorSwitch')
3232
error('SameNameButDifferent')
3333
error('UnusedVariable')
34+
disable('IsInstanceLambdaUsage')
35+
disable('LexicographicalAnnotationAttributeListing')
3436
disable('LexicographicalAnnotationListing')
37+
disable('StringJoining')
3538
}
3639
}
3740

0 commit comments

Comments
 (0)