Skip to content

Commit 1d03bf9

Browse files
committed
Turn off LexicographicalAnnotationListing
Picnic's check asks for annotations in alphabetical order, and gave 25 suggestions that would move @OverRide and @test below the rest. The annotation that says what a member is stays first, as most of the code has it. JavaCommentsHelperTest's @test is above its @SuppressWarnings again.
1 parent 955f679 commit 1d03bf9

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

‎buildSrc/src/main/groovy/open-java-format.error-prone-conventions.gradle‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ tasks.withType(JavaCompile).configureEach {
2727
error('RefactorSwitch')
2828
error('SameNameButDifferent')
2929
error('UnusedVariable')
30+
disable('LexicographicalAnnotationListing')
3031
}
3132
}
3233

‎open-java-format/src/test/java/com/palantir/javaformat/java/JavaCommentsHelperTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ void anUnbreakableTokenIsLeftLong() throws Exception {
9696
assertThat(rewritten).contains("/// " + url);
9797
}
9898

99-
@SuppressWarnings("FormatStringConcatenation") // Written out like the input, not as a template
10099
@Test
100+
@SuppressWarnings("FormatStringConcatenation") // Written out like the input, not as a template
101101
void theMissingSpaceRuleAppliesToEveryLineOfTheRun() throws Exception {
102102
// Otherwise the same source formats differently depending on whether the running JDK hands the run
103103
// over as one tok (23 and later) or as one tok per line.

0 commit comments

Comments
 (0)