From 8d3005c7a974d7d58d379e83be63286e361d3fb6 Mon Sep 17 00:00:00 2001 From: Andreas Trawoeger Date: Fri, 16 Oct 2026 18:05:13 +0200 Subject: [PATCH] fix(docs): sweep the retired `engine.build` out of the corpus, leaving only the page that says it is gone `engine.build` was removed from the contract by the BuildKit cutover (#481): the image builder is BuildKit, which is not a container engine, so it cannot be selected like one. Four pages still conditioned behaviour on it. Three described image transfer "when `engine.build` differs from `engine.run`" (shell.md) or "when `engine.build=docker`" (service.md, deploy.md). The transfer itself is real and still happens - the trigger was the stale part - so the condition moves to `engine.run`, which the build recipe already states is unaffected and still selectable. charly-doctor.md listed the key among the settings `charly-config` owns, and it no longer owns it. Acceptance, the claim-keyed grep R5 requires: $ grep -rn "engine.build" src/content/docs recipes/build/build.md:448:**There is no `engine.build`**: the image builder is BuildKit ... The one remaining occurrence is the page that already states the key is gone. Agent: charly-dsh Assisted-by: DSH DeepSeek deepseek-v4.1-flash (documentation reviewed) --- src/content/docs/recipes/core/charly-doctor.md | 2 +- src/content/docs/recipes/core/deploy.md | 2 +- src/content/docs/recipes/core/service.md | 2 +- src/content/docs/recipes/core/shell.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/content/docs/recipes/core/charly-doctor.md b/src/content/docs/recipes/core/charly-doctor.md index 3a0eff25..f9cf92fb 100644 --- a/src/content/docs/recipes/core/charly-doctor.md +++ b/src/content/docs/recipes/core/charly-doctor.md @@ -130,7 +130,7 @@ Each check shows the binary path and version when available, or an install hint ## Cross-References - [`/charly-automation:udev`](/recipes/automation/udev/) — install udev rules for GPU device access -- [`/charly-core:charly-config`](/recipes/core/charly-config/) — `engine.build`, `engine.run`, `secret_backend` settings, `--no-auto-detect` flag, DRINODE injection via `appendAutoDetectedEnv()` +- [`/charly-core:charly-config`](/recipes/core/charly-config/) — `engine.run`, `secret_backend` settings, `--no-auto-detect` flag, DRINODE injection via `appendAutoDetectedEnv()` - [`/charly-automation:enc`](/recipes/automation/enc/) — credential lookup path behind the Secret Service collection + keyring-index checks; iteration-capable ssClient; broken-collection troubleshooting - [`/charly-build:secrets`](/recipes/build/secrets/) — `charly secrets set/list/prune` commands referenced by the keyring-index remediation hint - [`/charly-build:settings`](/recipes/build/settings/) — `keyring_collection_label`, `secret_backend`, and other runtime config keys surfaced by the Secret Storage checks diff --git a/src/content/docs/recipes/core/deploy.md b/src/content/docs/recipes/core/deploy.md index e73004b0..c8a65886 100644 --- a/src/content/docs/recipes/core/deploy.md +++ b/src/content/docs/recipes/core/deploy.md @@ -471,7 +471,7 @@ Source: `sdk/deploykit/security.go`, `sdk/deploykit/quadlet.go`. ### Image Transfer -When `engine.build=docker`, `charly config` auto-detects if the image is missing from podman and transfers via `docker save | podman load`. `charly update` re-transfers if needed. +When `engine.run=docker`, `charly config` auto-detects if the image is missing from podman and transfers via `docker save | podman load`. `charly update` re-transfers if needed. Source: `sdk/deploykit/quadlet.go` + `sdk/deploykit/quadlet_pod.go` (generation), `charly/commands.go` (command structs). diff --git a/src/content/docs/recipes/core/service.md b/src/content/docs/recipes/core/service.md index d1991f56..bb66064f 100644 --- a/src/content/docs/recipes/core/service.md +++ b/src/content/docs/recipes/core/service.md @@ -137,7 +137,7 @@ Source: `sdk/deploykit/security.go`, `sdk/deploykit/quadlet.go`. ### Image Transfer -When `engine.build=docker`, `charly config` auto-detects if the image is missing from podman and transfers via `docker save | podman load`. `charly update` re-transfers if needed. +When `engine.run=docker`, `charly config` auto-detects if the image is missing from podman and transfers via `docker save | podman load`. `charly update` re-transfers if needed. ## Direct Mode (Fallback) diff --git a/src/content/docs/recipes/core/shell.md b/src/content/docs/recipes/core/shell.md index 3dbf82e8..2ec19e7f 100644 --- a/src/content/docs/recipes/core/shell.md +++ b/src/content/docs/recipes/core/shell.md @@ -165,7 +165,7 @@ workflow. ## Cross-Engine Image Transfer -When `engine.build` differs from `engine.run`, images are automatically transferred between engines on demand via ` save | load`. +When a build and a run name different engines, images are automatically transferred between them on demand via ` save | load`. Source: `dispatchBuildEnsure` (`charly/dispatch_build_ensure.go`) dispatches to candy/plugin-build's `build:ensure` word (`candy/plugin-build/ensure.go`), which calls `kit.TransferImage` (`sdk/kit/transfer.go`, re-exporting `spec/container/transfer.go`). `charly/transfer.go`, this doc's former source citation, no longer exists.