From b0884c5246840cb060655ad3a9f3a4b03c5c04bc Mon Sep 17 00:00:00 2001 From: Rajkaran Yadav Date: Thu, 3 Sep 2026 02:37:26 +0530 Subject: [PATCH 1/2] test: assert rejected execution exception type in OkHttp sender tests --- .../exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java | 3 +++ .../exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java | 3 +++ 2 files changed, 6 insertions(+) diff --git a/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java b/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java index b5b99877cb2..6cf987ba1ca 100644 --- a/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java +++ b/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java @@ -88,6 +88,9 @@ void send_rejectedExecution_callsOnError() { sender.send(new TestMessageWriter(), responseRef::set, errorRef::set); assertThat(errorRef.get()).isNotNull(); + // OkHttp wraps RejectedExecutionException in InterruptedIOException with message "executor + // rejected" + assertThat(errorRef.get()).hasMessageContaining("executor rejected"); assertThat(responseRef.get()).isNull(); } diff --git a/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java b/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java index 251b85ca63a..55394b49dad 100644 --- a/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java +++ b/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java @@ -75,6 +75,9 @@ void send_rejectedExecution_callsOnError() { sender.send(new NoOpRequestBodyWriter(), responseRef::set, errorRef::set); assertThat(errorRef.get()).isNotNull(); + // OkHttp wraps RejectedExecutionException in InterruptedIOException with message "executor + // rejected" + assertThat(errorRef.get()).hasMessageContaining("executor rejected"); assertThat(responseRef.get()).isNull(); } From 080584e4a74d4ac686aebba24c8724f5cd721700 Mon Sep 17 00:00:00 2001 From: Rajkaran Yadav Date: Thu, 3 Sep 2026 03:23:39 +0530 Subject: [PATCH 2/2] test: remove unnecessary comments from OkHttp sender tests --- .../exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java | 2 -- .../exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java | 2 -- 2 files changed, 4 deletions(-) diff --git a/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java b/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java index 6cf987ba1ca..63a69ffabe4 100644 --- a/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java +++ b/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSenderTest.java @@ -88,8 +88,6 @@ void send_rejectedExecution_callsOnError() { sender.send(new TestMessageWriter(), responseRef::set, errorRef::set); assertThat(errorRef.get()).isNotNull(); - // OkHttp wraps RejectedExecutionException in InterruptedIOException with message "executor - // rejected" assertThat(errorRef.get()).hasMessageContaining("executor rejected"); assertThat(responseRef.get()).isNull(); } diff --git a/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java b/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java index 55394b49dad..994e9a99985 100644 --- a/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java +++ b/exporters/sender/okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSenderTest.java @@ -75,8 +75,6 @@ void send_rejectedExecution_callsOnError() { sender.send(new NoOpRequestBodyWriter(), responseRef::set, errorRef::set); assertThat(errorRef.get()).isNotNull(); - // OkHttp wraps RejectedExecutionException in InterruptedIOException with message "executor - // rejected" assertThat(errorRef.get()).hasMessageContaining("executor rejected"); assertThat(responseRef.get()).isNull(); }