From fabb098dfd97a4c2deb57da19c5a62d664122cd5 Mon Sep 17 00:00:00 2001 From: Eunbin Son Date: Thu, 27 Aug 2026 22:18:39 +0900 Subject: [PATCH] Fix inverted scope_info_enabled and target_info_enabled declarative config flags --- .../internal/PrometheusComponentProvider.java | 12 ++++++------ .../declarativeconfig/MetricReaderFactoryTest.java | 2 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/internal/PrometheusComponentProvider.java b/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/internal/PrometheusComponentProvider.java index bc25a34107f..475f90e246d 100644 --- a/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/internal/PrometheusComponentProvider.java +++ b/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/internal/PrometheusComponentProvider.java @@ -47,13 +47,13 @@ public MetricReader create(DeclarativeConfigProperties config) { prometheusBuilder.setHost(host); } - Boolean withoutTargetInfo = config.getBoolean("target_info_enabled/development"); - if (withoutTargetInfo != null) { - prometheusBuilder.setTargetInfoMetricEnabled(!withoutTargetInfo); + Boolean targetInfoEnabled = config.getBoolean("target_info_enabled/development"); + if (targetInfoEnabled != null) { + prometheusBuilder.setTargetInfoMetricEnabled(targetInfoEnabled); } - Boolean withoutScopeInfo = config.getBoolean("scope_info_enabled"); - if (withoutScopeInfo != null) { - prometheusBuilder.setOtelScopeLabelsEnabled(!withoutScopeInfo); + Boolean scopeInfoEnabled = config.getBoolean("scope_info_enabled"); + if (scopeInfoEnabled != null) { + prometheusBuilder.setOtelScopeLabelsEnabled(scopeInfoEnabled); } String translationStrategy = config.getString("translation_strategy"); if (translationStrategy != null) { diff --git a/sdk-extensions/declarative-config/src/test/java/io/opentelemetry/sdk/autoconfigure/declarativeconfig/MetricReaderFactoryTest.java b/sdk-extensions/declarative-config/src/test/java/io/opentelemetry/sdk/autoconfigure/declarativeconfig/MetricReaderFactoryTest.java index 144942f53ad..9a09fc7b7e4 100644 --- a/sdk-extensions/declarative-config/src/test/java/io/opentelemetry/sdk/autoconfigure/declarativeconfig/MetricReaderFactoryTest.java +++ b/sdk-extensions/declarative-config/src/test/java/io/opentelemetry/sdk/autoconfigure/declarativeconfig/MetricReaderFactoryTest.java @@ -163,6 +163,8 @@ static Stream createTestCases() throws IOException { PrometheusHttpServer.builder() .setHost("localhost") .setPort(prom2Port) + .setOtelScopeLabelsEnabled(false) + .setTargetInfoMetricEnabled(false) .setTranslationStrategy(TranslationStrategy.UNDERSCORE_ESCAPING_WITHOUT_SUFFIXES) .setAllowedResourceAttributesFilter( IncludeExcludePredicate.createPatternMatching(