From 7c304ae7f37abadd6cd6bbef82e11dd6c80a7a6e Mon Sep 17 00:00:00 2001 From: Andre Brait Date: Wed, 18 Nov 2026 00:17:32 +0000 Subject: [PATCH] ci: bound the coordinated upgrade e2e step and keep its log Twice on windows-latest the step ran until the 60-minute job limit and GitHub kept no log. Give it 25 minutes, write the suite output to a file (a detached process holding the step pipe keeps a Windows step open) and upload it when the step fails. --- .github/workflows/verify-pr.yml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verify-pr.yml b/.github/workflows/verify-pr.yml index 168ac2c75..c10290ace 100644 --- a/.github/workflows/verify-pr.yml +++ b/.github/workflows/verify-pr.yml @@ -124,11 +124,27 @@ jobs: # Required on every supported runner, including macOS foreground. A skip fails the job. - name: Native compiled coordinated upgrade and rollback shell: bash + # The suite bounds each test at 15 min; a stall past that (seen twice on windows-latest, killed at the 60 min job + # limit with no log) must fail here with its output kept. + timeout-minutes: 25 env: OMPWEB_COMPILED_UPGRADE_E2E: "1" run: | export OMPWEB_UPGRADE_E2E_RUNNER="$(node -p "require('node:path').resolve('runner', 'release', 'ompweb-omp-' + (process.platform === 'win32' ? 'windows' : process.platform) + '-' + process.arch + (process.platform === 'win32' ? '.exe' : ''))")" - npx bun test --parallel --timeout 900000 lib/compiled-upgrade.integration.test.mjs + # Output goes to a file, not the step's pipe: a detached process that inherits the pipe keeps a Windows step open. + log="$RUNNER_TEMP/compiled-upgrade.log" + status=0 + npx bun test --parallel --timeout 900000 lib/compiled-upgrade.integration.test.mjs > "$log" 2>&1 < /dev/null || status=$? + cat "$log" + exit "$status" + + - name: Upload the coordinated upgrade log + if: ${{ !cancelled() && failure() }} + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 + with: + name: compiled-upgrade-${{ matrix.os }} + path: ${{ runner.temp }}/compiled-upgrade.log + if-no-files-found: ignore - name: Packed install smoke test shell: bash