From 9e80d6521a505f857630459e90cb7c52364948e6 Mon Sep 17 00:00:00 2001 From: Sumit Kumar Das <151006536+skdas20@users.noreply.github.com> Date: Thu, 27 Aug 2026 15:33:43 +0000 Subject: [PATCH 1/2] doc: clarify ICU source layout for configure Signed-off-by: skdas20 --- BUILDING.md | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index a7b91fc40ee5..403deefb92c7 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -978,8 +978,8 @@ that works for both your host and target environments. You can find other ICU releases at [the ICU homepage](https://icu.unicode.org/download). -Download the file named something like `icu4c-**##.#**-src.tgz` (or -`.zip`). +Download the source archive named something like +`icu4c-**##.#**-sources.tgz` (or `.zip`). To check the minimum recommended ICU, run `./configure --help` and see the help for the `--with-icu-source` option. A warning will be printed @@ -987,12 +987,17 @@ during configuration if the ICU version is too old. #### Unix/macOS -From an already-unpacked ICU: +From an already-unpacked ICU source archive: ```bash ./configure --with-intl=[small-icu,full-icu] --with-icu-source=/path/to/icu ``` +The directory passed to `--with-icu-source` must contain the extracted ICU +source layout (for example, `source/data/in/icudt*l.dat`). A plain Git checkout +of the ICU repository is not sufficient unless it has been prepared to match +this layout. + From a local ICU tarball: ```bash From f47d9df7a398433bf2ccdf23bc6269bec5c54a50 Mon Sep 17 00:00:00 2001 From: Sumit Kumar Das <151006536+skdas20@users.noreply.github.com> Date: Thu, 27 Aug 2026 15:33:44 +0000 Subject: [PATCH 2/2] doc: apply review feedback on ICU source archive wording Use the reviewer's wording for the note about cloning icu4c, and update the archive name in the Windows section to match. Signed-off-by: skdas20 --- BUILDING.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 403deefb92c7..0062c5da4a59 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -993,10 +993,8 @@ From an already-unpacked ICU source archive: ./configure --with-intl=[small-icu,full-icu] --with-icu-source=/path/to/icu ``` -The directory passed to `--with-icu-source` must contain the extracted ICU -source layout (for example, `source/data/in/icudt*l.dat`). A plain Git checkout -of the ICU repository is not sufficient unless it has been prepared to match -this layout. +(Simply cloning the icu4c repository will not work here; the source directory +must have been unpacked from the compiled `-sources` archive.) From a local ICU tarball: @@ -1013,7 +1011,7 @@ From a tarball URL: #### Windows First unpack latest ICU to `deps/icu` -[icu4c-**##.#**-src.tgz](https://icu.unicode.org/download) (or `.zip`) +[icu4c-**##.#**-sources.tgz](https://icu.unicode.org/download) (or `.zip`) as `deps/icu` (You'll have: `deps/icu/source/...`) ```powershell