From 3db14753ce205b5697f6a555792aafc5b4ad97c2 Mon Sep 17 00:00:00 2001 From: Ahalya Radhakrishnan Date: Thu, 19 Nov 2026 12:56:32 +0530 Subject: [PATCH] test(spec): cover default condition and measurement mapping formats Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- tests/spec/test_spec_dataframe_utilitites.py | 45 ++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/tests/spec/test_spec_dataframe_utilitites.py b/tests/spec/test_spec_dataframe_utilitites.py index 9955cd0e..4e102c2a 100644 --- a/tests/spec/test_spec_dataframe_utilitites.py +++ b/tests/spec/test_spec_dataframe_utilitites.py @@ -314,6 +314,28 @@ def test__convert_specs_to_dataframe_without_condition_values__returns_specs_dat assert not specs_df.empty pd.testing.assert_frame_equal(specs_df, expected_specs_df, check_dtype=True) + def test__convert_specs_to_dataframe_without_condition_format__returns_condition_per_column( + self, + ): + condition_value = StringConditionValue( + condition_type=ConditionType.STRING, discrete=["D", "QFIN"] + ) + specs = [ + Specification( + spec_id="S1", + conditions=[Condition(name="Package", value=condition_value)], + ) + ] + expected_specs_df = self.__expected_specs_dataframe( + specs=specs, + conditions_dict=[[{"condition_Package": condition_value}]], + ) + + specs_df = convert_specs_to_dataframe(specs=specs) + + assert len(specs_df) == 1 + pd.testing.assert_frame_equal(specs_df, expected_specs_df, check_dtype=True) + @pytest.mark.parametrize( "measurement_mapping_format, expected_spec_ids, expected_columns", [ @@ -385,6 +407,29 @@ def test__convert_specs_to_dataframe_with_measurement_mapping_format__returns_ex pd.testing.assert_frame_equal(specs_df, expected_df, check_dtype=True) + def test__convert_specs_to_dataframe_without_measurement_mapping_format__returns_measurement_mapping_per_column( + self, + ): + specs = [ + Specification( + spec_id="S1", + measurement_mapping=[ + MeasurementMappingItem(filter="F1", result_filter="R1") + ], + ) + ] + + specs_df = convert_specs_to_dataframe(specs=specs) + + expected_df = pd.DataFrame( + { + "spec_id": ["S1"], + "measurement_mapping[0].filter": ["F1"], + "measurement_mapping[0].result_filter": ["R1"], + } + ) + pd.testing.assert_frame_equal(specs_df, expected_df, check_dtype=True) + def test__convert_specs_to_dataframe_with_condition_per_column__returns_dataframe_with_condition_per_column( self, specs ):