From 70fc4df76bc4b87a319dd929730d62fa5ae4d2b0 Mon Sep 17 00:00:00 2001 From: Utkarsh patwa Date: Sun, 15 Nov 2026 22:22:33 +0530 Subject: [PATCH 1/2] fix(interactive): read input files asynchronously in processRequests Use fs.promises.readFile instead of synchronous fs.readFileSync so that the Node.js event loop is not blocked during file input reading, allowing concurrent timers, sockets, and promises to progress. Fixes #530 Signed-off-by: Utkarsh patwa --- typescript/src/interactive/interactive.ts | 3 ++- typescript/test/interactive.test.ts | 24 +++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/typescript/src/interactive/interactive.ts b/typescript/src/interactive/interactive.ts index dec77565..8f1be91f 100644 --- a/typescript/src/interactive/interactive.ts +++ b/typescript/src/interactive/interactive.ts @@ -11,7 +11,8 @@ import readline from "readline/promises"; */ export async function processRequests(interactivePrompt: string, inputFileName: string | undefined, processRequest: (request: string) => Promise) { if (inputFileName) { - const lines = fs.readFileSync(inputFileName).toString().split(/\r?\n/); + const content = await fs.promises.readFile(inputFileName, "utf-8"); + const lines = content.split(/\r?\n/); for (const line of lines) { if (line.length && line !== "#" && !line.startsWith("# ")) { console.log(interactivePrompt + line); diff --git a/typescript/test/interactive.test.ts b/typescript/test/interactive.test.ts index 8c4cf4de..02a7926b 100644 --- a/typescript/test/interactive.test.ts +++ b/typescript/test/interactive.test.ts @@ -58,4 +58,28 @@ describe("processRequests with an input file", () => { const { requests } = await run("# a comment\r\nfirst request\r\nsecond request\r\n"); assert.deepEqual(requests, ["first request", "second request"]); }); + + it("reads input files asynchronously without blocking the event loop", async () => { + const dir = fs.mkdtempSync(path.join(os.tmpdir(), "typechat-interactive-")); + const inputFile = path.join(dir, "input.txt"); + fs.writeFileSync(inputFile, "async request\n"); + + let timerFired = false; + const timer = setTimeout(() => { + timerFired = true; + }, 0); + + const requests: string[] = []; + try { + await processRequests("> ", inputFile, async request => { + requests.push(request); + }); + assert.equal(timerFired, true, "Event loop should not be blocked during file read"); + assert.deepEqual(requests, ["async request"]); + } + finally { + clearTimeout(timer); + fs.rmSync(dir, { recursive: true, force: true }); + } + }); }); From 8ee20484ea94910f8c5ba39ca8a962e746c27f66 Mon Sep 17 00:00:00 2001 From: Utkarsh patwa Date: Mon, 16 Nov 2026 21:24:49 +0530 Subject: [PATCH 2/2] test(interactive): replace timer race with deterministic yield assertion Signed-off-by: Utkarsh patwa --- typescript/test/interactive.test.ts | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/typescript/test/interactive.test.ts b/typescript/test/interactive.test.ts index 02a7926b..77382ab2 100644 --- a/typescript/test/interactive.test.ts +++ b/typescript/test/interactive.test.ts @@ -64,21 +64,16 @@ describe("processRequests with an input file", () => { const inputFile = path.join(dir, "input.txt"); fs.writeFileSync(inputFile, "async request\n"); - let timerFired = false; - const timer = setTimeout(() => { - timerFired = true; - }, 0); - const requests: string[] = []; try { - await processRequests("> ", inputFile, async request => { + const promise = processRequests("> ", inputFile, async request => { requests.push(request); }); - assert.equal(timerFired, true, "Event loop should not be blocked during file read"); + assert.equal(requests.length, 0, "No requests should be dispatched before processRequests yields"); + await promise; assert.deepEqual(requests, ["async request"]); } finally { - clearTimeout(timer); fs.rmSync(dir, { recursive: true, force: true }); } });