From 09b6cf457dc3cac32c31af87f72d66e0d1f05602 Mon Sep 17 00:00:00 2001 From: Prangshuman Das Date: Mon, 12 Oct 2026 11:54:17 +0200 Subject: [PATCH] Ignore localized fields in API document comparisons Skip localized header fields that only exist in some countries when comparing page and API documents and re-enable the through-page-and-API tests. AB#646383 AB#653393 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91 --- .../src/APIV1SalesCreditMemosE2E.Codeunit.al | 2 ++ .../test/src/APIV1SalesOrdersE2E.Codeunit.al | 2 ++ .../test/src/APIV1SalesQuotesE2E.Codeunit.al | 5 ++++ .../test/src/SalesInvoicesE2E.Codeunit.al | 3 ++ .../test/src/APIV2PurchCrMemosE2E.Codeunit.al | 2 ++ .../src/APIV2PurchaseOrdersE2E.Codeunit.al | 8 +++-- .../src/APIV2SalesCreditMemosE2E.Codeunit.al | 2 ++ .../src/APIV2SalesInvoicesE2E.Codeunit.al | 3 ++ .../test/src/APIV2SalesOrdersE2E.Codeunit.al | 2 ++ .../test/src/APIV2SalesQuotesE2E.Codeunit.al | 5 ++++ .../_Exclude_APIV1__Tests.DisabledTest.json | 20 ------------- .../_Exclude_APIV2__Tests.DisabledTest.json | 30 ------------------- 12 files changed, 31 insertions(+), 53 deletions(-) diff --git a/src/Apps/W1/APIV1/test/src/APIV1SalesCreditMemosE2E.Codeunit.al b/src/Apps/W1/APIV1/test/src/APIV1SalesCreditMemosE2E.Codeunit.al index 4f2323b2746..a9d43fd5630 100644 --- a/src/Apps/W1/APIV1/test/src/APIV1SalesCreditMemosE2E.Codeunit.al +++ b/src/Apps/W1/APIV1/test/src/APIV1SalesCreditMemosE2E.Codeunit.al @@ -1014,6 +1014,8 @@ codeunit 139728 "APIV1 - Sales Credit Memos E2E" SalesHeader1RecordRef.GETTABLE(SalesHeader1); SalesHeader2RecordRef.GETTABLE(SalesHeader2); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, DATABASE::"Sales Header", 'Operation Occurred Date'); Assert.RecordsAreEqualExceptCertainFields( SalesHeader1RecordRef, SalesHeader2RecordRef, TempIgnoredFieldsForComparison, 'Credit Memos do not match'); diff --git a/src/Apps/W1/APIV1/test/src/APIV1SalesOrdersE2E.Codeunit.al b/src/Apps/W1/APIV1/test/src/APIV1SalesOrdersE2E.Codeunit.al index 434d52427f1..f2681bece77 100644 --- a/src/Apps/W1/APIV1/test/src/APIV1SalesOrdersE2E.Codeunit.al +++ b/src/Apps/W1/APIV1/test/src/APIV1SalesOrdersE2E.Codeunit.al @@ -406,6 +406,8 @@ codeunit 139711 "APIV1 - Sales Orders E2E" PageSalesHeader.Get(PageSalesHeader."Document Type"::Order, SalesOrder."No.".VALUE()); ApiRecordRef.GetTable(ApiSalesHeader); PageRecordRef.GetTable(PageSalesHeader); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, DATABASE::"Sales Header", 'Operation Occurred Date'); Assert.RecordsAreEqualExceptCertainFields(ApiRecordRef, PageRecordRef, TempIgnoredFieldsForComparison, 'Page and API order do not match'); diff --git a/src/Apps/W1/APIV1/test/src/APIV1SalesQuotesE2E.Codeunit.al b/src/Apps/W1/APIV1/test/src/APIV1SalesQuotesE2E.Codeunit.al index bb10b1c405d..dcca9bc085a 100644 --- a/src/Apps/W1/APIV1/test/src/APIV1SalesQuotesE2E.Codeunit.al +++ b/src/Apps/W1/APIV1/test/src/APIV1SalesQuotesE2E.Codeunit.al @@ -390,6 +390,11 @@ codeunit 139723 "APIV1 - Sales Quotes E2E" PageSalesHeader.Get(PageSalesHeader."Document Type"::Quote, SalesQuote."No.".VALUE()); ApiRecordRef.GETTABLE(ApiSalesHeader); PageRecordRef.GETTABLE(PageSalesHeader); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, DATABASE::"Sales Header", 'Operation Occurred Date'); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, DATABASE::"Sales Header", 'VAT Reporting Date'); + Assert.RecordsAreEqualExceptCertainFields(ApiRecordRef, PageRecordRef, TempIgnoredFieldsForComparison, 'Page and API quote do not match'); end; diff --git a/src/Apps/W1/APIV1/test/src/SalesInvoicesE2E.Codeunit.al b/src/Apps/W1/APIV1/test/src/SalesInvoicesE2E.Codeunit.al index 0f3c2fb8772..c1a6a005e4f 100644 --- a/src/Apps/W1/APIV1/test/src/SalesInvoicesE2E.Codeunit.al +++ b/src/Apps/W1/APIV1/test/src/SalesInvoicesE2E.Codeunit.al @@ -608,6 +608,9 @@ codeunit 139709 "Sales Invoices E2E" PageSalesHeader.GET(PageSalesHeader."Document Type"::Invoice, SalesInvoice."No.".VALUE()); ApiRecordRef.GETTABLE(ApiSalesHeader); PageRecordRef.GETTABLE(PageSalesHeader); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, DATABASE::"Sales Header", 'Operation Occurred Date'); + Assert.RecordsAreEqualExceptCertainFields(ApiRecordRef, PageRecordRef, TempIgnoredFieldsForComparison, 'Page and API Invoice do not match'); diff --git a/src/Apps/W1/APIV2/test/src/APIV2PurchCrMemosE2E.Codeunit.al b/src/Apps/W1/APIV2/test/src/APIV2PurchCrMemosE2E.Codeunit.al index 6db441c1f94..1db81865cd7 100644 --- a/src/Apps/W1/APIV2/test/src/APIV2PurchCrMemosE2E.Codeunit.al +++ b/src/Apps/W1/APIV2/test/src/APIV2PurchCrMemosE2E.Codeunit.al @@ -701,6 +701,8 @@ codeunit 139865 "APIV2 - Purch. Cr. Memos E2E" PurchaseHeader1RecordRef.GetTable(PurchaseHeader1); PurchaseHeader2RecordRef.GetTable(PurchaseHeader2); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, Database::"Purchase Header", 'Operation Occurred Date'); Assert.RecordsAreEqualExceptCertainFields( PurchaseHeader1RecordRef, PurchaseHeader2RecordRef, TempIgnoredFieldsForComparison, 'Credit Memos do not match'); diff --git a/src/Apps/W1/APIV2/test/src/APIV2PurchaseOrdersE2E.Codeunit.al b/src/Apps/W1/APIV2/test/src/APIV2PurchaseOrdersE2E.Codeunit.al index d9cb8200f91..d700fbcdc2e 100644 --- a/src/Apps/W1/APIV2/test/src/APIV2PurchaseOrdersE2E.Codeunit.al +++ b/src/Apps/W1/APIV2/test/src/APIV2PurchaseOrdersE2E.Codeunit.al @@ -429,6 +429,8 @@ codeunit 139851 "APIV2 - Purchase Orders E2E" LibraryUtility.AddTempField(TempIgnoredFieldsForComparison, ApiPurchaseHeader.FieldNo("No."), Database::"Purchase Header"); LibraryUtility.AddTempField( TempIgnoredFieldsForComparison, ApiPurchaseHeader.FieldNo("Posting Description"), Database::"Purchase Header"); + LibraryUtility.AddTempField( + TempIgnoredFieldsForComparison, ApiPurchaseHeader.FieldNo("Order Date"), Database::"Purchase Header"); // Special ignore case for GB LibraryUtility.AddTempField(TempIgnoredFieldsForComparison, ApiPurchaseHeader.FieldNo("Invoice Received Date"), Database::"Purchase Header"); // Special ignore case for ES @@ -443,14 +445,14 @@ codeunit 139851 "APIV2 - Purchase Orders E2E" LibraryUtility.AddTempField(TempIgnoredFieldsForComparison, RecordField."No.", Database::"Purchase Header"); // Time zone will impact how the date from the page vs WebService is saved. If removed this will fail in snap between 12:00 - 1 AM - if Time() < 020000T then begin - LibraryUtility.AddTempField(TempIgnoredFieldsForComparison, ApiPurchaseHeader.FieldNo("Order Date"), Database::"Purchase Header"); + if Time() < 020000T then LibraryUtility.AddTempField(TempIgnoredFieldsForComparison, ApiPurchaseHeader.FieldNo("Posting Date"), Database::"Purchase Header"); - end; PagePurchaseHeader.Get(PagePurchaseHeader."Document Type"::Order, PurchaseOrder."No.".Value()); ApiRecordRef.GetTable(ApiPurchaseHeader); PageRecordRef.GetTable(PagePurchaseHeader); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, Database::"Purchase Header", 'Operation Occurred Date'); Assert.RecordsAreEqualExceptCertainFields(ApiRecordRef, PageRecordRef, TempIgnoredFieldsForComparison, 'Page and API order do not match'); diff --git a/src/Apps/W1/APIV2/test/src/APIV2SalesCreditMemosE2E.Codeunit.al b/src/Apps/W1/APIV2/test/src/APIV2SalesCreditMemosE2E.Codeunit.al index bdb34624da4..21e070dabcf 100644 --- a/src/Apps/W1/APIV2/test/src/APIV2SalesCreditMemosE2E.Codeunit.al +++ b/src/Apps/W1/APIV2/test/src/APIV2SalesCreditMemosE2E.Codeunit.al @@ -984,6 +984,8 @@ codeunit 139828 "APIV2 - Sales Credit Memos E2E" SalesHeader1RecordRef.GetTable(SalesHeader1); SalesHeader2RecordRef.GetTable(SalesHeader2); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, Database::"Sales Header", 'Operation Occurred Date'); Assert.RecordsAreEqualExceptCertainFields( SalesHeader1RecordRef, SalesHeader2RecordRef, TempIgnoredFieldsForComparison, 'Credit Memos do not match'); diff --git a/src/Apps/W1/APIV2/test/src/APIV2SalesInvoicesE2E.Codeunit.al b/src/Apps/W1/APIV2/test/src/APIV2SalesInvoicesE2E.Codeunit.al index f539fe75f71..b4c22687c4a 100644 --- a/src/Apps/W1/APIV2/test/src/APIV2SalesInvoicesE2E.Codeunit.al +++ b/src/Apps/W1/APIV2/test/src/APIV2SalesInvoicesE2E.Codeunit.al @@ -638,6 +638,9 @@ codeunit 139809 "APIV2 - Sales Invoices E2E" PageSalesHeader.Get(PageSalesHeader."Document Type"::Invoice, SalesInvoice."No.".Value()); ApiRecordRef.GetTable(ApiSalesHeader); PageRecordRef.GetTable(PageSalesHeader); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, Database::"Sales Header", 'Operation Occurred Date'); + Assert.RecordsAreEqualExceptCertainFields(ApiRecordRef, PageRecordRef, TempIgnoredFieldsForComparison, 'Page and API Invoice do not match'); diff --git a/src/Apps/W1/APIV2/test/src/APIV2SalesOrdersE2E.Codeunit.al b/src/Apps/W1/APIV2/test/src/APIV2SalesOrdersE2E.Codeunit.al index db27e424803..93f05da23b3 100644 --- a/src/Apps/W1/APIV2/test/src/APIV2SalesOrdersE2E.Codeunit.al +++ b/src/Apps/W1/APIV2/test/src/APIV2SalesOrdersE2E.Codeunit.al @@ -398,6 +398,8 @@ codeunit 139811 "APIV2 - Sales Orders E2E" PageSalesHeader.Get(PageSalesHeader."Document Type"::Order, SalesOrder."No.".Value()); ApiRecordRef.GetTable(ApiSalesHeader); PageRecordRef.GetTable(PageSalesHeader); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, Database::"Sales Header", 'Operation Occurred Date'); Assert.RecordsAreEqualExceptCertainFields(ApiRecordRef, PageRecordRef, TempIgnoredFieldsForComparison, 'Page and API order do not match'); diff --git a/src/Apps/W1/APIV2/test/src/APIV2SalesQuotesE2E.Codeunit.al b/src/Apps/W1/APIV2/test/src/APIV2SalesQuotesE2E.Codeunit.al index 1b5320d6de8..f8165970d7f 100644 --- a/src/Apps/W1/APIV2/test/src/APIV2SalesQuotesE2E.Codeunit.al +++ b/src/Apps/W1/APIV2/test/src/APIV2SalesQuotesE2E.Codeunit.al @@ -378,6 +378,11 @@ codeunit 139823 "APIV2 - Sales Quotes E2E" PageSalesHeader.Get(PageSalesHeader."Document Type"::Quote, SalesQuote."No.".Value()); ApiRecordRef.GetTable(ApiSalesHeader); PageRecordRef.GetTable(PageSalesHeader); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, Database::"Sales Header", 'Operation Occurred Date'); + LibraryGraphMgt.AddFieldToIgnoreIfExists( + TempIgnoredFieldsForComparison, Database::"Sales Header", 'VAT Reporting Date'); + Assert.RecordsAreEqualExceptCertainFields(ApiRecordRef, PageRecordRef, TempIgnoredFieldsForComparison, 'Page and API quote do not match'); end; diff --git a/src/DisabledTests/_Exclude_APIV1__Tests/_Exclude_APIV1__Tests.DisabledTest.json b/src/DisabledTests/_Exclude_APIV1__Tests/_Exclude_APIV1__Tests.DisabledTest.json index e90a41332d7..0ecc9df794a 100644 --- a/src/DisabledTests/_Exclude_APIV1__Tests/_Exclude_APIV1__Tests.DisabledTest.json +++ b/src/DisabledTests/_Exclude_APIV1__Tests/_Exclude_APIV1__Tests.DisabledTest.json @@ -1,29 +1,9 @@ [ - { - "codeunitId": 139709, - "codeunitName": "Sales Invoices E2E", - "method": "TestCreateInvoiceThroughPageAndAPI" - }, { "codeunitId": 139709, "codeunitName": "Sales Invoices E2E", "method": "TestGetInvoicesAppliesDiscountPct" }, - { - "codeunitId": 139711, - "codeunitName": "APIV1 - Sales Orders E2E", - "method": "TestCreateOrderThroughPageAndAPI" - }, - { - "codeunitId": 139723, - "codeunitName": "APIV1 - Sales Quotes E2E", - "method": "TestCreateQuoteThroughPageAndAPI" - }, - { - "codeunitId": 139728, - "codeunitName": "APIV1 - Sales Credit Memos E2E", - "method": "TestCreateCreditMemoThroughPageAndAPI" - }, { "codeunitId": 139730, "codeunitName": "APIV1 - GLEntries E2E", diff --git a/src/DisabledTests/_Exclude_APIV2__Tests/_Exclude_APIV2__Tests.DisabledTest.json b/src/DisabledTests/_Exclude_APIV2__Tests/_Exclude_APIV2__Tests.DisabledTest.json index b1fd5b9793e..069bdfc52e1 100644 --- a/src/DisabledTests/_Exclude_APIV2__Tests/_Exclude_APIV2__Tests.DisabledTest.json +++ b/src/DisabledTests/_Exclude_APIV2__Tests/_Exclude_APIV2__Tests.DisabledTest.json @@ -9,36 +9,6 @@ "codeunitName": "APIV2 - Company Info. E2E", "method": "TestModifyCompanyInformation" }, - { - "codeunitId": 139809, - "codeunitName": "APIV2 - Sales Invoices E2E", - "method": "TestCreateInvoiceThroughPageAndAPI" - }, - { - "codeunitId": 139811, - "codeunitName": "APIV2 - Sales Orders E2E", - "method": "TestCreateOrderThroughPageAndAPI" - }, - { - "codeunitId": 139823, - "codeunitName": "APIV2 - Sales Quotes E2E", - "method": "TestCreateQuoteThroughPageAndAPI" - }, - { - "codeunitId": 139828, - "codeunitName": "APIV2 - Sales Credit Memos E2E", - "method": "TestCreateCreditMemoThroughPageAndAPI" - }, - { - "codeunitId": 139851, - "codeunitName": "APIV2 - Purchase Orders E2E", - "method": "TestCreateOrderThroughPageAndAPI" - }, - { - "codeunitId": 139865, - "codeunitName": "APIV2 - Purch. Cr. Memos E2E", - "method": "TestCreateCreditMemoThroughPageAndAPI" - }, { "codeunitId": 139908, "method": "TestExpandPdfDocument",