[Event Request] codeunit 5979 "Service-Post and Send" - OnBeforConfirmPostAndSend - OnBeforePost

[AlaAuz]

Why do you need this change?

I need this change to be able to use Service post and Send for Service Header document type Order.

Describe the request

Describe the request

Hello, I was wondering if we could get two events in Codeunit 5979 "Service-Post and Send" — OnBeforeConfirmPostAndSend and OnBeforePost?

Today the Code() procedure hard-codes the supported document types (only Invoice and Credit Memo) and calls Service-Post directly, so there is no way to support posting a Service Order from Post & Send, or to substitute the posting routine, without copying the whole codeunit. These two events would let us do that from a subscriber.

Location in the Code() procedure:

    local procedure "Code"()
    var
        TempDocumentSendingProfile: Record "Document Sending Profile" temporary;
        ServicePost: Codeunit "Service-Post";
        //>>>>>>>>>>>>>>>>>>>>>>>>>
        IsHandled: Boolean;
        SkipPost: Boolean;
        //<<<<<<<<<<<<<<<<<<<<<<<<<
    begin
        OnBeforeCode(ServiceHeader);

        //>>>>>>>>>>>>>>>>>>>>>>>>>
        IsHandled := false;
        OnBeforeConfirmPostAndSend(ServiceHeader, IsHandled);
        if IsHandled then begin
            if not ConfirmPostAndSend(ServiceHeader, TempDocumentSendingProfile) then
                exit;
        end else
        //<<<<<<<<<<<<<<<<<<<<<<<<<
            case ServiceHeader."Document Type" of
                ServiceHeader."Document Type"::Invoice,
                  ServiceHeader."Document Type"::"Credit Memo":
                    if not ConfirmPostAndSend(ServiceHeader, TempDocumentSendingProfile) then
                        exit;
                else
                    Error(NotSupportedDocumentTypeErr, ServiceHeader."Document Type");
            end;

        TempDocumentSendingProfile.CheckElectronicSendingEnabled();
        ValidateElectronicFormats(TempDocumentSendingProfile);

        //>>>>>>>>>>>>>>>>>>>>>>>>>
        IsHandled := false;
        SkipPost := false;
        OnBeforePost(ServiceHeader, IsHandled, SkipPost);
        if IsHandled then begin
            if SkipPost then
                exit;
        end else
        //<<<<<<<<<<<<<<<<<<<<<<<<<
            CODEUNIT.Run(CODEUNIT::"Service-Post", ServiceHeader);

        OnAfterPostAndBeforeSend(ServiceHeader);
        Commit();

        ServicePost.SendPostedDocumentRecord(ServiceHeader, TempDocumentSendingProfile);

        OnAfterCode(ServiceHeader);
    end;

Event publishers:

    [IntegrationEvent(false, false)]
    local procedure OnBeforeConfirmPostAndSend(var ServiceHeader: Record "Service Header"; var IsHandled: Boolean)
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforePost(var ServiceHeader: Record "Service Header"; var IsHandled: Boolean; var SkipPost: Boolean)
    begin
    end;

With OnBeforeConfirmPostAndSend, a subscriber can accept additional document types (e.g. Order) by setting IsHandled, which runs ConfirmPostAndSend and skips the else Error. With OnBeforePost, a subscriber can replace the posting (e.g. the Ship/Consume/Invoice dialog for Orders) via IsHandled, and use SkipPost to stop before SendPostedDocumentRecord when nothing was posted.

[github-actions]

Hi Adrian Langelid (@AlaAuz),

Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Performance considerations: Please add a brief statement about the expected execution frequency of these new IsHandled events and their anticipated performance impact.
• Data sensitivity review: Please confirm that the requested events do not expose sensitive data, or explain the sensitivity implications if they do.
• Multi-extension interaction: Please acknowledge the risk of multiple extensions subscribing to these events and briefly explain how that risk is acceptable or should be mitigated.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.

[AlaAuz]

Performance considerations

The events are executed only once per invocation of Codeunit 5979, during the Post & Send process. They are lightweight integration events with no additional processing in the standard implementation. The performance impact is therefore expected to be negligible. Subscribers should, as usual, avoid expensive operations or unnecessary database queries unless required for their specific scenario.

Data sensitivity review

These events expose the Service Header record, which contains the information already available to code executing within the Service Post & Send process. They do not introduce access to a new data source or expose credentials, authentication information, or other inherently sensitive system data. Extensions subscribing to the events should follow the normal Business Central data-access and permission model when handling Service Header data.

Multi-extension interaction

We acknowledge that multiple extensions may subscribe to these events and potentially modify the IsHandled/SkipPost parameters. This is an accepted pattern for Business Central integration events, but subscribers should use these parameters carefully and only handle scenarios they explicitly support. In particular, subscribers should check the document type and exit when the event is not relevant to them, as in the proposed implementation. This minimizes interference between extensions and allows multiple extensions to coexist.

[github-actions]

Hi Adrian Langelid (@AlaAuz),

Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Critical posting replacement handling: Please confirm that you understand OnBeforePost(var ServiceHeader, var IsHandled, var SkipPost) can bypass the standard Service-Post routine, and explain how your extension will safely replace that posting logic.
• Posted-document/send coordination: Please explain how your implementation will ensure SkipPost is set only when no posted document exists, so SendPostedDocumentRecord is not reached in an invalid state.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.