[Events Request] Report 952 "Suggest Job Jnl. Lines"

[AlbBard]

Why do you need this change?

I have to Filter the "Time Sheet Header" and "Time Sheet LIne" for a new filter "Approver Id Filter" that i have to add in request page. I can not use the others events because i can not access to global variable and because I must read only the correct records

Describe the request

I need two new events in report 952 "Suggest Job Jnl. Lines".

Event 1) I need to put the 1stevent in local procedure FillTimeSheetLineBuffer, before the line with code: "if TimeSheetHeader.FindSet() then".

the event will be call here:

if DateFilter <> '' then begin
TimeSheetHeader.SetFilter("Starting Date", DateFilter);
TimeSheetHeader.SetFilter("Starting Date", '..%1', TimeSheetHeader.GetRangeMax("Starting Date"));
TimeSheetHeader.SetFilter("Ending Date", DateFilter);
TimeSheetHeader.SetFilter("Ending Date", '%1..', TimeSheetHeader.GetRangeMin("Ending Date"));
end;

OnAfterFilterTimeSheetHeaderOnFillTimeSheetLineBuffer(TimeSheetHeader);

if TimeSheetHeader.FindSet() then

the event declaration will be:
[IntegrationEvent(true, true)]
local procedure OnAfterFilterTimeSheetHeaderOnFillTimeSheetLineBuffer(var TimeSheetHeader: Record "Time Sheet Header")
begin
end;

Event 2) I need to put the 2nd event in local procedure FillTimeSheetLineBuffer, before the line with code: "if TimeSheetLine.FindSet() then".

the event will be call here:

TimeSheetLine.SetRange(Posted, false);
OnAfterFilterTimeSheetLineOnFillTimeSheetLineBuffer(TimeSheetHeader, TimeSheetLine)
if TimeSheetLine.FindSet() then

the event declaration will be:
[IntegrationEvent(true, true)]
local procedure OnAfterFilterTimeSheetLineOnFillTimeSheetLineBuffer(TimeSheetHeader: Record "Time Sheet Header"; var TimeSheetLine: Record "Time Sheet Line")
begin
end;
Internal work item: AB#646908

[github-actions]

Hi AlbBard,

Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Exact event names and matching signatures: The proposed event invocation names and event declaration names are inconsistent, so the requested change is ambiguous. For event 1, OnBeforeTimeSheetHeaderFindSetOnFillTimeSheetLineBuffer does not match OnAfterFilterTimeSheetHeaderOnFillTimeSheetLineBuffer. For event 2, OnAfterFilterTimeSheetHeaderOnFillTimeSheetLineBuffer does not match OnAfterFilterTimeSheetLineOnFillTimeSheetLineBuffer. Please provide the exact final event names and ensure each invocation matches its declaration.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.

[AlbBard]

You are right. I corrected my request. Could you check it, please?

[github-actions]

✅ Analysis complete - ready for further processing

---

Implementation:

Add two integration events in FillTimeSheetLineBuffer() in report 952 Suggest Job Jnl. Lines so extensions can apply additional filters to Time Sheet Header before TimeSheetHeader.FindSet() and to Time Sheet Line before TimeSheetLine.FindSet().

Location in FillTimeSheetLineBuffer() procedure:

    local procedure FillTimeSheetLineBuffer()
    var
        SkipLine: Boolean;
    begin
        if ResourceNoFilter <> '' then
            TimeSheetHeader.SetFilter("Resource No.", ResourceNoFilter);
        if DateFilter <> '' then begin
            TimeSheetHeader.SetFilter("Starting Date", DateFilter);
            TimeSheetHeader.SetFilter("Starting Date", '..%1', TimeSheetHeader.GetRangeMax("Starting Date"));
            TimeSheetHeader.SetFilter("Ending Date", DateFilter);
            TimeSheetHeader.SetFilter("Ending Date", '%1..', TimeSheetHeader.GetRangeMin("Ending Date"));
        end;

        OnFillTimeSheetLineBufferOnAfterFilterTimeSheetHeader(TimeSheetHeader);
        if TimeSheetHeader.FindSet() then
            repeat
                TimeSheetLine.SetRange("Time Sheet No.", TimeSheetHeader."No.");
                TimeSheetLine.SetRange(Type, TimeSheetLine.Type::Job);
                TimeSheetLine.SetRange(Status, TimeSheetLine.Status::Approved);
                if JobNoFilter <> '' then
                    TimeSheetLine.SetFilter("Job No.", JobNoFilter);
                if JobTaskNoFilter <> '' then
                    TimeSheetLine.SetFilter("Job Task No.", JobTaskNoFilter);
                TimeSheetLine.SetRange(Posted, false);
                OnFillTimeSheetLineBufferOnAfterFilterTimeSheetLine(TimeSheetHeader, TimeSheetLine);
                if TimeSheetLine.FindSet() then
                    repeat
                        TempTimeSheetLine := TimeSheetLine;
                        OnBeforeInsertTempTimeSheetLine(JobJnlLine, TimeSheetHeader, TempTimeSheetLine, SkipLine);
                        if not SkipLine then
                            TempTimeSheetLine.Insert();
                    until TimeSheetLine.Next() = 0;
            until TimeSheetHeader.Next() = 0;
    end;

Event Publisher (add at the end of the codeunit with other events):

    [IntegrationEvent(false, false)]
    local procedure OnFillTimeSheetLineBufferOnAfterFilterTimeSheetHeader(var TimeSheetHeader: Record "Time Sheet Header")
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnFillTimeSheetLineBufferOnAfterFilterTimeSheetLine(TimeSheetHeader: Record "Time Sheet Header"; var TimeSheetLine: Record "Time Sheet Line")
    begin
    end;

---

File: SuggestJobJnlLines.Report.al

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.

[AleksandricMarko]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.