From 51642cf4eb1ee4e286eabf94eed512de223e34c4 Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Tue, 17 Nov 2026 23:52:23 +0000 Subject: [PATCH 1/6] Require maxmind-geoip2 1.7.0 maxmind-geoip2 1.7.0 requires maxmind-db 1.5.0, which bounds the decode of a crafted database and speeds up lookups. Raise the floor so that users get these fixes. 1.7.0 and 1.7.1 have the same code. Co-Authored-By: Claude Opus 5.5 --- CHANGELOG.md | 4 ++++ Gemfile.lock | 8 ++++---- minfraud.gemspec | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3183fc3..fbb930a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -46,6 +46,10 @@ second 60, a UTC offset of 24 hours or more, and a lowercase `t` or `z`. * Added the processor `:ryft` to `Minfraud::Components::Payment`. +* The minimum version of the `maxmind-geoip2` gem is now 1.7.0. It + requires `maxmind-db` 1.5.0, which limits the work and memory of each + decode of a crafted database and makes lookups faster. See the + [maxmind-geoip2 1.7.0 changelog](https://github.com/maxmind/GeoIP2-ruby/blob/v1.7.0/CHANGELOG.md). ## v2.10.0 (2026-07-21) diff --git a/Gemfile.lock b/Gemfile.lock index 76d723d..0a3474c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -4,7 +4,7 @@ PATH minfraud (2.10.0) connection_pool (>= 2.2, < 4.0) http (>= 4.3, < 7.0) - maxmind-geoip2 (~> 1.6) + maxmind-geoip2 (~> 1.7) simpleidn (~> 0.1, >= 0.1.1) GEM @@ -42,11 +42,11 @@ GEM llhttp-ffi (0.5.1) ffi-compiler (~> 1.0) rake (~> 13.0) - maxmind-db (1.4.0) - maxmind-geoip2 (1.6.0) + maxmind-db (1.5.0) + maxmind-geoip2 (1.7.0) connection_pool (>= 2.2, < 4.0) http (>= 4.3, < 7.0) - maxmind-db (~> 1.4) + maxmind-db (~> 1.5) parallel (1.28.0) parser (3.3.13.0) ast (~> 2.4.1) diff --git a/minfraud.gemspec b/minfraud.gemspec index 77a6c0e..01714b3 100644 --- a/minfraud.gemspec +++ b/minfraud.gemspec @@ -31,7 +31,7 @@ Gem::Specification.new do |spec| spec.add_dependency 'connection_pool', '>= 2.2', '< 4.0' spec.add_dependency 'http', '>= 4.3', '< 7.0' - spec.add_dependency 'maxmind-geoip2', '~> 1.6' + spec.add_dependency 'maxmind-geoip2', '~> 1.7' spec.add_dependency 'simpleidn', '~> 0.1', '>= 0.1.1' spec.add_development_dependency 'bundler', '~> 2.2' From 9f1a20f6c0e2bb4e7bd7432dde3f40e721251426 Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Tue, 17 Nov 2026 23:52:35 +0000 Subject: [PATCH 2/6] Keep the release bundle out of the system gems rubygems/release-gem signs the gem with an unbundled `gem exec` that sees the system gems. The job's `bundle install` put json 3.1.0 from Gemfile.lock there, and json 3 breaks the sigstore-cli signer. The action then pushes the gem without an attestation and still passes. GeoIP2-ruby 1.7.0 shipped without an attestation this way. Install the bundle into vendor/bundle instead, and ignore that directory. The gemspec packs only `git ls-files`, so the directory never goes into the gem. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release.yml | 5 +++++ .gitignore | 1 + 2 files changed, 6 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fe4dd8e..3f8dc3e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,6 +17,11 @@ jobs: environment: release permissions: id-token: write + env: + # Keep the bundle out of the system gems. release-gem signs the gem + # with an unbundled `gem exec` that sees the system gems, and the json + # version in Gemfile.lock can break the signer there. + BUNDLE_PATH: vendor/bundle steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: diff --git a/.gitignore b/.gitignore index 3231e9a..fa0c5b3 100644 --- a/.gitignore +++ b/.gitignore @@ -8,3 +8,4 @@ pkg .DS_Store .claude .lycheecache +/vendor/bundle From 2ec4970f232c29cfea1df12184117e907564b3c0 Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Tue, 17 Nov 2026 23:52:45 +0000 Subject: [PATCH 3/6] Update rubygems/release-gem to v1.4.2 v1.4.1 waits for the release with rubygems-await, which fails on Ruby 4.0. v1.4.2 waits without it. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3f8dc3e..c0554fe 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -40,4 +40,4 @@ jobs: # zizmor complains that 'v1' is a ref that can be provided by both the branch and tag namespaces. # specify that we want the v1 branch. - - uses: rubygems/release-gem@7f9650160c1a4e7989fdc9855807bdbd421d8b6b # v1.4.1 + - uses: rubygems/release-gem@5c53f5308233b7c0f47411f0471b3faae6fa57b2 # v1.4.2 From c456f4fec21f2e618bc0181c937239b449de5b34 Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Tue, 17 Nov 2026 23:52:56 +0000 Subject: [PATCH 4/6] Fail the release job when the gem has no attestation release-gem catches a signing error, pushes the gem unsigned, and still passes. RubyGems.org accepts an attestation only at push time, so a missed one costs a new patch release. Ask the RubyGems.org attestation API about each pushed gem, and fail the job if the list is empty. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index c0554fe..5c5a677 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -41,3 +41,16 @@ jobs: # zizmor complains that 'v1' is a ref that can be provided by both the branch and tag namespaces. # specify that we want the v1 branch. - uses: rubygems/release-gem@5c53f5308233b7c0f47411f0471b3faae6fa57b2 # v1.4.2 + + # release-gem pushes the gem without an attestation if signing fails, + # and the job still passes. Fail the job so that someone notices. + - name: Check that RubyGems.org has an attestation + run: | + for gem in pkg/*.gem; do + name="$(basename "$gem" .gem)" + if ! curl -fsS "https://rubygems.org/api/v1/attestations/$name.json" | + jq -e 'length > 0' >/dev/null; then + echo "::error::RubyGems.org has no attestation for $name." + exit 1 + fi + done From 4417afbd3b20b890346e6a63feaffaebd3cc25c8 Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Tue, 17 Nov 2026 23:53:32 +0000 Subject: [PATCH 5/6] Set the 2.11.0 release date dev-bin/release.sh requires a dated heading that matches the release day. Co-Authored-By: Claude Opus 5.5 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fbb930a..413ef2c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Changelog -## v2.11.0 +## v2.11.0 (2026-11-18) * Added the `phone_verification_method`, `phone_was_verification_successful`, and `phone_verification_time` From 93293e0a6067c4325a67b78cc4d6647ae6c1ae5e Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Wed, 18 Nov 2026 00:25:48 +0000 Subject: [PATCH 6/6] Update for v2.11.0 --- Gemfile.lock | 2 +- lib/minfraud/version.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 0a3474c..6f820ff 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - minfraud (2.10.0) + minfraud (2.11.0) connection_pool (>= 2.2, < 4.0) http (>= 4.3, < 7.0) maxmind-geoip2 (~> 1.7) diff --git a/lib/minfraud/version.rb b/lib/minfraud/version.rb index eb80e4c..62c2c10 100644 --- a/lib/minfraud/version.rb +++ b/lib/minfraud/version.rb @@ -2,5 +2,5 @@ module Minfraud # The Gem version. - VERSION = '2.10.0' + VERSION = '2.11.0' end