From 5571e6fd13bf2ede8ed5e8586dec7af94b6d753b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ga=C5=A1per=20Grom?= <gasper.grom@gmail.com>
Date: Tue, 20 Oct 2026 14:08:37 +0100
Subject: [PATCH 1/2] chore: clear the last type errors outside the auth module
 (CM-1537)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Refs linuxfoundation/lfx-cdp-insights-ops#237

Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
---
 .../components/organization-merge-suggestions-dialog.vue | 1 +
 .../components/organization-unmerge-dialog.vue           | 3 +++
 frontend/vite.config.ts                                  | 9 +++++----
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/frontend/src/modules/organization/components/organization-merge-suggestions-dialog.vue b/frontend/src/modules/organization/components/organization-merge-suggestions-dialog.vue
index b9d04d3e42..4288fb7f09 100644
--- a/frontend/src/modules/organization/components/organization-merge-suggestions-dialog.vue
+++ b/frontend/src/modules/organization/components/organization-merge-suggestions-dialog.vue
@@ -12,6 +12,7 @@
       class="!border-t-0 !shadow-none"
       @reload="emit('reload')"
     >
+      <!-- @vue-expect-error shortcut: the child is untyped JS, so its slot is unknown. revisit: when CM-1600/1601 convert it to TypeScript -->
       <template #actions>
         <lf-button
           type="secondary-ghost-light"
diff --git a/frontend/src/modules/organization/components/organization-unmerge-dialog.vue b/frontend/src/modules/organization/components/organization-unmerge-dialog.vue
index 222a8226c6..f95ba48cd0 100644
--- a/frontend/src/modules/organization/components/organization-unmerge-dialog.vue
+++ b/frontend/src/modules/organization/components/organization-unmerge-dialog.vue
@@ -74,6 +74,7 @@
             :organization="props.modelValue"
             is-primary
           >
+            <!-- @vue-expect-error shortcut: the child is untyped JS, so its slot is unknown. revisit: when CM-1600/1601 convert it to TypeScript -->
             <template #header>
               <div class="h-13 flex justify-between items-start">
                 <div
@@ -91,6 +92,7 @@
             is-primary
             is-preview
           >
+            <!-- @vue-expect-error shortcut: the child is untyped JS, so its slot is unknown. revisit: when CM-1600/1601 convert it to TypeScript -->
             <template #header>
               <div class="h-13 flex justify-between items-start">
                 <div
@@ -117,6 +119,7 @@
               :compare-organization="preview.primary"
               is-preview
             >
+              <!-- @vue-expect-error shortcut: the child is untyped JS, so its slot is unknown. revisit: when CM-1600/1601 convert it to TypeScript -->
               <template #header>
                 <div class="h-13">
                   <div class="flex justify-between items-start">
diff --git a/frontend/vite.config.ts b/frontend/vite.config.ts
index 39d577a2f2..14b5a2d6c7 100644
--- a/frontend/vite.config.ts
+++ b/frontend/vite.config.ts
@@ -1,7 +1,7 @@
 import { fileURLToPath, URL } from 'node:url';
 import dns from 'node:dns';
 
-import { defineConfig } from 'vite';
+import { defineConfig, type PluginOption } from 'vite';
 import vue from '@vitejs/plugin-vue';
 
 import Components from 'unplugin-vue-components/vite';
@@ -10,18 +10,19 @@ import { ElementPlusResolver } from 'unplugin-vue-components/resolvers';
 // https://vite.dev/config/server-options#server-host
 dns.setDefaultResultOrder('verbatim');
 
-const analyzerPlugins = async () => {
+const analyzerPlugins = async (): Promise<PluginOption[]> => {
   if (!process.env.ANALYZE) return [];
   // rollup-plugin-visualizer is ESM-only, so a static import breaks this CJS-loaded config
   const { visualizer } = await import('rollup-plugin-visualizer');
   return [
+    // shortcut: the visualizer is typed with rollup's Plugin, not vite's. revisit: when the plugin ships vite-compatible types
     visualizer({
       template: 'treemap',
       open: false,
       gzipSize: true,
       brotliSize: true,
       filename: 'analyse.html',
-    }),
+    }) as PluginOption,
   ];
 };
 
@@ -38,7 +39,7 @@ export default defineConfig(async () => ({
         }),
       ],
       dts: 'components.d.ts',
-    }),
+    }) as PluginOption,
     ...(await analyzerPlugins()),
   ],
   resolve: {

From 0e95bab244a02da28766343f0e9dbad9bb58384f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ga=C5=A1per=20Grom?= <gasper.grom@gmail.com>
Date: Tue, 20 Oct 2026 14:08:37 +0100
Subject: [PATCH 2/2] chore: fail CI on any type error and delete the
 type-check ratchet (CM-1537)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Refs linuxfoundation/lfx-cdp-insights-ops#237

Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
---
 .github/workflows/frontend-checks.yml  |  2 +-
 frontend/package.json                  |  1 -
 frontend/scripts/typecheck-ratchet.mjs | 59 --------------------------
 frontend/typecheck-baseline.json       |  1 -
 4 files changed, 1 insertion(+), 62 deletions(-)
 delete mode 100644 frontend/scripts/typecheck-ratchet.mjs
 delete mode 100644 frontend/typecheck-baseline.json

diff --git a/.github/workflows/frontend-checks.yml b/.github/workflows/frontend-checks.yml
index 2f64003967..559234a9e2 100644
--- a/.github/workflows/frontend-checks.yml
+++ b/.github/workflows/frontend-checks.yml
@@ -92,4 +92,4 @@ jobs:
         run: pnpm install --frozen-lockfile --filter "frontend..."
 
       - name: Type check
-        run: pnpm --filter frontend run typecheck:ci
+        run: pnpm --filter frontend run typecheck
diff --git a/frontend/package.json b/frontend/package.json
index b83b33ead2..32a899ee1e 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -11,7 +11,6 @@
     "lint:cycles": "node scripts/check-cycles.mjs",
     "lint:cycles:update": "node scripts/check-cycles.mjs --update",
     "typecheck": "vue-tsc --noEmit -p tsconfig.json",
-    "typecheck:ci": "node scripts/typecheck-ratchet.mjs",
     "build": "vite build",
     "build:localhost": "vite build --mode localhost",
     "build:production": "vite build --mode prod",
diff --git a/frontend/scripts/typecheck-ratchet.mjs b/frontend/scripts/typecheck-ratchet.mjs
deleted file mode 100644
index e57be78756..0000000000
--- a/frontend/scripts/typecheck-ratchet.mjs
+++ /dev/null
@@ -1,59 +0,0 @@
-// Copyright (c) 2026 The Linux Foundation and each contributor.
-// SPDX-License-Identifier: MIT
-
-import { spawnSync } from 'node:child_process';
-import { readFileSync } from 'node:fs';
-import path from 'node:path';
-import { fileURLToPath } from 'node:url';
-
-const frontendDir = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
-
-const result = spawnSync(
-  path.join(frontendDir, 'node_modules/.bin/vue-tsc'),
-  ['--noEmit', '-p', 'tsconfig.json'],
-  { cwd: frontendDir, encoding: 'utf8', maxBuffer: 64 * 1024 * 1024 },
-);
-
-const { stdout } = result;
-if (result.error || ![0, 2].includes(result.status)) {
-  console.error(`vue-tsc crashed (exit ${result.status}):`);
-  console.error(result.error?.message ?? `${stdout}${result.stderr}`);
-  process.exit(1);
-}
-
-const errorLines = stdout.split('\n').filter((line) => /\berror TS\d+:/.test(line));
-// Config-level errors have no source location or point at a tsconfig file; the check did not really run.
-const configErrors = errorLines.filter((line) =>
-  /^error TS|^[^(]+\.json\(\d+,\d+\): error TS/.test(line),
-);
-if (configErrors.length) {
-  console.error(`tsconfig/project errors, type check did not run:\n${configErrors.join('\n')}`);
-  process.exit(1);
-}
-
-const count = errorLines.length;
-if (result.status !== 0 && count === 0) {
-  console.error(`vue-tsc failed but no errors were parsed (output format changed?):\n${stdout}`);
-  process.exit(1);
-}
-const baseline = JSON.parse(
-  readFileSync(path.join(frontendDir, 'typecheck-baseline.json'), 'utf8'),
-).errors;
-if (!Number.isInteger(baseline)) {
-  console.error('typecheck-baseline.json must be { "errors": <integer> }.');
-  process.exit(1);
-}
-
-if (count > baseline) {
-  console.log(errorLines.join('\n'));
-  console.error(
-    `Type errors rose from ${baseline} to ${count}. Fix them or, if pre-existing, raise the baseline with a justification.`,
-  );
-  process.exitCode = 1;
-} else if (count < baseline) {
-  console.log(
-    `Type errors dropped from ${baseline} to ${count}: lower the baseline to ${count} in typecheck-baseline.json.`,
-  );
-} else {
-  console.log(`Type errors: ${count} (baseline ${baseline})`);
-}
diff --git a/frontend/typecheck-baseline.json b/frontend/typecheck-baseline.json
deleted file mode 100644
index bc173e8b53..0000000000
--- a/frontend/typecheck-baseline.json
+++ /dev/null
@@ -1 +0,0 @@
-{ "errors": 5 }