Skip to content

va: Validate Persistent DCV TXT Record parameter tags per RFC 8659 #8979

Description

@hablutzel1

parseDNSPersistRecord in va/dns_persist.go, which validates the Persistent DCV TXT Record for BR Section 3.2.2.4.22 (DNS TXT Record with Persistent Value), does not validate the parameter tag against the RFC 8659 tag grammar. It accepts a tag containing characters the grammar disallows (for example foo_bar) and ignores it as an unknown parameter.

BR Section 3.2.2.4.22 requires the record to conform to that syntax:

  1. The RDATA value MUST conform to the issue-value syntax as defined in RFC 8659, Section 4.2; and

So accepting a tag that does not match the RFC 8659 tag production could be a violation.

This is the same class of violation as the CAA path, where parseCAARecord accepted invalid (empty) parameter tags. See #8977 for more details.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions