Skip to content

Incorrect decision_tree_create() impl in module-6-decision-tree-practical-assignment-blank.ipynb? #16

Description

As discussed in this thread:
https://www.coursera.org/learn/ml-classification/week/3/discussions/xaGEyhB6Eea44Qp49aJR6w
.. there are some additional lines in Week 3's implementation of decision_tree_create():

    # Create a leaf node if the split is "perfect"
    if len(left_split) == len(data):
        print "Creating leaf node."
        return create_leaf(left_split[target])
    if len(right_split) == len(data):
        print "Creating leaf node."
        ## YOUR CODE HERE

As I wrote in the above-linked thread, I believe that these lines are necessary.

Should they be added to Week 4's implementation of decision_tree_create() as well?

See also: https://www.coursera.org/learn/ml-classification/week/4/discussions/jsKfcBNmEeaAVhLVpQtKaw

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions