diff --git a/.agents/rules/code-core.md b/.agents/rules/code-core.md index c09bff2..56c372f 100644 --- a/.agents/rules/code-core.md +++ b/.agents/rules/code-core.md @@ -1,7 +1,7 @@ --- name: code-core description: Workflow rules shared by every code repo - DocVault, glossary, Plane, Infisical, debugging, memory, code search, editing, tests, spec gates, push rules, red flags, GitHub hygiene -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Code-core rules @@ -90,6 +90,11 @@ needs no secrets. Never hard-code an Infisical project ID anywhere else; read it ## Debugging - Do not rationalize a discrepancy without evidence. Reproduce it from data or code first, then explain it. +- Before you state a cause, list two or three candidates with one check each, and run the checks. Call a + workaround a workaround; the user wants the root cause fixed. +- Never write an identifier (commit SHA, UUID, issue ID, port, path) that no tool output in this context + printed. Look it up first. +- Do not advise a new session or an app restart unless a check shows it will help. - Dates and times: check whether a computation uses the UTC date or the local date (America/Chicago). Never slice ISO strings for day bucketing. - DNS: `nslookup`/`dig` bypass the macOS resolver cache. Use `dscacheutil -q host -a name ` to test diff --git a/.agents/rules/prose-core.md b/.agents/rules/prose-core.md index bf3a331..8070a7f 100644 --- a/.agents/rules/prose-core.md +++ b/.agents/rules/prose-core.md @@ -1,5 +1,5 @@ --- -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Prose-core rules diff --git a/.agents/skills/codacy-analysis-cli/SKILL.md b/.agents/skills/codacy-analysis-cli/SKILL.md index f6885bf..8ac0aac 100644 --- a/.agents/skills/codacy-analysis-cli/SKILL.md +++ b/.agents/skills/codacy-analysis-cli/SKILL.md @@ -5,7 +5,7 @@ license: MIT metadata: author: Codacy version: 1.5.0 -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Codacy Analysis CLI diff --git a/.agents/skills/codacy-cloud-cli/SKILL.md b/.agents/skills/codacy-cloud-cli/SKILL.md index 1856845..9e5577c 100644 --- a/.agents/skills/codacy-cloud-cli/SKILL.md +++ b/.agents/skills/codacy-cloud-cli/SKILL.md @@ -5,7 +5,7 @@ license: MIT metadata: author: Codacy version: 1.6.1 -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Codacy Cloud CLI diff --git a/.agents/skills/codacy-code-review/SKILL.md b/.agents/skills/codacy-code-review/SKILL.md index fecc11e..39d5bdd 100644 --- a/.agents/skills/codacy-code-review/SKILL.md +++ b/.agents/skills/codacy-code-review/SKILL.md @@ -5,7 +5,7 @@ license: MIT metadata: author: Codacy version: 1.5.0 -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Codacy Code Review diff --git a/.agents/skills/code-review/SKILL.md b/.agents/skills/code-review/SKILL.md index d951e24..948d7b6 100644 --- a/.agents/skills/code-review/SKILL.md +++ b/.agents/skills/code-review/SKILL.md @@ -3,7 +3,7 @@ name: code-review description: "Run CodeRabbit CLI reviews, retrieve saved local or GitHub PR fix prompts, and interpret CodeRabbit authentication and review output. Use for CodeRabbit review commands, committed/uncommitted or directory scopes, and CodeRabbit runbooks. Default code-review skill: also trigger for explicit code/PR/quality/security review requests or when a review is needed." metadata: version: "0.1.0" -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # CodeRabbit Code Review diff --git a/.agents/skills/context-drift/SKILL.md b/.agents/skills/context-drift/SKILL.md index 997d833..fd36a91 100644 --- a/.agents/skills/context-drift/SKILL.md +++ b/.agents/skills/context-drift/SKILL.md @@ -11,7 +11,7 @@ description: >- `/vault-drift` for projects migrated to `.context/` (DEVS-37). Triggers: "context drift", "vault drift", "drift audit", "drift check", "context-drift", "audit .context", "check context docs", "foundation drift", "verify foundation", "what should be in .context". -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Context Drift diff --git a/.agents/skills/discernment-nudge/SKILL.md b/.agents/skills/discernment-nudge/SKILL.md index 2b50da7..54357ec 100644 --- a/.agents/skills/discernment-nudge/SKILL.md +++ b/.agents/skills/discernment-nudge/SKILL.md @@ -17,7 +17,7 @@ description: > to double-check, cite, or review — the skill file explains these boundaries and the exact output format. license: Complete terms in LICENSE.txt -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Discernment nudge diff --git a/.agents/skills/discover/SKILL.md b/.agents/skills/discover/SKILL.md index 201a093..7e427c8 100644 --- a/.agents/skills/discover/SKILL.md +++ b/.agents/skills/discover/SKILL.md @@ -8,7 +8,7 @@ description: > Triggers on "/discover", "/brainstorm", "research this issue", "explore this before we spec it". user-invocable: true -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Discover — Phase 1 Structured Brainstorm diff --git a/.agents/skills/issue/SKILL.md b/.agents/skills/issue/SKILL.md index f5d00f4..dc2e5e5 100644 --- a/.agents/skills/issue/SKILL.md +++ b/.agents/skills/issue/SKILL.md @@ -6,7 +6,7 @@ description: > Triggers on: "create issue", "issue", "new issue", "new bug", "file a bug", "track this". user-invocable: false -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Issue Management @@ -38,7 +38,8 @@ If there is no `plane` block, stop and tell the user the project isn't wired to mcp__plane__label action: "list", project_id: {plane_project_id} ``` - Map names → uuids. Cache for the rest of the session. + Map names → uuids. Use a UUID only from a list result still in your context; after a compaction, list + again. Never type a state or label UUID from memory or from another project. 2. **Pick state and label from user intent:** diff --git a/.agents/skills/pr-cleanup/SKILL.md b/.agents/skills/pr-cleanup/SKILL.md index 0227aaa..2748b72 100644 --- a/.agents/skills/pr-cleanup/SKILL.md +++ b/.agents/skills/pr-cleanup/SKILL.md @@ -5,7 +5,7 @@ description: > local branches and their worktrees, pulls main fast-forward, and reports the result. Run after a PR is merged, before /wrap. Triggers: "pr-cleanup", "clean up branches", "prune worktrees", "clean after merge". -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # PR Cleanup diff --git a/.agents/skills/pr-resolve/SKILL.md b/.agents/skills/pr-resolve/SKILL.md index 731f819..890bae1 100644 --- a/.agents/skills/pr-resolve/SKILL.md +++ b/.agents/skills/pr-resolve/SKILL.md @@ -1,7 +1,7 @@ --- name: pr-resolve description: PR resolve — work through open PR review threads and Codacy issues to get a PR approved and merged. -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # PR Resolve @@ -215,13 +215,13 @@ Use the previously-resolved list above for duplicate detection: if a re-fetched # (broad-add risks committing .env, untracked agent scratch, or unrelated edits). # Enumerate the file set from the cluster reports and pass them explicitly: git add path/to/file1 path/to/file2 ... -git commit -m "fix: resolve PR review findings (PR #XX) - -Co-Authored-By: Claude Opus 4.6 " +git commit -m "fix: resolve PR review findings (PR #XX)" git push origin +SHA=$(git rev-parse --short HEAD) +git fetch origin && git merge-base --is-ancestor "$SHA" "origin/" && echo "$SHA on remote" ``` -4. **Post replies and resolve threads.** For each cluster's resolution report, post the reply and resolve the thread: +4. **Post replies and resolve threads.** Replace every `{SHA}` placeholder in the cluster replies with `$SHA` from step 3. Do not post a reply whose SHA was not printed by git in this session. Then post the reply and resolve the thread: ```bash # Reply to thread diff --git a/.agents/skills/receiving-code-review/SKILL.md b/.agents/skills/receiving-code-review/SKILL.md index d4258de..ef6c581 100644 --- a/.agents/skills/receiving-code-review/SKILL.md +++ b/.agents/skills/receiving-code-review/SKILL.md @@ -1,7 +1,7 @@ --- name: receiving-code-review description: Receiving code review feedback — verify before implementing, never blindly agree. -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Code Review Reception diff --git a/.agents/skills/requesting-code-review/SKILL.md b/.agents/skills/requesting-code-review/SKILL.md index 07b701e..8301bfc 100644 --- a/.agents/skills/requesting-code-review/SKILL.md +++ b/.agents/skills/requesting-code-review/SKILL.md @@ -1,7 +1,7 @@ --- name: requesting-code-review description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Requesting Code Review diff --git a/.agents/skills/setup-foundation-context/SKILL.md b/.agents/skills/setup-foundation-context/SKILL.md index 0025613..c85eecc 100644 --- a/.agents/skills/setup-foundation-context/SKILL.md +++ b/.agents/skills/setup-foundation-context/SKILL.md @@ -8,7 +8,7 @@ description: >- copies. Dry-run by default. Run once per project in a fresh session. Operationalizes DEVS-37. Triggers: "/setup-foundation-context", "setup foundation context", "migrate foundation docs to .context", "onboard foundation docs", "context foundation setup". -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Setup Foundation Context diff --git a/.agents/skills/spec-approach/SKILL.md b/.agents/skills/spec-approach/SKILL.md index ebb7bb0..0e1800c 100644 --- a/.agents/skills/spec-approach/SKILL.md +++ b/.agents/skills/spec-approach/SKILL.md @@ -2,7 +2,7 @@ name: spec-approach description: "Spec Phase 3 — architecture, key decisions, file map (+ UI Contract) into approach.md. Standalone, ISSUE-first. Reads universal + per-project conventions." user-invocable: true -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-approach ISSUE diff --git a/.agents/skills/spec-discovery/SKILL.md b/.agents/skills/spec-discovery/SKILL.md index 9e101bf..485e37e 100644 --- a/.agents/skills/spec-discovery/SKILL.md +++ b/.agents/skills/spec-discovery/SKILL.md @@ -2,7 +2,7 @@ name: spec-discovery description: "Spec Phase 2 — research the codebase + prior art into discovery.md. Standalone, ISSUE-first. Uses a read-only Workflow fan-out for the research sweep." user-invocable: true -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-discovery ISSUE diff --git a/.agents/skills/spec-reconcile/SKILL.md b/.agents/skills/spec-reconcile/SKILL.md index 50631a1..6c8b47b 100644 --- a/.agents/skills/spec-reconcile/SKILL.md +++ b/.agents/skills/spec-reconcile/SKILL.md @@ -2,7 +2,7 @@ name: spec-reconcile description: "Spec process step — classify /spec-review marks for one phase, apply them with human approval, archive the originals. ISSUE PHASE first." user-invocable: true -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-reconcile ISSUE PHASE diff --git a/.agents/skills/spec-requirements/SKILL.md b/.agents/skills/spec-requirements/SKILL.md index b9af746..e66e235 100644 --- a/.agents/skills/spec-requirements/SKILL.md +++ b/.agents/skills/spec-requirements/SKILL.md @@ -2,7 +2,7 @@ name: spec-requirements description: "Spec Phase 1 — grill the issue, then draft requirements.md in EARS. Standalone, ISSUE-first. Reads universal conventions + per-project overrides." user-invocable: true -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-requirements ISSUE diff --git a/.agents/skills/spec-review/SKILL.md b/.agents/skills/spec-review/SKILL.md index 4ee9b0f..bdfede3 100644 --- a/.agents/skills/spec-review/SKILL.md +++ b/.agents/skills/spec-review/SKILL.md @@ -1,7 +1,7 @@ --- name: spec-review description: "Reviewer-side /spec peer review. Reviews one phase of an active spec against the codebase." -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-review diff --git a/.agents/skills/spec-tasks/SKILL.md b/.agents/skills/spec-tasks/SKILL.md index 3525c32..8bb8f87 100644 --- a/.agents/skills/spec-tasks/SKILL.md +++ b/.agents/skills/spec-tasks/SKILL.md @@ -2,7 +2,7 @@ name: spec-tasks description: "Spec Phase 4 — break approach into a TDD sprint-cohort checklist in tasks.md. Standalone, ISSUE-first. Reads universal + per-project conventions and the tasks template." user-invocable: true -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-tasks ISSUE diff --git a/.agents/skills/spec/SKILL.md b/.agents/skills/spec/SKILL.md index 389dc1b..f447549 100644 --- a/.agents/skills/spec/SKILL.md +++ b/.agents/skills/spec/SKILL.md @@ -2,7 +2,7 @@ name: spec description: "Phased spec workflow above a quick fix. Driver for the /spec-* phase family + execution engines (run/workflow/dispatch). Phased markdown artifacts in the repo's specs root (specs.path in .claude/project.json, default DocVault/specs/)." user-invocable: true -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Spec — Phased Spec Workflow (driver) diff --git a/.agents/skills/start/SKILL.md b/.agents/skills/start/SKILL.md index 69eaee7..297453f 100644 --- a/.agents/skills/start/SKILL.md +++ b/.agents/skills/start/SKILL.md @@ -8,7 +8,7 @@ description: > for continuing same-day work or resuming after a short break. No indexing, no code search, no agent dispatch. Triggers: "start", "quick start", "resume", "orient me", "where were we". -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Start diff --git a/.agents/skills/vault-update/SKILL.md b/.agents/skills/vault-update/SKILL.md index 58593d1..5c73aa3 100644 --- a/.agents/skills/vault-update/SKILL.md +++ b/.agents/skills/vault-update/SKILL.md @@ -7,7 +7,7 @@ description: > architecture decisions are made, or project docs need updating. Triggers on: "update vault", "vault update", "docvault", "update docs", "add to vault", "vault" user-invocable: true -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Vault Update diff --git a/.agents/skills/verification-before-completion/SKILL.md b/.agents/skills/verification-before-completion/SKILL.md index f1db8d4..854e0ba 100644 --- a/.agents/skills/verification-before-completion/SKILL.md +++ b/.agents/skills/verification-before-completion/SKILL.md @@ -1,7 +1,7 @@ --- name: verification-before-completion description: Run verification commands before claiming work is complete. Evidence before assertions. -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Verification Before Completion diff --git a/.agents/skills/wrap/SKILL.md b/.agents/skills/wrap/SKILL.md index b5e9d51..76e9681 100644 --- a/.agents/skills/wrap/SKILL.md +++ b/.agents/skills/wrap/SKILL.md @@ -6,7 +6,7 @@ description: > facts to .context/, syncs docs, and reports Session Health. Run at end of any session, optionally after /pr-cleanup. Triggers: "wrap", "wrap up", "close session", "end of session", "done for the night", "finish up", "closing time". -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Wrap Session diff --git a/.claude/agents/firecrawl-scraper.md b/.claude/agents/firecrawl-scraper.md index 057aac7..afeb36f 100644 --- a/.claude/agents/firecrawl-scraper.md +++ b/.claude/agents/firecrawl-scraper.md @@ -2,7 +2,7 @@ name: firecrawl-scraper description: "Web scraping and research subagent. Dispatched to scrape URLs, search the web, crawl sites, and extract structured data using the self-hosted Firecrawl MCP tools. Returns distilled results to keep the main context clean." model: haiku -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- You are a web scraping specialist. You are dispatched by the orchestrator to fetch, extract, and distill web content. Your job is to do the scraping work and return only the useful results — never dump raw HTML or full page markdown back to the caller unless explicitly asked. diff --git a/.claude/agents/pr-discover.md b/.claude/agents/pr-discover.md index 0bbabd4..eb6fdfc 100644 --- a/.claude/agents/pr-discover.md +++ b/.claude/agents/pr-discover.md @@ -2,7 +2,7 @@ name: pr-discover description: "PR discovery and pre-analysis agent. Gathers all PR review threads, Codacy findings, runs code review subagents, and returns a structured findings report with file-based thread clusters. Dispatched by /pr-resolve to isolate the heavy data-gathering phases from main context." model: sonnet -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # PR Discovery & Pre-Analysis Agent diff --git a/.claude/agents/pr-thread-resolver.md b/.claude/agents/pr-thread-resolver.md index 2e7bad6..f51b131 100644 --- a/.claude/agents/pr-thread-resolver.md +++ b/.claude/agents/pr-thread-resolver.md @@ -2,7 +2,7 @@ name: pr-thread-resolver description: "Resolves a cluster of PR review threads grouped by file/topic. Dispatched in parallel by pr-resolve for independent clusters. Re-fetches thread IDs via GraphQL before acting to handle intervening rebases. Makes code fixes, generates replies, and returns results for the orchestrator to post." model: sonnet -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- You are a PR thread cluster resolver. You receive a cluster of classified review threads (all on the same file or topic) and execute the resolutions — fixing code, generating replies, or both. Multiple clusters run in parallel, but within your cluster you handle threads sequentially to avoid edit conflicts. @@ -85,11 +85,14 @@ Read the code context to understand why the suggestion doesn't apply, then gener ### Resolved (already fixed) -Find the commit that fixed the issue: +Find the commit that fixed the issue on the PR head, not on local `HEAD`: ```bash -git log --oneline --all --max-count=5 -- +git fetch -q origin "pull//head" +git log --oneline --max-count=5 FETCH_HEAD -- ``` +Every SHA this prints is on the PR head. Cite only a SHA that these commands printed. If no commit confirms the fix, report the thread as "Fix now" or unresolved. + ### Skill Required The fix requires invoking a project skill (e.g., `/update-spot-bundle`, `/release`). Use the Skill tool: @@ -125,7 +128,7 @@ Return a structured cluster resolution report: **Comment ID:** **Fix:** **Files modified:** -**Reply text:** Fixed — +**Reply text:** Fixed in `{SHA}` — #### Thread T2 — : **Classification:** False positive @@ -151,7 +154,8 @@ Return a structured cluster resolution report: - **Re-fetch is mandatory.** Never skip Phase 0. A 30-second-old discovery can have stale IDs after a force-push. - **Don't resolve threads yourself.** Return the reply text and thread IDs — the orchestrator posts replies and resolves threads. - **Don't commit.** Stage fixes with `git add` but don't commit. The orchestrator batches. -- **Be precise in replies.** Cite specific code, commit SHAs, or technical reasons. +- **Be precise in replies.** Cite specific code (`file:line`) or technical reasons. +- **Never write an identifier you did not read.** A fix commit does not exist yet, so a "Fix now" reply keeps the literal `{SHA}` placeholder; the orchestrator fills it after the push. Any other SHA, issue ID or UUID must come from a command output in this run. - **For "Fix now" items, actually fix the code.** Don't just describe what should change. - **If you can't determine the right fix,** report back with what you found and let the orchestrator decide. - **Sequential within cluster.** Process threads in order. If thread T2's fix depends on T1's edit, read the file fresh after T1's edit lands. diff --git a/.claude/hooks/block-pr-merge.py b/.claude/hooks/block-pr-merge.py index c91e608..3b7c056 100644 --- a/.claude/hooks/block-pr-merge.py +++ b/.claude/hooks/block-pr-merge.py @@ -1,5 +1,5 @@ #!/usr/bin/env python3 -# library-version: e3dbf30dcd3c +# library-version: 4b65e212cbd7 """PreToolUse hook: force human approval for any PR merge. Merging a PR is a human-gated activity. Green CI is NOT authorization. diff --git a/.claude/hooks/docvault-lint.py b/.claude/hooks/docvault-lint.py index 5a9a047..a4cdc2c 100644 --- a/.claude/hooks/docvault-lint.py +++ b/.claude/hooks/docvault-lint.py @@ -1,5 +1,5 @@ #!/usr/bin/env python3 -# library-version: e3dbf30dcd3c +# library-version: 4b65e212cbd7 """Post-edit lint hook for DocVault vaults — markdownlint + frontmatter + wikilink checks. DEVS-78: any `*/DocVault/**` file is a vault page (project vaults in each repo, the shared diff --git a/.claude/hooks/vale-staged.py b/.claude/hooks/vale-staged.py index 6f490bb..9742ff2 100644 --- a/.claude/hooks/vale-staged.py +++ b/.claude/hooks/vale-staged.py @@ -1,5 +1,5 @@ #!/usr/bin/env python3 -# library-version: e3dbf30dcd3c +# library-version: 4b65e212cbd7 """PostToolUse hook: report Vale alerts on the lines a `git commit` added. It lints a snapshot of HEAD, so the text and line numbers match the commit, whatever the diff --git a/.claude/hooks/worktree-safety.py b/.claude/hooks/worktree-safety.py index 4f4f243..9b99b50 100644 --- a/.claude/hooks/worktree-safety.py +++ b/.claude/hooks/worktree-safety.py @@ -1,5 +1,5 @@ #!/usr/bin/env python3 -# library-version: e3dbf30dcd3c +# library-version: 4b65e212cbd7 """PreToolUse hook — warns when an Edit/Write targets a file outside the active worktree. Catches the common mistake of editing files in the main repo checkout when diff --git a/.claude/rules/code-core.md b/.claude/rules/code-core.md index fdf5519..0b0044e 100644 --- a/.claude/rules/code-core.md +++ b/.claude/rules/code-core.md @@ -1,7 +1,7 @@ --- name: code-core description: Workflow rules shared by every code repo - DocVault, glossary, Plane, Infisical, debugging, memory, code search, editing, tests, spec gates, push rules, red flags, GitHub hygiene -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Code-core rules @@ -90,6 +90,11 @@ needs no secrets. Never hard-code an Infisical project ID anywhere else; read it ## Debugging - Do not rationalize a discrepancy without evidence. Reproduce it from data or code first, then explain it. +- Before you state a cause, list two or three candidates with one check each, and run the checks. Call a + workaround a workaround; the user wants the root cause fixed. +- Never write an identifier (commit SHA, UUID, issue ID, port, path) that no tool output in this context + printed. Look it up first. +- Do not advise a new session or an app restart unless a check shows it will help. - Dates and times: check whether a computation uses the UTC date or the local date (America/Chicago). Never slice ISO strings for day bucketing. - DNS: `nslookup`/`dig` bypass the macOS resolver cache. Use `dscacheutil -q host -a name ` to test diff --git a/.claude/rules/prose-core.md b/.claude/rules/prose-core.md index bf3a331..8070a7f 100644 --- a/.claude/rules/prose-core.md +++ b/.claude/rules/prose-core.md @@ -1,5 +1,5 @@ --- -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Prose-core rules diff --git a/.claude/skills/.library-manifest b/.claude/skills/.library-manifest index fd59d50..fee29f7 100644 --- a/.claude/skills/.library-manifest +++ b/.claude/skills/.library-manifest @@ -1,6 +1,6 @@ # Managed by skills-deploy (DEVS-125). Entries here are overwritten or removed by --apply; # every other skill or agent in this repo is project-owned and never touched. -# library-version: e3dbf30dcd3c +# library-version: 4b65e212cbd7 skill start skill wrap skill issue diff --git a/.claude/skills/codacy-analysis-cli/SKILL.md b/.claude/skills/codacy-analysis-cli/SKILL.md index f6885bf..8ac0aac 100644 --- a/.claude/skills/codacy-analysis-cli/SKILL.md +++ b/.claude/skills/codacy-analysis-cli/SKILL.md @@ -5,7 +5,7 @@ license: MIT metadata: author: Codacy version: 1.5.0 -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Codacy Analysis CLI diff --git a/.claude/skills/codacy-cloud-cli/SKILL.md b/.claude/skills/codacy-cloud-cli/SKILL.md index 1856845..9e5577c 100644 --- a/.claude/skills/codacy-cloud-cli/SKILL.md +++ b/.claude/skills/codacy-cloud-cli/SKILL.md @@ -5,7 +5,7 @@ license: MIT metadata: author: Codacy version: 1.6.1 -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Codacy Cloud CLI diff --git a/.claude/skills/codacy-code-review/SKILL.md b/.claude/skills/codacy-code-review/SKILL.md index fecc11e..39d5bdd 100644 --- a/.claude/skills/codacy-code-review/SKILL.md +++ b/.claude/skills/codacy-code-review/SKILL.md @@ -5,7 +5,7 @@ license: MIT metadata: author: Codacy version: 1.5.0 -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Codacy Code Review diff --git a/.claude/skills/context-drift/SKILL.md b/.claude/skills/context-drift/SKILL.md index 46751d5..a2de7b1 100644 --- a/.claude/skills/context-drift/SKILL.md +++ b/.claude/skills/context-drift/SKILL.md @@ -12,7 +12,7 @@ description: >- "context-drift", "audit .context", "check context docs", "foundation drift", "verify foundation", "what should be in .context". allowed-tools: Read, Write, Edit, Bash, Glob, Grep, Skill, Agent -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Context Drift diff --git a/.claude/skills/discernment-nudge/SKILL.md b/.claude/skills/discernment-nudge/SKILL.md index 2b50da7..54357ec 100644 --- a/.claude/skills/discernment-nudge/SKILL.md +++ b/.claude/skills/discernment-nudge/SKILL.md @@ -17,7 +17,7 @@ description: > to double-check, cite, or review — the skill file explains these boundaries and the exact output format. license: Complete terms in LICENSE.txt -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Discernment nudge diff --git a/.claude/skills/discover/SKILL.md b/.claude/skills/discover/SKILL.md index c710f93..e465985 100644 --- a/.claude/skills/discover/SKILL.md +++ b/.claude/skills/discover/SKILL.md @@ -21,7 +21,7 @@ allowed-tools: >- mcp__sessionflow__add_memory, mcp__sessionflow__search_all_sessions, mcp__sessionflow__get_issue_timeline -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Discover — Phase 1 Structured Brainstorm diff --git a/.claude/skills/issue/SKILL.md b/.claude/skills/issue/SKILL.md index f5d00f4..dc2e5e5 100644 --- a/.claude/skills/issue/SKILL.md +++ b/.claude/skills/issue/SKILL.md @@ -6,7 +6,7 @@ description: > Triggers on: "create issue", "issue", "new issue", "new bug", "file a bug", "track this". user-invocable: false -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Issue Management @@ -38,7 +38,8 @@ If there is no `plane` block, stop and tell the user the project isn't wired to mcp__plane__label action: "list", project_id: {plane_project_id} ``` - Map names → uuids. Cache for the rest of the session. + Map names → uuids. Use a UUID only from a list result still in your context; after a compaction, list + again. Never type a state or label UUID from memory or from another project. 2. **Pick state and label from user intent:** diff --git a/.claude/skills/pr-cleanup/SKILL.md b/.claude/skills/pr-cleanup/SKILL.md index 0227aaa..2748b72 100644 --- a/.claude/skills/pr-cleanup/SKILL.md +++ b/.claude/skills/pr-cleanup/SKILL.md @@ -5,7 +5,7 @@ description: > local branches and their worktrees, pulls main fast-forward, and reports the result. Run after a PR is merged, before /wrap. Triggers: "pr-cleanup", "clean up branches", "prune worktrees", "clean after merge". -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # PR Cleanup diff --git a/.claude/skills/pr-resolve/SKILL.md b/.claude/skills/pr-resolve/SKILL.md index c061dce..2af505b 100644 --- a/.claude/skills/pr-resolve/SKILL.md +++ b/.claude/skills/pr-resolve/SKILL.md @@ -2,7 +2,7 @@ name: pr-resolve description: PR resolve — work through open PR review threads and Codacy issues to get a PR approved and merged. allowed-tools: Bash, Read, Write, Edit, Grep, Glob, mcp__infisical__get-secret, mcp__github__get_pull_request, mcp__github__list_pull_requests, mcp__github__get_pull_request_status, mcp__github__get_pull_request_reviews, mcp__github__get_pull_request_comments, mcp__github__get_pull_request_files -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # PR Resolve @@ -216,13 +216,13 @@ Use the previously-resolved list above for duplicate detection: if a re-fetched # (broad-add risks committing .env, untracked agent scratch, or unrelated edits). # Enumerate the file set from the cluster reports and pass them explicitly: git add path/to/file1 path/to/file2 ... -git commit -m "fix: resolve PR review findings (PR #XX) - -Co-Authored-By: Claude Opus 4.6 " +git commit -m "fix: resolve PR review findings (PR #XX)" git push origin +SHA=$(git rev-parse --short HEAD) +git fetch origin && git merge-base --is-ancestor "$SHA" "origin/" && echo "$SHA on remote" ``` -4. **Post replies and resolve threads.** For each cluster's resolution report, post the reply and resolve the thread: +4. **Post replies and resolve threads.** Replace every `{SHA}` placeholder in the cluster replies with `$SHA` from step 3. Do not post a reply whose SHA was not printed by git in this session. Then post the reply and resolve the thread: ```bash # Reply to thread diff --git a/.claude/skills/receiving-code-review/SKILL.md b/.claude/skills/receiving-code-review/SKILL.md index d4258de..ef6c581 100644 --- a/.claude/skills/receiving-code-review/SKILL.md +++ b/.claude/skills/receiving-code-review/SKILL.md @@ -1,7 +1,7 @@ --- name: receiving-code-review description: Receiving code review feedback — verify before implementing, never blindly agree. -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Code Review Reception diff --git a/.claude/skills/requesting-code-review/SKILL.md b/.claude/skills/requesting-code-review/SKILL.md index bc9fdbe..f39c4db 100644 --- a/.claude/skills/requesting-code-review/SKILL.md +++ b/.claude/skills/requesting-code-review/SKILL.md @@ -1,7 +1,7 @@ --- name: requesting-code-review description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Requesting Code Review diff --git a/.claude/skills/setup-foundation-context/SKILL.md b/.claude/skills/setup-foundation-context/SKILL.md index 7900ba6..f11e603 100644 --- a/.claude/skills/setup-foundation-context/SKILL.md +++ b/.claude/skills/setup-foundation-context/SKILL.md @@ -9,7 +9,7 @@ description: >- DEVS-37. Triggers: "/setup-foundation-context", "setup foundation context", "migrate foundation docs to .context", "onboard foundation docs", "context foundation setup". allowed-tools: Read, Write, Edit, Bash, Glob, Grep, Skill -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Setup Foundation Context diff --git a/.claude/skills/spec-approach/SKILL.md b/.claude/skills/spec-approach/SKILL.md index be69dec..f2058f6 100644 --- a/.claude/skills/spec-approach/SKILL.md +++ b/.claude/skills/spec-approach/SKILL.md @@ -4,7 +4,7 @@ description: "Spec Phase 3 — architecture, key decisions, file map (+ UI Contr user-invocable: true allowed-tools: >- Bash, Read, Write, Edit, Glob, Grep -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-approach ISSUE diff --git a/.claude/skills/spec-discovery/SKILL.md b/.claude/skills/spec-discovery/SKILL.md index 6056970..b5a84b1 100644 --- a/.claude/skills/spec-discovery/SKILL.md +++ b/.claude/skills/spec-discovery/SKILL.md @@ -6,7 +6,7 @@ allowed-tools: >- Bash, Read, Write, Edit, Glob, Grep, Workflow, ToolSearch, mcp__context7__resolve-library-id, mcp__brave-search__brave_web_search -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-discovery ISSUE diff --git a/.claude/skills/spec-reconcile/SKILL.md b/.claude/skills/spec-reconcile/SKILL.md index 7eaf970..caa8be4 100644 --- a/.claude/skills/spec-reconcile/SKILL.md +++ b/.claude/skills/spec-reconcile/SKILL.md @@ -4,7 +4,7 @@ description: "Spec process step — classify /spec-review marks for one phase, a user-invocable: true allowed-tools: >- Bash, Read, Write, Edit, Glob, Grep, AskUserQuestion -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-reconcile ISSUE PHASE diff --git a/.claude/skills/spec-requirements/SKILL.md b/.claude/skills/spec-requirements/SKILL.md index 5f560b1..fd8d243 100644 --- a/.claude/skills/spec-requirements/SKILL.md +++ b/.claude/skills/spec-requirements/SKILL.md @@ -5,7 +5,7 @@ user-invocable: true allowed-tools: >- Bash, Read, Write, Edit, Glob, Grep, AskUserQuestion, Skill, mcp__plane__workitem -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-requirements ISSUE diff --git a/.claude/skills/spec-review/SKILL.md b/.claude/skills/spec-review/SKILL.md index 581a791..7055f55 100644 --- a/.claude/skills/spec-review/SKILL.md +++ b/.claude/skills/spec-review/SKILL.md @@ -1,7 +1,7 @@ --- name: spec-review description: "Reviewer-side /spec peer review. Reviews one phase of an active spec against the codebase." -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-review diff --git a/.claude/skills/spec-tasks/SKILL.md b/.claude/skills/spec-tasks/SKILL.md index 4948684..06bd9f3 100644 --- a/.claude/skills/spec-tasks/SKILL.md +++ b/.claude/skills/spec-tasks/SKILL.md @@ -4,7 +4,7 @@ description: "Spec Phase 4 — break approach into a TDD sprint-cohort checklist user-invocable: true allowed-tools: >- Bash, Read, Write, Edit, Glob, Grep, AskUserQuestion -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # /spec-tasks ISSUE diff --git a/.claude/skills/spec/SKILL.md b/.claude/skills/spec/SKILL.md index 8d2e5a0..ef2d89e 100644 --- a/.claude/skills/spec/SKILL.md +++ b/.claude/skills/spec/SKILL.md @@ -7,7 +7,7 @@ allowed-tools: >- mcp__plane__workitem, mcp__plane__state, mcp__plane__project -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Spec — Phased Spec Workflow (driver) diff --git a/.claude/skills/start/SKILL.md b/.claude/skills/start/SKILL.md index 648e7b2..48cf39d 100644 --- a/.claude/skills/start/SKILL.md +++ b/.claude/skills/start/SKILL.md @@ -8,7 +8,7 @@ description: > for continuing same-day work or resuming after a short break. No indexing, no code search, no agent dispatch. Triggers: "start", "quick start", "resume", "orient me", "where were we". -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Start diff --git a/.claude/skills/vault-update/SKILL.md b/.claude/skills/vault-update/SKILL.md index 9ebbb91..4458489 100644 --- a/.claude/skills/vault-update/SKILL.md +++ b/.claude/skills/vault-update/SKILL.md @@ -8,7 +8,7 @@ description: > "vault update", "docvault", "update docs", "add to vault", "vault" user-invocable: true allowed-tools: Bash, Read, Write, Edit, Grep, Glob -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Vault Update diff --git a/.claude/skills/verification-before-completion/SKILL.md b/.claude/skills/verification-before-completion/SKILL.md index f1db8d4..854e0ba 100644 --- a/.claude/skills/verification-before-completion/SKILL.md +++ b/.claude/skills/verification-before-completion/SKILL.md @@ -1,7 +1,7 @@ --- name: verification-before-completion description: Run verification commands before claiming work is complete. Evidence before assertions. -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Verification Before Completion diff --git a/.claude/skills/wrap/SKILL.md b/.claude/skills/wrap/SKILL.md index 48be8fc..2b14d7e 100644 --- a/.claude/skills/wrap/SKILL.md +++ b/.claude/skills/wrap/SKILL.md @@ -6,7 +6,7 @@ description: > facts to .context/, syncs docs, and reports Session Health. Run at end of any session, optionally after /pr-cleanup. Triggers: "wrap", "wrap up", "close session", "end of session", "done for the night", "finish up", "closing time". -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Wrap Session diff --git a/.codex/agents/firecrawl-scraper.toml b/.codex/agents/firecrawl-scraper.toml index c9ee488..83c46df 100644 --- a/.codex/agents/firecrawl-scraper.toml +++ b/.codex/agents/firecrawl-scraper.toml @@ -1,4 +1,4 @@ -# library-version: e3dbf30dcd3c +# library-version: 4b65e212cbd7 description = "Web scraping and research subagent. Dispatched to scrape URLs, search the web, crawl sites, and extract structured data using the self-hosted Firecrawl MCP tools. Returns distilled results to keep the main context clean." developer_instructions = """ You are a web scraping specialist. You are dispatched by the orchestrator to fetch, extract, and distill web content. Your job is to do the scraping work and return only the useful results — never dump raw HTML or full page markdown back to the caller unless explicitly asked. diff --git a/.codex/agents/pr-discover.toml b/.codex/agents/pr-discover.toml index eb37447..27c6490 100644 --- a/.codex/agents/pr-discover.toml +++ b/.codex/agents/pr-discover.toml @@ -1,4 +1,4 @@ -# library-version: e3dbf30dcd3c +# library-version: 4b65e212cbd7 description = "PR discovery and pre-analysis agent. Gathers all PR review threads, Codacy findings, runs code review subagents, and returns a structured findings report with file-based thread clusters. Dispatched by /pr-resolve to isolate the heavy data-gathering phases from main context." developer_instructions = ''' # PR Discovery & Pre-Analysis Agent diff --git a/.codex/agents/pr-thread-resolver.toml b/.codex/agents/pr-thread-resolver.toml index 7643525..3023855 100644 --- a/.codex/agents/pr-thread-resolver.toml +++ b/.codex/agents/pr-thread-resolver.toml @@ -1,4 +1,4 @@ -# library-version: e3dbf30dcd3c +# library-version: 4b65e212cbd7 description = "Resolves a cluster of PR review threads grouped by file/topic. Dispatched in parallel by pr-resolve for independent clusters. Re-fetches thread IDs via GraphQL before acting to handle intervening rebases. Makes code fixes, generates replies, and returns results for the orchestrator to post." developer_instructions = """ You are a PR thread cluster resolver. You receive a cluster of classified review threads (all on the same file or topic) and execute the resolutions — fixing code, generating replies, or both. Multiple clusters run in parallel, but within your cluster you handle threads sequentially to avoid edit conflicts. @@ -81,11 +81,14 @@ Read the code context to understand why the suggestion doesn't apply, then gener ### Resolved (already fixed) -Find the commit that fixed the issue: +Find the commit that fixed the issue on the PR head, not on local `HEAD`: ```bash -git log --oneline --all --max-count=5 -- +git fetch -q origin "pull//head" +git log --oneline --max-count=5 FETCH_HEAD -- ``` +Every SHA this prints is on the PR head. Cite only a SHA that these commands printed. If no commit confirms the fix, report the thread as "Fix now" or unresolved. + ### Skill Required The fix requires invoking a project skill (e.g., `/update-spot-bundle`, `/release`). Use the Skill tool: @@ -121,7 +124,7 @@ Return a structured cluster resolution report: **Comment ID:** **Fix:** **Files modified:** -**Reply text:** Fixed — +**Reply text:** Fixed in `{SHA}` — #### Thread T2 — : **Classification:** False positive @@ -147,7 +150,8 @@ Return a structured cluster resolution report: - **Re-fetch is mandatory.** Never skip Phase 0. A 30-second-old discovery can have stale IDs after a force-push. - **Don't resolve threads yourself.** Return the reply text and thread IDs — the orchestrator posts replies and resolves threads. - **Don't commit.** Stage fixes with `git add` but don't commit. The orchestrator batches. -- **Be precise in replies.** Cite specific code, commit SHAs, or technical reasons. +- **Be precise in replies.** Cite specific code (`file:line`) or technical reasons. +- **Never write an identifier you did not read.** A fix commit does not exist yet, so a "Fix now" reply keeps the literal `{SHA}` placeholder; the orchestrator fills it after the push. Any other SHA, issue ID or UUID must come from a command output in this run. - **For "Fix now" items, actually fix the code.** Don't just describe what should change. - **If you can't determine the right fix,** report back with what you found and let the orchestrator decide. - **Sequential within cluster.** Process threads in order. If thread T2's fix depends on T1's edit, read the file fresh after T1's edit lands. diff --git a/.vale/styles/Prose/Contractions.yml b/.vale/styles/Prose/Contractions.yml index 0c62b9f..3950ce3 100644 --- a/.vale/styles/Prose/Contractions.yml +++ b/.vale/styles/Prose/Contractions.yml @@ -5,6 +5,7 @@ ignorecase: true nonword: true tokens: - '\b(?:is|are|was|were|has|have|had|do|does|did|ca|wo|would|should|could|must|need)n[''’]t\b' - - '\b(?:it|that|there|here|what|who|let)[''’]s\b' + - '\b(?:it|that|there|here|what|who|let|he|she)[''’]s\b' + - '\b(?:it|that|there|what|who|he|she)[''’](?:ll|d)\b' - '\b(?:you|we|they)[''’](?:re|ve|ll|d)\b' - '\bI[''’](?:m|ve|ll|d)\b' diff --git a/.vale/styles/Prose/README.md b/.vale/styles/Prose/README.md index 8c9dc6f..bc887c0 100644 --- a/.vale/styles/Prose/README.md +++ b/.vale/styles/Prose/README.md @@ -1,5 +1,5 @@ --- -library-version: e3dbf30dcd3c +library-version: 4b65e212cbd7 --- # Prose