From d4179d25e0be700fc78edc147612685a3c7eec64 Mon Sep 17 00:00:00 2001 From: chrisnojima Date: Thu, 24 Sep 2026 09:43:57 -0400 Subject: [PATCH 1/2] fix(protocol): drop reachabilityChanged from enabled incoming calls The JS side stopped handling it in #29675, but only the generated index.tsx was edited, so CI's regen put the union member back. --- protocol/bin/enabled-calls.json | 1 - 1 file changed, 1 deletion(-) diff --git a/protocol/bin/enabled-calls.json b/protocol/bin/enabled-calls.json index 35ebd092896e..71762984e8a8 100644 --- a/protocol/bin/enabled-calls.json +++ b/protocol/bin/enabled-calls.json @@ -390,7 +390,6 @@ "keybase.1.provisionUi.chooseGPGMethod": {"custom":true}, "keybase.1.provisionUi.switchToGPGSignOK": {"custom":true}, "keybase.1.reachability.checkReachability": {"promise":true}, - "keybase.1.reachability.reachabilityChanged": {"incoming":true}, "keybase.1.reachability.startReachability": {"promise":true}, "keybase.1.rekey.getRevokeWarning": {"promise":true}, "keybase.1.rekey.rekeyStatusFinish": {"promise":true}, From e257efea9d89ce449c23efc16cc482f6ae4535ff Mon Sep 17 00:00:00 2001 From: chrisnojima Date: Thu, 24 Sep 2026 09:45:22 -0400 Subject: [PATCH 2/2] docs(claude): skip /code-review for trivial diffs --- CLAUDE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CLAUDE.md b/CLAUDE.md index 7e9338093dc0..aab5c087b2a1 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -27,4 +27,4 @@ Repo root is `client/`. TS source lives in `shared/`. Always use absolute paths ## Validation After TS changes (from `shared/`): `yarn lint:all` (= `yarn lint` && `yarn lint:bailouts` && `yarn tsc`). Plain `yarn lint` is eslint only and does NOT catch react-compiler bailouts — no compiler rule is wired into `eslint.config.mjs`, so bailouts only surface via `lint:bailouts`. `lint:bailouts` also flags components the compiler cannot name (an `isMobile ? arrow : arrow` ternary is never compiled at all, so nothing in it is memoized — name both branches instead), and memo scopes keyed on the whole props object (a `props.x` read inside a callback, or a destructure below one, makes the compiler key on `props` itself, so the cache never hits — read every prop through one destructure at the top, above every callback). Repo baseline is 0 bailouts and 0 whole-props deps; keep it there. When debugging visually, skip until fix is confirmed. Never delete the ESLint cache. -Before reporting any TS change complete: run `yarn lint:all` and get it clean. Do NOT run `/code-review` while iterating, building, testing, or debugging — only once the change is about to be pushed (commit for a PR, push, or open a PR). At that point run `/code-review high` against the diff and fix what it finds; if a finding is wrong, say why instead of applying it. +Before reporting any TS change complete: run `yarn lint:all` and get it clean. Do NOT run `/code-review` while iterating, building, testing, or debugging — only once the change is about to be pushed (commit for a PR, push, or open a PR). At that point, if the diff has real logic in it, run `/code-review high` against the diff and fix what it finds; if a finding is wrong, say why instead of applying it. Skip the review for trivial diffs (a config/JSON line, a codegen resync, a typo) and say you skipped it.