chore: adopt StandardRB + autofix violations

Author: ronaldtse

.github/workflows/test.yml

@@ -21,3 +21,13 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
       - run: bundle exec rspec
+
+  standard:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.4"
+          bundler-cache: true
+      - run: bundle exec standardrb

.standard.yml

@@ -0,0 +1,3 @@
+ignore:
+  - "vendor/**/*"
+  - "tmp/**/*"

Gemfile

@@ -15,4 +15,5 @@ gem "rababa", "~> 0.1.1"
 group :development, :test do
   gem "rake"
   gem "rspec", "~> 3.13"
+  gem "standard", require: false
 end

Rakefile

@@ -1,6 +1,6 @@
 require "bundler/setup"
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

lib/interscript-api/graphql/types/query_type.rb

@@ -4,7 +4,7 @@
 require "interscript"
 require "interscript/compiler/ruby"
 
-require 'pathname' unless ENV["AWS_EXECUTION_ENV"].nil?
+require "pathname" unless ENV["AWS_EXECUTION_ENV"].nil?
 
 class DetectionResultType < GraphQL::Schema::Object
   field :map_name, String, null: false
@@ -37,43 +37,40 @@ def transliterate(system_code:, input:)
       raise StandardError.new("{input} string too long")
     end
 
-    rs = Interscript.transliterate(
+    Interscript.transliterate(
       system_code,
       input.dup,
       @cache ||= {},
       compiler: Interscript::Compiler::Ruby
     )
-    rs
   end
 
   field :detect, [DetectionResultType], null: true do
     description "Detect which transliteration system was used for #input to generate #output"
     argument :input, String, required: true
     argument :output, String, required: true
 
-    argument :map_pattern, String, required: false, default_value: '*'
+    argument :map_pattern, String, required: false, default_value: "*"
   end
 
   def detect(input:, output:, map_pattern: "*")
-    rs = Interscript.detect(
+    Interscript.detect(
       input,
       output,
       compiler: Interscript::Compiler::Ruby,
       multiple: true,
       cache: @cache ||= {},
       map_pattern: map_pattern
     ).map do |map_name, distance|
-      { map_name: map_name, distance: distance }
+      {map_name: map_name, distance: distance}
     end
-
-    rs
   end
 
   def info
     JSON.generate({
-                    version: InterscriptApi::VERSION,
-                    interscript_version: Interscript::VERSION,
-                  })
+      version: InterscriptApi::VERSION,
+      interscript_version: Interscript::VERSION
+    })
   end
 
   # def limits
@@ -84,5 +81,3 @@ def system_codes
     Interscript.maps
   end
 end
-
-

lib/interscript-api/lambda_function.rb

@@ -4,50 +4,50 @@
 
 def handler(event:, context: {})
   cors_origin = ENV["DEFAULT_ORIGIN"]
-  input_origin = event.fetch('headers', {}).fetch('origin', "")
+  input_origin = event.fetch("headers", {}).fetch("origin", "")
 
-  if /#{ENV["CORS_ORIGIN_REGEX"]}/ =~ input_origin
-    puts 'match origin'
+  if /#{ENV["CORS_ORIGIN_REGEX"]}/.match?(input_origin)
+    puts "match origin"
     cors_origin = input_origin
   end
 
   headers = {
     "Access-Control-Allow-Origin" => cors_origin,
-    "Access-Control-Allow-Headers"=> 'Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token',
-    "Access-Control-Allow-Methods"=> "POST, OPTIONS"
+    "Access-Control-Allow-Headers" => "Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token",
+    "Access-Control-Allow-Methods" => "POST, OPTIONS"
   }
 
-  body = event['body']
-  if "OPTIONS".casecmp?(event['httpMethod']) || body.nil? || body.empty?
+  body = event["body"]
+  if "OPTIONS".casecmp?(event["httpMethod"]) || body.nil? || body.empty?
     return {
       statusCode: 200,
-      headers: headers,
+      headers: headers
     }
   end
 
   query = begin
-            JSON.parse(body)["query"]
-          rescue JSON::ParserError
-            body
-          end
+    JSON.parse(body)["query"]
+  rescue JSON::ParserError
+    body
+  end
 
   status_code = begin
-                  result = InterscriptApi::Schema.execute(query).to_json
-                  200
-                rescue StandardError => e
-                  result = e.message
-                  puts result
-                  400
-                rescue => e
-                  puts e
-                  puts "Catch Error"
-                end
+    result = InterscriptApi::Schema.execute(query).to_json
+    200
+  rescue => e
+    result = e.message
+    puts result
+    400
+  rescue => e
+    puts e
+    puts "Catch Error"
+  end
 
   begin
     result_json = JSON.parse result
     status_code = 400 if result_json.key?("errors")
   rescue JSON::ParserError
-    #ignore
+    # ignore
   end
 
   {

lib/limits.rb

@@ -2,7 +2,7 @@ module InterscriptApi
   LIMITS = {
     # timeout_millis: 10,
 
-    #1k input length
-    input_max_size: 1_000_000,
+    # 1k input length
+    input_max_size: 1_000_000
   }.freeze
 end

spec/interscript-api/lambda_function_spec.rb

@@ -2,9 +2,7 @@
 require "json"
 
 describe InterscriptApi do
-
   context "With valid input" do
-
     it "should return valid data when transliterate is called" do
       event = {
         "body" => '{transliterate(systemCode: "odni-rus-Cyrl-Latn-2015", input: "Михаил Тимофеевич Калашников")}'
@@ -34,9 +32,9 @@
     end
 
     it "should print system_codes" do
-      ENV['INTERSCRIPT_STAGING'] = '1'
+      ENV["INTERSCRIPT_STAGING"] = "1"
       event = {
-        "body" => '{systemCodes}'
+        "body" => "{systemCodes}"
       }
       rs = handler(event: event)
       rs = JSON.parse(rs[:body])["data"].to_h
@@ -59,7 +57,6 @@
 
       rs = /#{cors_origin}/ =~ "https://localhost:3001"
       expect(rs).to be_truthy
-
     end
   end
 end

spec/spec_helper.rb

@@ -44,57 +44,55 @@
   # triggering implicit auto-inclusion in groups with matching metadata.
   config.shared_context_metadata_behavior = :apply_to_host_groups
 
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # This allows you to limit a spec run to individual examples or groups
-  # you care about by tagging them with `:focus` metadata. When nothing
-  # is tagged with `:focus`, all examples get run. RSpec also provides
-  # aliases for `it`, `describe`, and `context` that include `:focus`
-  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
-  config.filter_run_when_matching :focus
-
-  # Allows RSpec to persist some state between runs in order to support
-  # the `--only-failures` and `--next-failure` CLI options. We recommend
-  # you configure your source control system to ignore this file.
-  config.example_status_persistence_file_path = "spec/examples.txt"
-
-  # Limits the available syntax to the non-monkey patched syntax that is
-  # recommended. For more details, see:
-  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
-  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
-  config.disable_monkey_patching!
-
-  # This setting enables warnings. It's recommended, but in some cases may
-  # be too noisy due to issues in dependencies.
-  config.warnings = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = "doc"
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
+  # The settings below are suggested to provide a good initial experience
+  # with RSpec, but feel free to customize to your heart's content.
+  #   # This allows you to limit a spec run to individual examples or groups
+  #   # you care about by tagging them with `:focus` metadata. When nothing
+  #   # is tagged with `:focus`, all examples get run. RSpec also provides
+  #   # aliases for `it`, `describe`, and `context` that include `:focus`
+  #   # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  #   config.filter_run_when_matching :focus
+  #
+  #   # Allows RSpec to persist some state between runs in order to support
+  #   # the `--only-failures` and `--next-failure` CLI options. We recommend
+  #   # you configure your source control system to ignore this file.
+  #   config.example_status_persistence_file_path = "spec/examples.txt"
+  #
+  #   # Limits the available syntax to the non-monkey patched syntax that is
+  #   # recommended. For more details, see:
+  #   #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  #   config.disable_monkey_patching!
+  #
+  #   # This setting enables warnings. It's recommended, but in some cases may
+  #   # be too noisy due to issues in dependencies.
+  #   config.warnings = true
+  #
+  #   # Many RSpec users commonly either run the entire suite or an individual
+  #   # file, and it's useful to allow more verbose output when running an
+  #   # individual spec file.
+  #   if config.files_to_run.one?
+  #     # Use the documentation formatter for detailed output,
+  #     # unless a formatter has already been configured
+  #     # (e.g. via a command-line flag).
+  #     config.default_formatter = "doc"
+  #   end
+  #
+  #   # Print the 10 slowest examples and example groups at the
+  #   # end of the spec run, to help surface which specs are running
+  #   # particularly slow.
+  #   config.profile_examples = 10
+  #
+  #   # Run specs in random order to surface order dependencies. If you find an
+  #   # order dependency and want to debug it, you can fix the order by providing
+  #   # the seed, which is printed after each run.
+  #   #     --seed 1234
+  #   config.order = :random
+  #
+  #   # Seed global randomization in this process using the `--seed` CLI option.
+  #   # Setting this allows you to use `--seed` to deterministically reproduce
+  #   # test failures related to randomization by passing the same `--seed` value
+  #   # as the one that triggered the failure.
+  #   Kernel.srand config.seed
 end