You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9986ca4
Browse filesBrowse the repository at this point in the historyBrowse files
fix(abi): repair the Idris2 proofs and record proof status against the policy (#277)
I re-checked panic-attack's Idris2 proofs with Idris2 0.7.0, the version
`proven-tests.yml` pins. No CI job type-checks `src/abi/`, so the ✅
marks in `PROOF-NEEDS.adoc` had no receipt behind them.
## What the check found on `main`
| Module | Result on `main` | Design |
|---|---|---|
| `ClassificationSoundness.idr` (PA2) | passes | Sound and non-trivial
for its model |
| `AttestationUnforgeability.idr` | passes | Sound relative to its
hypotheses. Two of them are symbolic-model idealisations, and the header
overstated them as EUF-CMA and collision resistance. |
| `PatternCompleteness.idr` (PA1) | passes | **Vacuous**:
`GenericAnalyzer : HasAnalyzer lang` inhabits every language. The model
is also stale (see below). |
| `Stripping.idr` | **does not compile** | The theorem is true, but the
proof had two type errors, hidden behind a parse error. |
| `Types.idr` | **does not compile** | No theorems, despite a header
claiming three |
PA1's staleness: its `Lang` has 50 languages against 52 in Rust, missing
`C` and `Php`. `crossLangAlwaysApplied` also says cross-language checks
run on every file, but the Rust code now skips them for configuration
files.
## Commits
1. **`3dc4728` fix(abi): make the Stripping and Types Idris2 modules
type-check**
- **`Stripping.idr`:** matching on a `Char` literal only reduces when
the character is a literal, so the proof stuck on a variable head. The
model now classifies each character once (`Slash`, `Newline`, `Other`)
and steps on the class, and each proof carries `cls c = k`.
- The theorem statements are unchanged.
- All seven sanity checks are unchanged and pass.
- The new model equals the old one on all 349,525 strings of length ≤ 9
over `/`, newline, `x` and space.
- **`Types.idr`:** syntax-only fixes. Its header now says it declares
types only, and notes its drift from `src/types.rs`.
2. **`b1b1419` docs(proofs): record proof status against the estate
proof policy**
- `PROOF-NEEDS.adoc` now uses the proof policy's §5 tokens and §1.2
verifier mapping, pinned to `metadatastician/standards` `9bdf864`.
- It records a receipt for the Idris2 check and an honest status per
obligation.
- The implementation obligations are listed as `OPEN` for
Creusot/Pearlite and Verus: stripping, Patch Bridge reachability and
taint analysis.
## Verification
- All five `src/abi` modules type-check. The pass criterion is exit 0
and no `Error:` line; `idris2 --check` can exit 0 while printing an
error.
- **Negative controls:** a planted false lemma and a planted
non-terminating definition are both rejected.
- **No escape hatches:** every module sets `%default total` and uses
none of `believe_me`, `assert_total`, `postulate` or holes. The one
`believe_me` match is in a doc comment that bans it.
- **Kani note:** `cargo clippy --lib --bins --tests --benches
--all-features -- -F unsafe_code` compiles. The only `unsafe` is in
`examples/vulnerable_program.rs`, a deliberately buggy scan target.
- `PROOF-NEEDS.adoc` renders with Asciidoctor at `--failure-level WARN`.
## Not in this PR
- **CI gate for `src/abi`:** the modules are named `PanicAttack.ABI.*`
but live in `src/abi/`, so a plain `idris2 --check src/abi/X.idr` fails
on the module name. The status file records the gate as `OPEN`, with the
invocation to use.
- **PA1's redesign or retirement:** recorded as `OPEN`.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01Jma5ixtpeZyJRmfoSsC98u)_
---------
Co-authored-by: Claude <noreply@anthropic.com>
0 commit comments