From 55bddf4458f121eefb9303136a08111ed6aca1ce Mon Sep 17 00:00:00 2001
From: "Jonathan D.A. Jewell" <6759885+hyperpolymath@users.noreply.github.com>
Date: Wed, 26 Aug 2026 18:23:06 +0100
Subject: [PATCH] fix(uninstall): redirect is not valid on a for-list
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Line 469 wrote 'for item in $cache_path 2>/dev/null; do'. A redirection cannot be applied to a for-list, so the file did not parse. Removed the redirect; the guard inside the loop already handles a missing path.

Found by an estate-wide shellcheck sweep of 5,111 tracked scripts across 375
repos. This file was one of 11 that fail to PARSE (SC1073/SC1072) — shellcheck
stops analysing at the failure, so anything after it was never checked either.

Verified: shellcheck -S error now reports 0 findings for this file.
---
 scripts/management/uninstall.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/management/uninstall.sh b/scripts/management/uninstall.sh
index 07403f80..19326ea0 100755
--- a/scripts/management/uninstall.sh
+++ b/scripts/management/uninstall.sh
@@ -466,7 +466,7 @@ cleanup_cache() {
     for cache_path in "${cache_locations[@]}"; do
         if [[ "$cache_path" == *"*"* ]]; then
             # Glob pattern
-            for item in $cache_path 2>/dev/null; do
+            for item in $cache_path; do
                 if [[ -e "$item" ]]; then
                     log INFO "Removing: $item"