From 4664d135404a042e81eccd09246fa63ddb1b2472 Mon Sep 17 00:00:00 2001 From: Zhao Jiale Date: Wed, 18 Nov 2026 14:41:15 +0800 Subject: [PATCH] Fix ASC reader dropping first frame after header comments Preserve the file position for a first data line encountered while parsing ASC header metadata so __iter__ processes it instead of consuming it. Add a regression test with CANoe-style version comments. --- can/io/asc.py | 9 ++++++++- test/logformats_test.py | 21 +++++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/can/io/asc.py b/can/io/asc.py index be1e05b05..75408dc82 100644 --- a/can/io/asc.py +++ b/can/io/asc.py @@ -80,7 +80,11 @@ def __init__( self.internal_events_logged = False def _extract_header(self) -> None: - for _line in self.file: + while True: + position = self.file.tell() + _line = self.file.readline() + if not _line: + break line = _line.strip() datetime_match = re.match( @@ -121,6 +125,9 @@ def _extract_header(self) -> None: self.internal_events_logged = events_match.group("no_events") is None break + # The first data line can immediately follow a header comment. + # Rewind so __iter__ parses it instead of consuming and discarding it. + self.file.seek(position) break @staticmethod diff --git a/test/logformats_test.py b/test/logformats_test.py index beb5b7b9f..0419a52e1 100644 --- a/test/logformats_test.py +++ b/test/logformats_test.py @@ -607,6 +607,27 @@ def test_read_can_and_canfd_error_frames(self): def test_read_ignore_comments(self): _msg_list = self._read_log_file("logfile.asc") + def test_first_message_after_header_comment_is_not_dropped(self): + content = ( + "date Mon Oct 12 06:42:09 PM 2026\n" + "base hex timestamps absolute\n" + "// version 7.0.0\n" + "0.000000 1 123 Rx d 8 01 02 03 04 05 06 07 08\n" + ) + with tempfile.NamedTemporaryFile("w", suffix=".asc", delete=False) as logfile: + logfile.write(content) + logfile_name = logfile.name + + try: + with can.ASCReader(logfile_name) as reader: + messages = list(reader) + finally: + os.unlink(logfile_name) + + self.assertEqual(len(messages), 1) + self.assertEqual(messages[0].arbitration_id, 0x123) + self.assertEqual(messages[0].data, b"\x01\x02\x03\x04\x05\x06\x07\x08") + def test_read_no_triggerblock(self): _msg_list = self._read_log_file("issue_1256.asc")