From a576a0bbf49b3f5760eedccad260784d569ae222 Mon Sep 17 00:00:00 2001 From: duncan485 Date: Fri, 28 Aug 2026 11:23:08 +0200 Subject: [PATCH 1/3] kubernetes-ingress: add activeDeadlineSeconds to crdjob configuration --- kubernetes-ingress/templates/controller-crdjob.yaml | 3 +++ kubernetes-ingress/values.yaml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/kubernetes-ingress/templates/controller-crdjob.yaml b/kubernetes-ingress/templates/controller-crdjob.yaml index f04c89c..2205d3f 100644 --- a/kubernetes-ingress/templates/controller-crdjob.yaml +++ b/kubernetes-ingress/templates/controller-crdjob.yaml @@ -32,6 +32,9 @@ metadata: spec: {{- if .Values.crdjob.ttlSecondsAfterFinished }} ttlSecondsAfterFinished: {{ .Values.crdjob.ttlSecondsAfterFinished }} +{{- end }} +{{- if .Values.crdjob.activeDeadlineSeconds }} + activeDeadlineSeconds: {{ .Values.crdjob.activeDeadlineSeconds }} {{- end }} backoffLimit: 0 template: diff --git a/kubernetes-ingress/values.yaml b/kubernetes-ingress/values.yaml index b5f11a0..1dfec22 100644 --- a/kubernetes-ingress/values.yaml +++ b/kubernetes-ingress/values.yaml @@ -710,6 +710,9 @@ crdjob: ## ref: https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/ ttlSecondsAfterFinished: 600 + ## Specifies the duration in seconds relative to the startTime that the job maybe continuously active before the system tries to terminate it + activeDeadlineSeconds: + ## Pod Node assignment ## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/ nodeSelector: {} From 2620db941ada57aeee0fe936231c4862bbe2082f Mon Sep 17 00:00:00 2001 From: Dinko Korunic Date: Fri, 28 Aug 2026 16:48:54 +0200 Subject: [PATCH 2/3] BUILD/MINOR: kubernetes-ingress: fix trailing whitespace in crdjob values The activeDeadlineSeconds key was added with a trailing space, which yamllint rejects through the trailing-spaces rule enabled in both test/lintconf.yaml and chart-testing's default lintconf. This made "ct lint" fail on the chart, blocking the lint-charts CI job as well as the install-charts and release-charts jobs that depend on it. No functional change, the rendered chart is identical. Signed-off-by: Dinko Korunic --- kubernetes-ingress/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kubernetes-ingress/values.yaml b/kubernetes-ingress/values.yaml index 1dfec22..6f5f2af 100644 --- a/kubernetes-ingress/values.yaml +++ b/kubernetes-ingress/values.yaml @@ -711,7 +711,7 @@ crdjob: ttlSecondsAfterFinished: 600 ## Specifies the duration in seconds relative to the startTime that the job maybe continuously active before the system tries to terminate it - activeDeadlineSeconds: + activeDeadlineSeconds: ## Pod Node assignment ## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/ From 76b836a534ecd7a73a5a03857d351663e84f6793 Mon Sep 17 00:00:00 2001 From: Dinko Korunic Date: Fri, 28 Aug 2026 16:49:04 +0200 Subject: [PATCH 3/3] DOC/MINOR: kubernetes-ingress: document crdjob.activeDeadlineSeconds The new crdjob.activeDeadlineSeconds value was missing from the "CRD installation job" table in README.md, which is what Artifact Hub renders, leaving the setting undiscoverable while every other crdjob key is listed there. Add the missing row, fix the "maybe"/"may be" typo in the values.yaml comment and add the usual "## ref:" link to the upstream Job documentation so the entry matches its neighbours. Signed-off-by: Dinko Korunic --- kubernetes-ingress/README.md | 1 + kubernetes-ingress/values.yaml | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/kubernetes-ingress/README.md b/kubernetes-ingress/README.md index ff1bff3..b9b36cd 100644 --- a/kubernetes-ingress/README.md +++ b/kubernetes-ingress/README.md @@ -509,6 +509,7 @@ A Helm `post-install` / `pre-upgrade` hook Job that applies the controller's CRD |---|---|---| | `crdjob.podAnnotations` | Annotations on the Job pod. | `{}` | | `crdjob.ttlSecondsAfterFinished` | Seconds after which the Job is garbage-collected. | `600` | +| `crdjob.activeDeadlineSeconds` | Seconds the Job may stay active before Kubernetes terminates it and marks it `DeadlineExceeded`. Omitted when unset, so the Job runs without a deadline. | _unset_ | | `crdjob.nodeSelector` / `.tolerations` / `.affinity` | Scheduling controls for the Job pod. | `{}` / `[]` / `{}` | | `crdjob.resources.requests` / `.limits` | CPU/memory requests and (optional) limits for the Job container. | `cpu: 250m`, `memory: 400Mi` (no limits) | diff --git a/kubernetes-ingress/values.yaml b/kubernetes-ingress/values.yaml index 6f5f2af..bc96822 100644 --- a/kubernetes-ingress/values.yaml +++ b/kubernetes-ingress/values.yaml @@ -710,7 +710,8 @@ crdjob: ## ref: https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/ ttlSecondsAfterFinished: 600 - ## Specifies the duration in seconds relative to the startTime that the job maybe continuously active before the system tries to terminate it + ## Duration in seconds relative to the startTime that the job may be continuously active before the system tries to terminate it + ## ref: https://kubernetes.io/docs/concepts/workloads/controllers/job/#job-termination-and-cleanup activeDeadlineSeconds: ## Pod Node assignment