From 7827e87e401a564c4468290395b0af8f050fa75c Mon Sep 17 00:00:00 2001 From: Sylvie Paindeville Date: Tue, 10 Nov 2026 08:36:59 +0100 Subject: [PATCH] HCK-18624: Do not generate SET DEFAULT when the default value is unchanged The filter treated a falsy old default (false, 0, empty string) as missing, so an unchanged default was generated again as ALTER COLUMN SET DEFAULT. This happens in forward-engineering for any column with a comment, because column comments go through the ALTER script path. Co-Authored-By: Claude Opus 5.5 --- .../alterScriptHelpers/columnHelpers/defaultValueHelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/forward_engineering/alterScript/alterScriptHelpers/columnHelpers/defaultValueHelper.js b/forward_engineering/alterScript/alterScriptHelpers/columnHelpers/defaultValueHelper.js index 11d74b2..6668652 100644 --- a/forward_engineering/alterScript/alterScriptHelpers/columnHelpers/defaultValueHelper.js +++ b/forward_engineering/alterScript/alterScriptHelpers/columnHelpers/defaultValueHelper.js @@ -41,7 +41,7 @@ const getUpdatedDefaultColumnValueScriptDtos = ({ collection }) => { const newDefault = jsonSchema.default; const oldName = jsonSchema.compMod.oldField.name; const oldDefault = collection.role.properties[oldName]?.default; - return newDefault !== undefined && (!oldDefault || newDefault !== oldDefault); + return newDefault !== undefined && newDefault !== oldDefault; }) .map(([columnName, jsonSchema]) => { const newDefaultValue = jsonSchema.default;