From f35a0b0386e5bd4f2142fca86a1bdd507ae47e27 Mon Sep 17 00:00:00 2001 From: Chris Wessels Date: Thu, 29 Oct 2026 09:28:15 +0000 Subject: [PATCH] fix(performance): update both feedback buffers --- src/indexing_performance.rs | 47 ++++++++++++++++++++++++++++++++++--- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/src/indexing_performance.rs b/src/indexing_performance.rs index 9f9e48aa8..eb93e79b2 100644 --- a/src/indexing_performance.rs +++ b/src/indexing_performance.rs @@ -107,13 +107,13 @@ impl Actor { fn handle_msgs(&mut self, msgs: &mut Vec) { for unlocked in &self.data.0 { let mut locked = unlocked.write(); - for Feedback { + for &Feedback { indexer, deployment, success, latency_ms, latest_block, - } in msgs.drain(..) + } in msgs.iter() { let snapshot = locked.entry((indexer, deployment)).or_default(); snapshot.response.feedback(success, latency_ms); @@ -124,7 +124,7 @@ impl Actor { }; } } - debug_assert!(msgs.is_empty()); + msgs.clear(); } fn handle_network(&mut self, network: &NetworkService) { @@ -142,3 +142,44 @@ impl Actor { } } } + +#[cfg(test)] +mod feedback_tests { + use super::*; + + #[test] + fn completed_feedback_is_visible_through_either_buffer() { + let data = Box::leak(Box::new(DoubleBuffer::default())); + let (msgs, _rx) = mpsc::unbounded_channel(); + let performance = IndexingPerformance { data, msgs }; + let mut actor = Actor { data }; + let indexer = thegraph_core::alloy::primitives::Address::ZERO.into(); + let deployment = [0; 32].into(); + let mut expected = indexer_selection::Performance::default(); + for (success, latency_ms, latest_block) in [(true, 250, Some(100)), (false, 900, Some(90))] + { + expected.feedback(success, latency_ms); + let mut batch = vec![Feedback { + indexer, + deployment, + success, + latency_ms, + latest_block, + }]; + actor.handle_msgs(&mut batch); + assert!(batch.is_empty()); + for blocked in 0..2 { + let _guard = data.0[blocked].write(); + let snapshot = performance.latest(); + let snapshot = snapshot + .get(&(indexer, deployment)) + .expect("feedback snapshot"); + assert_eq!(snapshot.latest_block, Some(100)); + let actual = snapshot.response.expected_performance(); + let expected = expected.expected_performance(); + assert_eq!(actual.latency_ms, expected.latency_ms); + assert_eq!(actual.success_rate, expected.success_rate); + } + } + } +}