From c2ecc8c1dbd568091b8a51776f3fbea33c4abf2e Mon Sep 17 00:00:00 2001 From: tannevaled Date: Mon, 24 Aug 2026 00:59:17 +0200 Subject: [PATCH] Give the emulated lanes a wall they are not already touching MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The nightly on main died with panic: test timed out after 30m0s running tests: TestStringToIBase (0s) and no failing test: the s390x lane hit the 30-minute wall at 1801.594s. The wall here is not a hang detector. qemu-user is 50-100x slower than native, so it is the only thing deciding whether a slow-but-correct run counts, and it has to sit well clear of what the run actually takes. Measured on internal/vm, the heaviest package, in run 32661057000 — the verification run, all four green: loong64 990s riscv64 1204s ppc64le 1284s s390x 1754s <- 46s under an 1800s wall A 2.6% margin, which ordinary runner variance crosses, and the very next run of that same tree crossed it. So the red was the wall rather than the code: nothing about the three fixes that landed today is implicated, and the three arches that were never near the wall stayed green. 60m puts s390x at about half of it, which is what the comment above the line already claimed. The numbers are in the comment now, so the next person to look does not have to measure them again to know how much room there is. Co-Authored-By: Claude Opus 5 --- .github/workflows/arch-qemu-nightly.yml | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/.github/workflows/arch-qemu-nightly.yml b/.github/workflows/arch-qemu-nightly.yml index 638147fc..df5c22ff 100644 --- a/.github/workflows/arch-qemu-nightly.yml +++ b/.github/workflows/arch-qemu-nightly.yml @@ -46,9 +46,18 @@ jobs: go-version: stable - run: sudo apt-get update && sudo apt-get install -y qemu-user-static - name: Test under qemu (${{ matrix.goarch }}) - # qemu-user emulation is ~50-100x slower than native; the heaviest lane - # (s390x, the slowest target) can exceed Go's default 10m test-binary - # timeout on the full vm suite. Give the emulated lanes generous headroom - # so a slow-but-correct run isn't killed as a false failure. (On real - # s390x silicon the same suite runs natively in seconds.) - run: GOARCH=${{ matrix.goarch }} go test -timeout=30m -exec=${{ matrix.qemu }} ./... + # qemu-user emulation is ~50-100x slower than native, so the wall here is + # not a hang detector: it is the only thing that decides whether a + # slow-but-correct run counts. It has to sit well clear of what the run + # actually takes, and 30m did not. Measured on internal/vm, the heaviest + # package, in run 32661057000 (all four green): + # + # loong64 990s riscv64 1204s + # ppc64le 1284s s390x 1754s <- 46s under a 1800s wall + # + # The very next run of the same tree died at 1801.594s with + # "panic: test timed out after 30m0s" and no failing test — a 2.6% + # margin, which ordinary runner variance crosses. 60m puts s390x at + # about half the wall, which is what "generous headroom" was meant to + # say. (On real s390x silicon the same suite runs natively in seconds.) + run: GOARCH=${{ matrix.goarch }} go test -timeout=60m -exec=${{ matrix.qemu }} ./...