From d545d7033ef9ba92b49f5646556f2516efaa5d8a Mon Sep 17 00:00:00 2001 From: tannevaled Date: Sun, 23 Aug 2026 21:07:50 +0200 Subject: [PATCH] Implement top-level define_method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit At the top level `define_method` raised NoMethodError, because `main` had no such method. main's singleton class now gets `define_method`, forwarding to Object's Module method (Object is the top-level default definee): define_method(:m){…} defines Object#m and returns the method name. Verified against ruby 4.0.6; core/main/define_method_spec now passes 3/3. Co-Authored-By: Claude Opus 4.8 --- internal/vm/modulefunc.go | 7 ++++++ .../toplevel_define_method_internal_test.go | 23 +++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 internal/vm/toplevel_define_method_internal_test.go diff --git a/internal/vm/modulefunc.go b/internal/vm/modulefunc.go index eb587b61..f067f6a7 100644 --- a/internal/vm/modulefunc.go +++ b/internal/vm/modulefunc.go @@ -101,6 +101,13 @@ func (vm *VM) registerModuleExtras() { return setVis(vm, vm.cObject, args, vis) }} } + // Top-level define_method also operates on Object, the default definee: + // `define_method(:m){…}` defines Object#m by forwarding to the Module + // method on Object. + sc.methods["define_method"] = &Method{name: "define_method", owner: sc, + native: func(vm *VM, _ object.Value, args []object.Value, blk *Proc) object.Value { + return vm.send(vm.cObject, "define_method", args, blk) + }} } // private_class_method / public_class_method: set the named class methods' diff --git a/internal/vm/toplevel_define_method_internal_test.go b/internal/vm/toplevel_define_method_internal_test.go new file mode 100644 index 00000000..ba7302f9 --- /dev/null +++ b/internal/vm/toplevel_define_method_internal_test.go @@ -0,0 +1,23 @@ +// Copyright (c) the go-embedded-ruby/ruby authors +// +// SPDX-License-Identifier: BSD-3-Clause + +package vm + +import "testing" + +// TestTopLevelDefineMethod covers the top-level define_method: at the top level +// it operates on Object (the default definee), so define_method(:m){…} defines +// Object#m and returns the method name. Verified against ruby 4.0.6. +func TestTopLevelDefineMethod(t *testing.T) { + cases := []struct{ src, want string }{ + {`define_method(:dm_a) { 42 }; p dm_a`, `42`}, + {`define_method(:dm_b) { |x| x * 2 }; p dm_b(3)`, `6`}, + {`p(define_method(:dm_c) { 1 })`, `:dm_c`}, + } + for _, c := range cases { + if got := eval(t, c.src); got != c.want+"\n" { + t.Errorf("src=%q got=%q want=%q", c.src, got, c.want+"\n") + } + } +}