Repository navigation
Commit 209fa06
docs: SHARED-ENGINES' Net::FTP example described code that has since changed (#926)
The "a deadline belongs to the engine's API" section is the worked example
for the whole shared-engine argument, and it described the binding in the
past tense as having no timeout and no read deadline "anywhere". That was
true when it was written and is not true now: #921 is merged. A reader
arriving at that page would conclude rbgo still has neither.
The argument is unchanged -- an unbounded read in an engine four languages
share is still a shared denial of service, and the neutral engine should
still take a deadline in its own API. What changed is the consumer's half,
so that is what the new subsection records:
- open_timeout (default nil, unbounded) and read_timeout (default 60),
from the options Hash and from the attr writers, with the deadline armed
PER READ. Non-positive means no bound, as in MRI.
- the GVL released around the control connection, plus an AST gate that
refuses a new blocking socket call holding it (#924), with the
dose-response that proved the mechanism.
⛔ And the honest limit, which is the reason the extraction warning STAYS:
the measurement did not move. The library/net-ftp specs are byte-identical
after both changes -- still 39 killed, 459/17, -442. Both fixes are
necessary and proved on a minimal reproduction, but at least one cause
remains and it is in the spec-harness path. The three candidates eliminated
so far are named, with how they were eliminated (by reading, not by timing,
since the machine was too loaded for a timeout to mean anything).
Writing "fixed" here while the number sits where it was is exactly how a
docs page stops being evidence.
Refs #916
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent 0803929 commit 209fa06
1 file changed
Lines changed: 31 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
72 | 101 | | |
73 | 102 | | |
74 | 103 | | |
| |||
0 commit comments