From 5e4b317e143301f91d1a7ee1422b6c89578c8194 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 27 Aug 2026 12:15:13 +0000 Subject: [PATCH 1/2] refactor(ado-proxy): split catalog operations() by capability group Extracts discovery_operations, core_operations, repos_operations, pipelines_operations, and boards_operations from the single operations() function in src/ado_proxy/catalog.rs, which had grown to 391 lines (clippy::too_many_lines). Each helper builds the Operation list for its capability area; operations() now just concatenates them. No behavior change: the returned Vec is identical in content and order. Full test suite (3229 tests) and cargo clippy --all-targets --all-features pass clean. Before: operations() 391/100 (too_many_lines) After: largest helper (repos_operations) 148/100 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/ado_proxy/catalog.rs | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/src/ado_proxy/catalog.rs b/src/ado_proxy/catalog.rs index 576823db..5c603356 100644 --- a/src/ado_proxy/catalog.rs +++ b/src/ado_proxy/catalog.rs @@ -249,6 +249,17 @@ pub fn catalog() -> Catalog { } pub fn operations() -> Vec { + let mut ops = discovery_operations(); + ops.extend(core_operations()); + ops.extend(repos_operations()); + ops.extend(pipelines_operations()); + ops.extend(boards_operations()); + ops +} + +/// Discovery-capability operations: resource-area lookup and connection +/// negotiation performed before any data call. +fn discovery_operations() -> Vec { vec![ Operation { id: "discovery.host-options", @@ -325,6 +336,12 @@ pub fn operations() -> Vec { Json, &["connectOptions", "lastChangeId", "lastChangeId64"] ), + ] +} + +/// Core-capability operations: project lookup and validation. +fn core_operations() -> Vec { + vec![ get!( "core.project-get", Core, @@ -352,6 +369,13 @@ pub fn operations() -> Vec { "getDefaultTeamImageUrl", ] ), + ] +} + +/// Repos-capability operations: repository, ref, commit, and pull-request +/// read routes. +fn repos_operations() -> Vec { + vec![ get!( "repos.repository-get", Repos, @@ -498,6 +522,13 @@ pub fn operations() -> Vec { Json, NO_QUERY ), + ] +} + +/// Pipelines-capability operations: build/pipeline definition, run, and +/// timeline read routes. +fn pipelines_operations() -> Vec { + vec![ get!( "pipelines.definitions-list", Pipelines, @@ -601,6 +632,13 @@ pub fn operations() -> Vec { Json, NO_QUERY ), + ] +} + +/// Boards-capability operations: work-item read, comment, and revision +/// routes. +fn boards_operations() -> Vec { + vec![ get!( "boards.work-item-get", Boards, From 1f5e73b35c7739c2d29148670ae693493b42086e Mon Sep 17 00:00:00 2001 From: Copilot <223556219+Copilot@users.noreply.github.com> Date: Tue, 1 Sep 2026 14:36:16 +0100 Subject: [PATCH 2/2] chore(ci): replace stalled review run Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a791be18-ce7e-40f4-80a1-f03d6eceba6c