Unified: Nested type aliases are static members

Author: hvitved

unified/ql/lib/codeql/unified/internal/NameBindingPlugin.qll

@@ -96,9 +96,9 @@ predicate isInstanceMember(Member member) {
  */
 predicate isStaticMember(Member member) {
   exists(ClassLikeDeclaration cls | cls.getAMember() = member |
-    not any(NameBindingPlugin p).isInstanceMember(cls, member)
-    or
-    member instanceof ConstructorDeclaration
+    not any(NameBindingPlugin p).isInstanceMember(cls, member) or
+    member instanceof ConstructorDeclaration or
+    member instanceof TypeAliasDeclaration
   )
   or
   member = any(TopLevel t).getBody().getAStmt()

unified/ql/test/library-tests/static-name-binding/test.swift

@@ -11,7 +11,7 @@ class A {
 let x1: B = nil  // $ access=top.B
 let x2: A.B = nil  // $ access=A access=A.B
 let x3: A.B.C = nil  // $ access=A access=A.B access=A.B.C
-let x4: A.BAlias.C = nil  // $ access=A $ MISSING: access=A.BAlias access=A.B.C
+let x4: A.BAlias.C = nil  // $ access=A access=A.BAlias access=A.B.C
 
 class D {
     let x1: B = nil  // $ access=top.B