unified: Detect missing handling of ConditionalPattern

ConditionalPattern was not added to getEnclosingOrPattern()
Update the test to detect the bug

Author: asgerf

unified/ql/test/library-tests/variables/test.swift

@@ -348,5 +348,9 @@ func t38(value: E38) {
     case .a(let x), // $ access=x1 // name=x1
          .b(let x): // $ access=x1
         print(x) // $ access=x1
+
+    case .a(let y) where y < 1, // $ access=y1 // name=y1
+         .b(let y): // $ access=y1
+        print(y) // $ access=y1
     }
 }

unified/ql/test/library-tests/variables/variables.expected

@@ -0,0 +1,4 @@
+testFailures
+ambiguousVariable
+| test.swift:352:10:353:17 | y | y | test.swift | 352 |
+| test.swift:352:17:352:17 | y | y | test.swift | 352 |

unified/ql/test/library-tests/variables/variables.ql

@@ -23,8 +23,7 @@ predicate keyValueCommentAt(string filepath, int line, string key, string value)
 module VariableAccessTest implements TestSig {
   string getARelevantTag() { result = "access" }
 
-  private predicate declAt(Variable v, string filepath, int line) {
-    v.getLocation().hasLocationInfo(filepath, _, _, line, _)
+  additional predicate declAt(Variable v, string filepath, int line) {
     v.getLocation().hasLocationInfo(filepath, line, _, _, _)
   }
 
@@ -50,3 +49,13 @@ module VariableAccessTest implements TestSig {
 }
 
 import MakeTest<VariableAccessTest>
+
+private Variable getVariableAt(string name, string filepath, int line) {
+  VariableAccessTest::declAt(result, filepath, line) and
+  result.getName() = name
+}
+
+query predicate ambiguousVariable(Variable v, string name, string filepath, int line) {
+  v = getVariableAt(name, filepath, line) and
+  strictcount(getVariableAt(name, filepath, line)) >= 2
+}