Skip to content

Commit 4cdb612

Browse files
committed
Address pull request comments
1 parent 1d59e69 commit 4cdb612

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,7 @@ private predicate isMicrosoftAspNetCoreMvcAttributeEndpointMapping(MethodCall ca
328328
}
329329

330330
private predicate hasMicrosoftAspNetCoreMvcEndpointMapping(Compilation application, Class controller) {
331+
isInMicrosoftAspNetCoreMvcApplication(controller, application) and
331332
exists(MethodCall mapping |
332333
application.getAFileCompiled() = mapping.getFile() and
333334
(
@@ -360,7 +361,6 @@ private predicate isDefaultMicrosoftAspNetCoreMvcController(Class controller) {
360361
or
361362
exists(Compilation application |
362363
controller.getName().toLowerCase().matches("%controller") and
363-
isInMicrosoftAspNetCoreMvcApplication(controller, application) and
364364
hasMicrosoftAspNetCoreMvcEndpointMapping(application, controller)
365365
)
366366
) and
@@ -410,7 +410,7 @@ class MicrosoftAspNetCoreMvcController extends Class {
410410
not result instanceof DisposeMethod
411411
}
412412

413-
/** Gets a `Redirect*` method. */
413+
/** Gets a `Redirect*`, `Accepted*`, or `Created*` method. */
414414
Method getARedirectMethod() {
415415
result = this.(MicrosoftAspNetCoreMvcControllerHelperClass).getAResponseMethod()
416416
}

0 commit comments

Comments
 (0)