Skip to content

Commit 46fe603

Browse files
committed
C#: Update tests and expected output.
1 parent 453c9de commit 46fe603

3 files changed

Lines changed: 316 additions & 7 deletions

File tree

‎csharp/ql/test/library-tests/dataflow/tuples/DataFlowStep.expected‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,9 @@
187187
| Tuples.cs:103:9:103:22 | ... = ... | Tuples.cs:103:9:103:22 | SSA def(b) |
188188
| Tuples.cs:103:9:103:22 | SSA def(a) | Tuples.cs:104:14:104:14 | access to local variable a |
189189
| Tuples.cs:103:9:103:22 | SSA def(b) | Tuples.cs:105:14:105:14 | access to local variable b |
190+
| Tuples.cs:103:22:103:22 | [deconstruct parameter 0] access to local variable r | Tuples.cs:103:9:103:22 | ... = ... |
191+
| Tuples.cs:103:22:103:22 | [deconstruct parameter 1] access to local variable r | Tuples.cs:103:9:103:22 | ... = ... |
192+
| Tuples.cs:103:22:103:22 | [post] access to local variable r | Tuples.cs:107:17:107:17 | access to local variable r |
190193
| Tuples.cs:103:22:103:22 | access to local variable r | Tuples.cs:103:9:103:18 | (..., ...) |
191194
| Tuples.cs:103:22:103:22 | access to local variable r | Tuples.cs:107:17:107:17 | access to local variable r |
192195
| Tuples.cs:105:14:105:14 | access to local variable b | Tuples.cs:105:14:105:14 | (...) ... |
@@ -306,6 +309,8 @@
306309
| Tuples.cs:180:9:180:24 | ... = ... | Tuples.cs:180:9:180:24 | SSA def(y1) |
307310
| Tuples.cs:180:9:180:24 | SSA def(x1) | Tuples.cs:181:14:181:15 | access to local variable x1 |
308311
| Tuples.cs:180:9:180:24 | SSA def(y1) | Tuples.cs:182:14:182:15 | access to local variable y1 |
312+
| Tuples.cs:180:24:180:24 | [deconstruct parameter 0] access to local variable r | Tuples.cs:180:9:180:24 | ... = ... |
313+
| Tuples.cs:180:24:180:24 | [deconstruct parameter 1] access to local variable r | Tuples.cs:180:9:180:24 | ... = ... |
309314
| Tuples.cs:180:24:180:24 | access to local variable r | Tuples.cs:180:9:180:20 | (..., ...) |
310315
| Tuples.cs:185:12:185:13 | this | Tuples.cs:185:12:185:13 | this access |
311316
| Tuples.cs:185:12:185:13 | this | Tuples.cs:185:22:185:23 | this |
@@ -337,6 +342,8 @@
337342
| Tuples.cs:200:9:200:22 | ... = ... | Tuples.cs:200:9:200:22 | SSA def(y) |
338343
| Tuples.cs:200:9:200:22 | SSA def(x) | Tuples.cs:201:14:201:14 | access to local variable x |
339344
| Tuples.cs:200:9:200:22 | SSA def(y) | Tuples.cs:202:14:202:14 | access to local variable y |
345+
| Tuples.cs:200:22:200:22 | [deconstruct parameter 0] access to local variable r | Tuples.cs:200:9:200:22 | ... = ... |
346+
| Tuples.cs:200:22:200:22 | [deconstruct parameter 1] access to local variable r | Tuples.cs:200:9:200:22 | ... = ... |
340347
| Tuples.cs:200:22:200:22 | access to local variable r | Tuples.cs:200:9:200:18 | (..., ...) |
341348
| Tuples.cs:205:12:205:13 | this | Tuples.cs:205:12:205:13 | this access |
342349
| Tuples.cs:205:12:205:13 | this | Tuples.cs:205:22:205:23 | this |

‎csharp/ql/test/library-tests/dataflow/tuples/Tuples.cs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ static void M5()
101101
Sink(r.i); // $ hasValueFlow=9
102102

103103
var (a, b) = r;
104-
Sink(a); // $ MISSING: hasValueFlow=9
104+
Sink(a); // $ hasValueFlow=9
105105
Sink(b);
106106

107107
switch (r)
@@ -178,8 +178,8 @@ static void M8()
178178
var r = new R2(o1, o2);
179179
// Implicit call to the compiler-generated Deconstruct method of R2
180180
var (x1, y1) = r;
181-
Sink(x1); // $ MISSING: hasValueFlow=16
182-
Sink(y1); // $ MISSING: hasValueFlow=17
181+
Sink(x1); // $ hasValueFlow=16
182+
Sink(y1); // $ hasValueFlow=17
183183
}
184184

185185
record R3(string X2, string Y2)
@@ -198,8 +198,8 @@ static void M9()
198198
var r = new R3(o1, o2);
199199
// Implicit call to the custom Deconstruct method of R3
200200
var (x, y) = r;
201-
Sink(x); // $ MISSING: hasValueFlow=19
202-
Sink(y); // $ MISSING: hasValueFlow=18
201+
Sink(x); // $ hasValueFlow=19
202+
Sink(y); // $ hasValueFlow=18
203203
}
204204

205205
record R4(string X3, string Y3);
@@ -211,8 +211,8 @@ static void M10()
211211
var r = new R4(o1, o2);
212212
// Explicit call to the compiler-generated Deconstruct method of R4
213213
r.Deconstruct(out var x3, out var y3);
214-
Sink(x3); // $ MISSING: hasValueFlow=20
215-
Sink(y3); // $ MISSING: hasValueFlow=21
214+
Sink(x3); // $ hasValueFlow=20
215+
Sink(y3); // $ hasValueFlow=21
216216
}
217217

218218
public static void Sink(object o) { }

0 commit comments

Comments
 (0)