Skip to content

Fix parameters for EventService.Patch method #21

Description

@ayaanqui

func (service *EventService) Patch(user *types.User, input *types.CreateEvent, event *types.Event) (bool, error) {

The Patch method currently requires the user of the method to fetch the proper event object. However, I think it would be much better to have the method take an id parameter and change the event parameter to output. This way we can use the id parameter to fetch the event and then the updated value can be "returned" using output.

func (service *EventService) Patch(id string, user *types.User, input *types.CreateEvent, output *types.Event) (bool, error)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions